fix: Update configuration stores in ConfigurationRequestor when they are changed on the client (#257)

* reset config stores in the config requestor when set on the client
* tests
* v4.14.4

Author: typotter

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eppo/js-client-sdk-common",
-  "version": "4.14.3",
+  "version": "4.14.4",
   "description": "Common library for Eppo JavaScript SDKs (web, react native, and node)",
   "main": "dist/index.js",
   "files": [

src/client/eppo-client.ts

@@ -270,13 +270,6 @@ export default class EppoClient {
     this.eventDispatcher?.attachContext(key, value);
   }
 
-  // noinspection JSUnusedGlobalSymbols
-  setBanditModelConfigurationStore(
-    banditModelConfigurationStore: IConfigurationStore<BanditParameters>,
-  ) {
-    this.banditModelConfigurationStore = banditModelConfigurationStore;
-  }
-
   // noinspection JSUnusedGlobalSymbols
   /**
    * Setting this value will have no side effects other than triggering a warning when the actual

src/configuration-requestor.spec.ts

@@ -16,7 +16,7 @@ import FetchHttpClient, {
   IUniversalFlagConfigResponse,
 } from './http-client';
 import { StoreBackedConfiguration } from './i-configuration';
-import { BanditParameters, BanditVariation, Flag } from './interfaces';
+import { BanditParameters, BanditVariation, Flag, VariationType } from './interfaces';
 
 describe('ConfigurationRequestor', () => {
   let flagStore: IConfigurationStore<Flag>;
@@ -588,5 +588,72 @@ describe('ConfigurationRequestor', () => {
         expect(fetchSpy.mock.calls.length).toBe(1);
       });
     });
+
+    describe('IConfigurationStore updates', () => {
+      it('should update configuration when stores are changed', async () => {
+        // Create new stores
+        const newFlagStore = new MemoryOnlyConfigurationStore<Flag>();
+        const newBanditVariationStore = new MemoryOnlyConfigurationStore<BanditVariation[]>();
+        const newBanditModelStore = new MemoryOnlyConfigurationStore<BanditParameters>();
+
+        // Add a test flag to the new flag store
+        await newFlagStore.setEntries({
+          'test-flag': {
+            key: 'test-flag',
+            enabled: true,
+            variationType: VariationType.STRING,
+            variations: {
+              control: { key: 'control', value: 'control-value' },
+              treatment: { key: 'treatment', value: 'treatment-value' },
+            },
+            allocations: [
+              {
+                key: 'allocation-1',
+                rules: [],
+                splits: [
+                  {
+                    shards: [{ salt: '', ranges: [{ start: 0, end: 10000 }] }],
+                    variationKey: 'treatment',
+                  },
+                ],
+                doLog: true,
+              },
+            ],
+            totalShards: 10000,
+          },
+        });
+
+        await newBanditModelStore.setEntries({
+          'test-bandit': {
+            banditKey: 'test-bandt',
+            modelVersion: 'v123',
+            modelName: 'falcon',
+            modelData: {
+              coefficients: {},
+              gamma: 0,
+              defaultActionScore: 0,
+              actionProbabilityFloor: 0,
+            },
+          },
+        });
+
+        // Get the configuration and verify it has the test flag
+        const initialConfig = configurationRequestor.getConfiguration();
+        expect(initialConfig.getFlagKeys()).toEqual([]);
+        expect(Object.keys(initialConfig.getBandits())).toEqual([]);
+
+        // Update the stores
+        configurationRequestor.setConfigurationStores(
+          newFlagStore,
+          newBanditVariationStore,
+          newBanditModelStore,
+        );
+
+        // Get the configuration and verify it has the test flag
+        const config = configurationRequestor.getConfiguration();
+        expect(config.getFlagKeys()).toEqual(['test-flag']);
+        expect(Object.keys(config.getBandits())).toEqual(['test-bandit']);
+      });
+    });
   });
 });