Remove old MemoryStore entries when setting new entries (#69)

* test case

* remove old entries

* feedback from PR

Author: aarsilv

.gitignore

@@ -10,5 +10,6 @@ yarn-error.log
 
 test/data
 .vscode/settings.json
+.idea
 
-.DS_Store
+.DS_Store

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eppo/js-client-sdk-common",
-  "version": "3.0.8",
+  "version": "3.0.9",
   "description": "Eppo SDK for client-side JavaScript applications (base for both web and react native)",
   "main": "dist/index.js",
   "files": [
@@ -68,4 +68,4 @@
     "semver": "^7.5.4",
     "universal-base64": "^2.1.0"
   }
-}
+}

src/configuration-store/memory.store.spec.ts

@@ -37,8 +37,14 @@ describe('MemoryOnlyConfigurationStore', () => {
   });
 
   it('should overwrite existing entries', async () => {
-    await memoryStore.setEntries({ key1: 'value1' });
-    await memoryStore.setEntries({ key1: 'newValue1' });
-    expect(memoryStore.get('key1')).toBe('newValue1');
+    await memoryStore.setEntries({ toBeReplaced: 'old value', toBeRemoved: 'delete me' });
+    expect(memoryStore.get('toBeReplaced')).toBe('old value');
+    expect(memoryStore.get('toBeRemoved')).toBe('delete me');
+    expect(memoryStore.get('toBeAdded')).toBeNull();
+
+    await memoryStore.setEntries({ toBeReplaced: 'new value', toBeAdded: 'add me' });
+    expect(memoryStore.get('toBeReplaced')).toBe('new value');
+    expect(memoryStore.get('toBeRemoved')).toBeNull();
+    expect(memoryStore.get('toBeAdded')).toBe('add me');
   });
 });

src/configuration-store/memory.store.ts

@@ -17,9 +17,7 @@ export class MemoryStore<T> implements ISyncStore<T> {
   }
 
   setEntries(entries: Record<string, T>): void {
-    Object.entries(entries).forEach(([key, val]) => {
-      this.store[key] = val;
-    });
+    this.store = { ...entries };
     this.initialized = true;
   }
 }