enable providing subject attributes as string wrapper numerics to be … (#40)

* enable providing subject attributes as string wrapper numerics to be evaluated against numeric rules (FF-1661)

* combine unit tests

Author: leoromanovsky

src/rule_evaluator.spec.ts

@@ -55,6 +55,27 @@ describe('findMatchingRule', () => {
   it('returns null if attributes do not match any rules', () => {
     const rules = [numericRule];
     expect(findMatchingRule({ totalSales: 101 }, rules, false)).toEqual(null);
+
+    // input subject attribute is a string which is not a valid semver nor numeric
+    // verify that is not parsed to a semver nor a numeric.
+    expect(
+      findMatchingRule(
+        { version: '1.2.03' },
+        [
+          {
+            allocationKey: 'test',
+            conditions: [
+              {
+                operator: OperatorType.GTE,
+                attribute: 'version',
+                value: '1.2.0',
+              },
+            ],
+          },
+        ],
+        false,
+      ),
+    ).toEqual(null);
   });
 
   it('returns the rule if attributes match AND conditions', () => {
@@ -79,10 +100,10 @@ describe('findMatchingRule', () => {
     expect(findMatchingRule({ totalSales: 101 }, rules, false)).toEqual(ruleWithEmptyConditions);
   });
 
-  it('returns null if using numeric operator with string', () => {
+  it('allows for a mix of numeric and string values', () => {
     const rules = [numericRule, ruleWithMatchesCondition];
     expect(findMatchingRule({ totalSales: 'stringValue' }, rules, false)).toEqual(null);
-    expect(findMatchingRule({ totalSales: '20' }, rules, false)).toEqual(null);
+    expect(findMatchingRule({ totalSales: '20' }, rules, false)).toEqual(numericRule);
   });
 
   it('handles rule with matches operator', () => {

src/rule_evaluator.ts

@@ -153,11 +153,7 @@ function compareNumber(
   conditionValue: any,
   compareFn: (a: number, b: number) => boolean,
 ): boolean {
-  return (
-    typeof attributeValue === 'number' &&
-    typeof conditionValue === 'number' &&
-    compareFn(attributeValue, conditionValue)
-  );
+  return compareFn(Number(attributeValue), Number(conditionValue));
 }
 
 function compareSemVer(