Skip to content

Commit 2f70a51

Browse files
committed
refactor: eppo client cleanup
1 parent 4d3b534 commit 2f70a51

File tree

5 files changed

+4
-183
lines changed

5 files changed

+4
-183
lines changed

src/client/eppo-client.ts

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { TLRUInMemoryAssignmentCache } from '../cache/tlru-in-memory-assignment-
1717
import { Configuration } from '../configuration';
1818
import ConfigurationRequestor from '../configuration-requestor';
1919
import { ConfigurationStore } from '../configuration-store';
20-
import { IConfigurationStore, ISyncStore } from '../configuration-store/configuration-store';
20+
import { ISyncStore } from '../configuration-store/configuration-store';
2121
import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
2222
import {
2323
ConfigurationWireV1,
@@ -44,12 +44,8 @@ import { FlagEvaluationError } from '../flag-evaluation-error';
4444
import FetchHttpClient from '../http-client';
4545
import {
4646
BanditModelData,
47-
BanditParameters,
48-
BanditVariation,
49-
Flag,
5047
FormatEnum,
5148
IPrecomputedBandit,
52-
ObfuscatedFlag,
5349
PrecomputedFlag,
5450
Variation,
5551
VariationType,
@@ -100,9 +96,6 @@ export type EppoClientParameters = {
10096
// Dispatcher for arbitrary, application-level events (not to be confused with Eppo specific assignment
10197
// or bandit events). These events are application-specific and captures by EppoClient#track API.
10298
eventDispatcher?: EventDispatcher;
103-
flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
104-
banditVariationConfigurationStore?: IConfigurationStore<BanditVariation[]>;
105-
banditModelConfigurationStore?: IConfigurationStore<BanditParameters>;
10699
overrideStore?: ISyncStore<Variation>;
107100
configurationRequestParameters?: FlagConfigurationRequestParameters;
108101
initialConfiguration?: Configuration;
@@ -136,29 +129,17 @@ export default class EppoClient {
136129
private readonly overrideValidator = new OverrideValidator();
137130

138131
private readonly configurationStore;
139-
/** @deprecated use configurationStore instead. */
140-
private flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
141-
/** @deprecated use configurationStore instead. */
142-
private banditModelConfigurationStore?: IConfigurationStore<BanditParameters>;
143-
/** @deprecated use configurationStore instead. */
144-
private banditVariationConfigurationStore?: IConfigurationStore<BanditVariation[]>;
145132

146133
constructor({
147134
eventDispatcher = new NoOpEventDispatcher(),
148135
isObfuscated,
149-
flagConfigurationStore,
150-
banditVariationConfigurationStore,
151-
banditModelConfigurationStore,
152136
overrideStore,
153137
configurationRequestParameters,
154138
initialConfiguration,
155139
}: EppoClientParameters) {
156140
this.configurationStore = new ConfigurationStore(initialConfiguration);
157141

158142
this.eventDispatcher = eventDispatcher;
159-
this.flagConfigurationStore = flagConfigurationStore;
160-
this.banditVariationConfigurationStore = banditVariationConfigurationStore;
161-
this.banditModelConfigurationStore = banditModelConfigurationStore;
162143
this.overrideStore = overrideStore;
163144
this.configurationRequestParameters = configurationRequestParameters;
164145

src/client/test-utils.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
import ApiEndpoints from '../api-endpoints';
22
import ConfigurationRequestor from '../configuration-requestor';
3-
import { IConfigurationStore } from '../configuration-store/configuration-store';
3+
import { ConfigurationStore } from '../configuration-store';
44
import FetchHttpClient from '../http-client';
5-
import { Flag, ObfuscatedFlag } from '../interfaces';
65

7-
export async function initConfiguration(
8-
configurationStore: IConfigurationStore<Flag | ObfuscatedFlag>,
9-
) {
6+
export async function initConfiguration(configurationStore: ConfigurationStore) {
107
const apiEndpoints = new ApiEndpoints({
118
baseUrl: 'http://127.0.0.1:4000',
129
queryParams: {
@@ -16,11 +13,6 @@ export async function initConfiguration(
1613
},
1714
});
1815
const httpClient = new FetchHttpClient(apiEndpoints, 1000);
19-
const configurationRequestor = new ConfigurationRequestor(
20-
httpClient,
21-
configurationStore,
22-
null,
23-
null,
24-
);
16+
const configurationRequestor = new ConfigurationRequestor(httpClient, configurationStore);
2517
await configurationRequestor.fetchAndStoreConfigurations();
2618
}

src/configuration-wire/configuration-wire-helper.spec.ts

Lines changed: 0 additions & 98 deletions
This file was deleted.

src/configuration-wire/configuration-wire-helper.ts

Lines changed: 0 additions & 52 deletions
This file was deleted.

src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import {
3333
} from './configuration-store/configuration-store';
3434
import { HybridConfigurationStore } from './configuration-store/hybrid.store';
3535
import { MemoryStore, MemoryOnlyConfigurationStore } from './configuration-store/memory.store';
36-
import { ConfigurationWireHelper } from './configuration-wire/configuration-wire-helper';
3736
import {
3837
IConfigurationWire,
3938
IObfuscatedPrecomputedConfigurationResponse,
@@ -156,7 +155,6 @@ export {
156155
IPrecomputedConfigurationResponse,
157156
PrecomputedFlag,
158157
FlagKey,
159-
ConfigurationWireHelper,
160158

161159
// Test helpers
162160
decodePrecomputedFlag,

0 commit comments

Comments
 (0)