polling bandits only when needed

Author: maya-the-mango

src/configuration-requestor.ts

@@ -42,23 +42,57 @@ export default class ConfigurationRequestor {
         format: configResponse.format,
       });
 
-      // TODO: different polling intervals for bandit parameters
-      const banditResponse = await this.httpClient.getBanditParameters();
-      if (banditResponse?.bandits) {
-        if (!this.banditModelConfigurationStore) {
-          throw new Error('Bandit parameters fetched but no bandit configuration store provided');
-        }
+      if (this.requiresBanditModelConfigurationStoreUpdate(configResponse.banditReferences)) {
+        const banditResponse = await this.httpClient.getBanditParameters();
+        if (banditResponse?.bandits) {
+          if (!this.banditModelConfigurationStore) {
+            throw new Error('Bandit parameters fetched but no bandit configuration store provided');
+          }
 
-        await hydrateConfigurationStore(this.banditModelConfigurationStore, {
-          entries: banditResponse.bandits,
-          environment: configResponse.environment,
-          createdAt: configResponse.createdAt,
-          format: configResponse.format,
-        });
+          await hydrateConfigurationStore(this.banditModelConfigurationStore, {
+            entries: banditResponse.bandits,
+            environment: configResponse.environment,
+            createdAt: configResponse.createdAt,
+            format: configResponse.format,});
+        }
       }
     }
   }
 
+  private getLoadedBanditModelVersions(
+    banditModelConfigurationStore: IConfigurationStore<BanditParameters> | null,
+  ) {
+    if (banditModelConfigurationStore === null) {
+      return [];
+    }
+    return Object.values(banditModelConfigurationStore.entries()).map(
+      (banditParam: BanditParameters) => banditParam.modelVersion,
+    );
+  }
+
+  private requiresBanditModelConfigurationStoreUpdate(
+    banditReferences: Record<string, BanditReference>,
+  ): boolean {
+    if (!this.banditModelConfigurationStore) {
+      throw new Error('Bandit parameters fetched but no bandit configuration store provided');
+    }
+    const referencedModelVersions = Object.values(banditReferences).map(
+      (banditReference: BanditReference) => banditReference.modelVersion
+    );
+
+    const banditModelVersionsInStore = this.getLoadedBanditModelVersions(
+      this.banditModelConfigurationStore,
+    );
+
+    referencedModelVersions.forEach((modelVersion) => {
+      if (!banditModelVersionsInStore.includes(modelVersion)) {
+        return false;
+      }
+    });
+
+    return true;
+  }
+
   private indexBanditVariationsByFlagKey(
     banditVariationsByBanditKey: Record<string, BanditVariation[]>,
   ): Record<string, BanditVariation[]> {

src/http-client.ts

@@ -1,6 +1,7 @@
 import ApiEndpoints from './api-endpoints';
 import {
   BanditParameters,
+  BanditReference,
   BanditVariation,
   Environment,
   Flag,
@@ -36,6 +37,7 @@ export interface IUniversalFlagConfigResponse {
   environment: Environment;
   flags: Record<string, Flag>;
   bandits: Record<string, BanditVariation[]>;
+  banditReferences: Record<string, BanditReference>;
 }
 
 export interface IBanditParametersResponse {

src/interfaces.ts

@@ -101,6 +101,11 @@ export interface BanditVariation {
   variationValue: string;
 }
 
+export interface BanditReference {
+  modelVersion: string;
+  flagVariation: BanditVariation[];
+}
+
 export interface BanditParameters {
   banditKey: string;
   modelName: string;