feat: make getPrecomputedConfiguration return Configuration instead of string

Author: rasendubi

src/client/eppo-client-with-bandits.spec.ts

@@ -26,6 +26,12 @@ import { attributeEncodeBase64 } from '../obfuscation';
 import { Attributes, BanditActions, ContextAttributes } from '../types';
 
 import EppoClient, { IAssignmentDetails } from './eppo-client';
+import { Configuration } from '../configuration';
+
+const salt = base64.fromUint8Array(new Uint8Array([101, 112, 112, 111]));
+jest.mock('../salt', () => ({
+  generateSalt: () => salt,
+}));
 
 describe('EppoClient Bandits E2E test', () => {
   let client: EppoClient;
@@ -688,20 +694,12 @@ describe('EppoClient Bandits E2E test', () => {
       subjectKey: string,
       subjectAttributes: ContextAttributes,
       banditActions: Record<string, BanditActions>,
-    ): IPrecomputedConfiguration {
-      const salt = base64.fromUint8Array(new Uint8Array([101, 112, 112, 111]));
-      const precomputedResults = client.getPrecomputedConfiguration(
+    ): Configuration {
+      return client.getPrecomputedConfiguration(
         subjectKey,
         subjectAttributes,
         banditActions,
-        salt,
       );
-
-      const { precomputed } = JSON.parse(precomputedResults);
-      if (!precomputed) {
-        fail('precomputed result was not parsed');
-      }
-      return precomputed;
     }
 
     describe('obfuscated results', () => {
@@ -713,11 +711,11 @@ describe('EppoClient Bandits E2E test', () => {
         const adidasB64 = 'YWRpZGFz';
         const modelB64 = 'MTIz'; // 123
 
-        const precomputed = getPrecomputedResults(client, bob, bobInfo, bobActions);
-
-        const response = JSON.parse(
-          precomputed.response,
-        ) as IObfuscatedPrecomputedConfigurationResponse;
+        const configuration = client.getPrecomputedConfiguration(bob, bobInfo, bobActions);
+        const response = configuration.getPrecomputedConfiguration()?.response;
+        if (!response) {
+          fail('precomputed result was not parsed');
+        }
 
         const numericAttrs = response.bandits[bannerBanditFlagMd5]['actionNumericAttributes'];
         const categoricalAttrs =

src/client/eppo-client.spec.ts

@@ -41,8 +41,12 @@ import { ISyncStore } from '../configuration-store/configuration-store';
 
 // Use a known salt to produce deterministic hashes
 const salt = base64.fromUint8Array(new Uint8Array([7, 53, 17, 78]));
+jest.mock('../salt', () => ({
+  generateSalt: () => salt,
+}));
 
 describe('EppoClient E2E test', () => {
+
   // Configure fetch mock for tests that still need it
   global.fetch = jest.fn(() => {
     const ufc = readMockUFCResponse(MOCK_UFC_RESPONSE_FILE);
@@ -254,14 +258,12 @@ describe('EppoClient E2E test', () => {
     });
 
     it('skips disabled flags', () => {
-      const encodedPrecomputedWire = client.getPrecomputedConfiguration('subject', {}, {}, salt);
-      const { precomputed } = JSON.parse(encodedPrecomputedWire) as IConfigurationWire;
+      const configuration = client.getPrecomputedConfiguration('subject', {}, {});
+      const precomputed = configuration.getPrecomputedConfiguration();
       if (!precomputed) {
         fail('Precomputed data not in Configuration response');
       }
-      const precomputedResponse = JSON.parse(
-        precomputed.response,
-      ) as ObfuscatedPrecomputedConfigurationResponse;
+      const precomputedResponse = precomputed.response;
 
       expect(precomputedResponse).toBeTruthy();
       const precomputedFlags = precomputedResponse?.flags ?? {};
@@ -273,14 +275,12 @@ describe('EppoClient E2E test', () => {
     });
 
     it('evaluates and returns assignments', () => {
-      const encodedPrecomputedWire = client.getPrecomputedConfiguration('subject', {}, {}, salt);
-      const { precomputed } = JSON.parse(encodedPrecomputedWire) as IConfigurationWire;
+      const configuration = client.getPrecomputedConfiguration('subject', {}, {});
+      const precomputed = configuration.getPrecomputedConfiguration();
       if (!precomputed) {
         fail('Precomputed data not in Configuration response');
       }
-      const precomputedResponse = JSON.parse(
-        precomputed.response,
-      ) as IObfuscatedPrecomputedConfigurationResponse;
+      const precomputedResponse = precomputed.response;
 
       expect(precomputedResponse).toBeTruthy();
       const precomputedFlags = precomputedResponse?.flags ?? {};
@@ -291,12 +291,12 @@ describe('EppoClient E2E test', () => {
     });
 
     it('obfuscates assignments', () => {
-      const encodedPrecomputedWire = client.getPrecomputedConfiguration('subject', {}, {}, salt);
-      const { precomputed } = JSON.parse(encodedPrecomputedWire) as IConfigurationWire;
+      const configuration = client.getPrecomputedConfiguration('subject', {}, {});
+      const precomputed = configuration.getPrecomputedConfiguration();
       if (!precomputed) {
         fail('Precomputed data not in Configuration response');
       }
-      const precomputedResponse = JSON.parse(precomputed.response);
+      const precomputedResponse = precomputed.response;
 
       expect(precomputedResponse).toBeTruthy();
       expect(precomputedResponse.salt).toEqual('BzURTg==');