Consolidate getAssignmentsWithSubjectAttributes and getAssignments into one function (#22)

* Consolidate getAssignmentsWithSubjectAttributes and getAssignments into one function

* Delete unused getAssignments function

Author: sameerank

src/client/eppo-client.spec.ts

@@ -246,9 +246,13 @@ describe('EppoClient E2E test', () => {
       }: IAssignmentTestCase) => {
         `---- Test Case for ${experiment} Experiment ----`;
 
-        const assignments = subjectsWithAttributes
-          ? getAssignmentsWithSubjectAttributes(subjectsWithAttributes, experiment, valueType)
-          : getAssignments(subjects, experiment, valueType);
+        const assignments = getAssignmentsWithSubjectAttributes(
+          subjectsWithAttributes
+            ? subjectsWithAttributes
+            : subjects.map((subject) => ({ subjectKey: subject })),
+          experiment,
+          valueType,
+        );
 
         switch (valueType) {
           case ValueTestType.BoolType: {
@@ -391,43 +395,11 @@ describe('EppoClient E2E test', () => {
     expect(assignment).toEqual('control');
   });
 
-  function getAssignments(
-    subjects: string[],
-    experiment: string,
-    valueTestType: ValueTestType = ValueTestType.StringType,
-  ): (EppoValue | null)[] {
-    return subjects.map((subjectKey) => {
-      switch (valueTestType) {
-        case ValueTestType.BoolType: {
-          const ba = globalClient.getBoolAssignment(subjectKey, experiment);
-          if (ba === null) return null;
-          return EppoValue.Bool(ba);
-        }
-        case ValueTestType.NumericType: {
-          const na = globalClient.getNumericAssignment(subjectKey, experiment);
-          if (na === null) return null;
-          return EppoValue.Numeric(na);
-        }
-        case ValueTestType.StringType: {
-          const sa = globalClient.getStringAssignment(subjectKey, experiment);
-          if (sa === null) return null;
-          return EppoValue.String(sa);
-        }
-        case ValueTestType.JSONType: {
-          const sa = globalClient.getJSONStringAssignment(subjectKey, experiment);
-          const oa = globalClient.getParsedJSONAssignment(subjectKey, experiment);
-          if (oa == null || sa === null) return null;
-          return EppoValue.JSON(sa, oa);
-        }
-      }
-    });
-  }
-
   function getAssignmentsWithSubjectAttributes(
     subjectsWithAttributes: {
       subjectKey: string;
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      subjectAttributes: Record<string, any>;
+      subjectAttributes?: Record<string, any>;
     }[],
     experiment: string,
     valueTestType: ValueTestType = ValueTestType.StringType,