added tests for polling bandits only when needed

Author: maya-the-mango

src/configuration-requestor.spec.ts

@@ -203,5 +203,13 @@ describe('ConfigurationRequestor', () => {
       await configurationRequestor.fetchAndStoreConfigurations();
       expect(fetchSpy).toHaveBeenCalledTimes(1);
     });
+
+    it('Requests bandits only when model versions are different', async () => {
+      await configurationRequestor.fetchAndStoreConfigurations();
+      expect(fetchSpy).toHaveBeenCalledTimes(2); // Once for UFC, another for bandits
+
+      await configurationRequestor.fetchAndStoreConfigurations();
+      expect(fetchSpy).toHaveBeenCalledTimes(3); // Once just for UFC, bandits should be skipped
+    });
   });
 });

src/configuration-requestor.ts

@@ -49,9 +49,6 @@ export default class ConfigurationRequestor {
         createdAt: configResponse.createdAt,
       });
 
-      if (!this.banditModelConfigurationStore) {
-        throw new Error('Bandit parameters fetched but no bandit configuration store provided');
-      }
       if (
         this.requiresBanditModelConfigurationStoreUpdate(
           this.banditModelVersions,
@@ -97,13 +94,9 @@ export default class ConfigurationRequestor {
       (banditReference: BanditReference) => banditReference.modelVersion,
     );
 
-    referencedModelVersions.forEach((modelVersion) => {
-      if (!currentBanditModelVersions.includes(modelVersion)) {
-        return false;
-      }
-    });
-
-    return true;
+    return !referencedModelVersions.every((modelVersion) =>
+      currentBanditModelVersions.includes(modelVersion),
+    );
   }
 
   private async hydrateConfigurationStore<T extends Entry>(