Only check for salt and store initialization if the store is non-empty

Author: sameerank

src/client/eppo-precomputed-client.spec.ts

@@ -30,6 +30,7 @@ import EppoPrecomputedClient, {
   PrecomputedFlagsRequestParameters,
   Subject,
 } from './eppo-precomputed-client';
+import { applicationLogger } from '..';
 
 describe('EppoPrecomputedClient E2E test', () => {
   const precomputedConfigurationWire = readMockConfigurationWireResponse(
@@ -52,6 +53,7 @@ describe('EppoPrecomputedClient E2E test', () => {
     subjectKey: 'test-subject',
     subjectAttributes: { attr1: 'value1' },
   };
+
   beforeEach(async () => {
     storage = new MemoryOnlyConfigurationStore<PrecomputedFlag>();
     storage.setFormat(FormatEnum.PRECOMPUTED);
@@ -110,6 +112,52 @@ describe('EppoPrecomputedClient E2E test', () => {
     });
   });
 
+  describe('store initialization logged errors', () => {
+    let mockError: jest.SpyInstance;
+
+    beforeEach(() => {
+      mockError = jest.spyOn(applicationLogger, 'error');
+    });
+
+    afterEach(() => {
+      mockError.mockRestore();
+    });
+
+    it('logs error when initialized with store without salt', () => {
+      const emptyStore = new MemoryOnlyConfigurationStore<PrecomputedFlag>();
+      new EppoPrecomputedClient({
+        precomputedFlagStore: emptyStore,
+        subject: {
+          subjectKey: '',
+          subjectAttributes: {},
+        },
+      });
+      expect(mockError).not.toHaveBeenCalledWith(
+        'EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided',
+      );
+    });
+
+    it('logs error when initialized with store without salt', () => {
+      const nonemptyStore = new MemoryOnlyConfigurationStore<PrecomputedFlag>();
+      // Incorrectly initialized: no salt, not set to initialized
+      jest.spyOn(nonemptyStore, 'getKeys').mockReturnValue(['some-key']);
+
+      new EppoPrecomputedClient({
+        precomputedFlagStore: nonemptyStore,
+        subject: {
+          subjectKey: '',
+          subjectAttributes: {},
+        },
+      });
+      expect(mockError).toHaveBeenCalledWith(
+        '[Eppo SDK] EppoPrecomputedClient requires an initialized precomputedFlagStore if requestParameters are not provided',
+      );
+      expect(mockError).toHaveBeenCalledWith(
+        '[Eppo SDK] EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided',
+      );
+    });
+  });
+
   describe('setLogger', () => {
     let flagStorage: IConfigurationStore<PrecomputedFlag>;
     let subject: Subject;

src/client/eppo-precomputed-client.ts

@@ -100,13 +100,21 @@ export default class EppoPrecomputedClient {
       // Online-mode
       this.requestParameters = options.requestParameters;
     } else {
-      // Offline-mode
-
-      // Offline mode depends on pre-populated IConfigurationStores (flags and bandits) to source configuration.
-      if (!this.precomputedFlagStore.isInitialized()) {
-        logger.error(
-          `${loggerPrefix} EppoPrecomputedClient requires an initialized precomputedFlagStore if requestParameters are not provided`,
-        );
+      // Offline-mode -- depends on pre-populated IConfigurationStores (flags and bandits) to source configuration.
+
+      // Allow an empty precomputedFlagStore to be passed in, but if it has items, ensure it was initialized properly.
+      if (this.precomputedFlagStore.getKeys().length > 0) {
+        if (!this.precomputedFlagStore.isInitialized()) {
+          logger.error(
+            `${loggerPrefix} EppoPrecomputedClient requires an initialized precomputedFlagStore if requestParameters are not provided`,
+          );
+        }
+
+        if (!this.precomputedFlagStore.salt) {
+          logger.error(
+            `${loggerPrefix} EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided`,
+          );
+        }
       }
 
       if (this.precomputedBanditStore && !this.precomputedBanditStore.isInitialized()) {
@@ -115,11 +123,6 @@ export default class EppoPrecomputedClient {
         );
       }
 
-      if (!this.precomputedFlagStore.salt) {
-        logger.error(
-          `${loggerPrefix} EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided`,
-        );
-      }
 
       if (this.precomputedBanditStore && !this.precomputedBanditStore.salt) {
         logger.warn(