update hashing

Author: typotter

src/client/eppo-precomputed-client.spec.ts

@@ -702,7 +702,7 @@ describe('EppoPrecomputedClient E2E test', () => {
       client.setSubjectSaltAndPrecomputedFlagStore(
         'test-subject',
         { attr1: 'value1' },
-        encodeBase64(salt),
+        salt,
         storage,
       );
 
@@ -750,7 +750,7 @@ describe('EppoPrecomputedClient E2E test', () => {
       client.setSubjectSaltAndPrecomputedFlagStore(
         'test-subject',
         {},
-        encodeBase64('sodium-chloride'),
+        'sodiumchloride',
         store,
       );
       expect(client.getStringAssignment('test-flag', 'default')).toBe('default');

src/client/eppo-precomputed-client.ts

@@ -67,7 +67,7 @@ export default class EppoPrecomputedClient {
   private precomputedFlagsRequestParameters?: PrecomputedFlagsRequestParameters;
   private subjectKey?: string;
   private subjectAttributes?: Attributes;
-  private decodedFlagKeySalt = '';
+  private flagKeySalt = '';
   private precomputedFlagStore: IConfigurationStore<PrecomputedFlag>;
   private isObfuscated: boolean;
 
@@ -80,8 +80,8 @@ export default class EppoPrecomputedClient {
     this.isObfuscated = isObfuscated;
   }
 
-  private setDecodedFlagKeySalt(salt: string) {
-    this.decodedFlagKeySalt = salt;
+  private setFlagKeySalt(salt: string) {
+    this.flagKeySalt = salt;
   }
 
   private setPrecomputedFlagsRequestParameters(parameters: PrecomputedFlagsRequestParameters) {
@@ -144,7 +144,7 @@ export default class EppoPrecomputedClient {
 
     // A callback to capture the salt and subject information
     precomputedRequestor.onPrecomputedResponse = (responseData) => {
-      this.setDecodedFlagKeySalt(decodeBase64(responseData.salt));
+      this.setFlagKeySalt(responseData.salt);
       this.setSubjectData(responseData.subjectKey, responseData.subjectAttributes);
     };
 
@@ -186,7 +186,7 @@ export default class EppoPrecomputedClient {
   ) {
     this.setPrecomputedFlagStore(precomputedFlagStore);
     this.setSubjectData(subjectKey, subjectAttributes);
-    this.setDecodedFlagKeySalt(decodeBase64(salt));
+    this.setFlagKeySalt(salt);
   }
 
   private getPrecomputedAssignment<T>(
@@ -312,7 +312,7 @@ export default class EppoPrecomputedClient {
   }
 
   private getObfuscatedFlag(flagKey: string): DecodedPrecomputedFlag | null {
-    const saltedAndHashedFlagKey = getMD5Hash(flagKey, this.decodedFlagKeySalt);
+    const saltedAndHashedFlagKey = getMD5Hash(flagKey, this.flagKeySalt);
     const precomputedFlag: PrecomputedFlag | null = this.precomputedFlagStore.get(
       saltedAndHashedFlagKey,
     ) as PrecomputedFlag;

src/obfuscation.ts

@@ -4,7 +4,7 @@ import * as SparkMD5 from 'spark-md5';
 import { PrecomputedFlag } from './interfaces';
 
 export function getMD5Hash(input: string, salt = ''): string {
-  return new SparkMD5().appendBinary(salt).append(input).end();
+  return new SparkMD5().append(salt).append(input).end();
 }
 
 export function encodeBase64(input: string) {