check explicitly for null

petzel · petzel · commit 6a2a8ba317ac · 2023-08-09T10:10:28.000-05:00
diff --git a/src/client/eppo-client.ts b/src/client/eppo-client.ts
@@ -81,7 +81,7 @@ export default class EppoClient implements IEppoClient {
     assignmentHooks: IAssignmentHooks,
   ): Promise<string> {
     let assignment = await assignmentHooks?.onPreAssignment(subjectKey);
-    if (!assignment) {
+    if (assignment == null) {
       assignment = this.getAssignment(subjectKey, experimentKey, subjectAttributes);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ export default class EppoClient implements IEppoClient {`
`81`	`81`	`assignmentHooks: IAssignmentHooks,`
`82`	`82`	`): Promise<string> {`
`83`	`83`	`let assignment = await assignmentHooks?.onPreAssignment(subjectKey);`
`84`		`- if (!assignment) {`
	`84`	`+ if (assignment == null) {`
`85`	`85`	`assignment = this.getAssignment(subjectKey, experimentKey, subjectAttributes);`
`86`	`86`	`}`
`87`	`87`