chore: Cleanup IConfigurationStore interface (#84)

* chore: Cleanup IConfigurationStore interface

* fix tests

Author: felipecsl

src/configuration-store/configuration-store.ts

@@ -21,9 +21,6 @@
  * implementation specific and handled upstream.
  */
 export interface IConfigurationStore<T> {
-  servingStore: ISyncStore<T>;
-  persistentStore: IAsyncStore<T> | null;
-
   init(): Promise<void>;
   get(key: string): T | null;
   getKeys(): string[];

src/configuration-store/hybrid.store.ts

@@ -3,13 +3,10 @@ import { logger, loggerPrefix } from '../application-logger';
 import { IAsyncStore, IConfigurationStore, ISyncStore } from './configuration-store';
 
 export class HybridConfigurationStore<T> implements IConfigurationStore<T> {
-  servingStore: ISyncStore<T>;
-  persistentStore: IAsyncStore<T> | null;
-
-  constructor(servingStore: ISyncStore<T>, persistentStore: IAsyncStore<T> | null) {
-    this.servingStore = servingStore;
-    this.persistentStore = persistentStore;
-  }
+  constructor(
+    private readonly servingStore: ISyncStore<T>,
+    private readonly persistentStore: IAsyncStore<T> | null,
+  ) {}
 
   /**
    * Initialize the configuration store by loading the entries from the persistent store into the serving store.
@@ -41,8 +38,8 @@ export class HybridConfigurationStore<T> implements IConfigurationStore<T> {
   }
 
   public async isExpired(): Promise<boolean> {
-    const isExpired = (await this.persistentStore?.isExpired()) ?? true;
-    return isExpired;
+    const isExpired = await this.persistentStore?.isExpired();
+    return isExpired ?? true;
   }
 
   public get(key: string): T | null {

src/configuration-store/memory.store.ts

@@ -1,4 +1,4 @@
-import { IAsyncStore, IConfigurationStore, ISyncStore } from './configuration-store';
+import { IConfigurationStore, ISyncStore } from './configuration-store';
 
 export class MemoryStore<T> implements ISyncStore<T> {
   private store: Record<string, T> = {};
@@ -23,15 +23,8 @@ export class MemoryStore<T> implements ISyncStore<T> {
 }
 
 export class MemoryOnlyConfigurationStore<T> implements IConfigurationStore<T> {
-  servingStore: ISyncStore<T>;
-  persistentStore: IAsyncStore<T> | null;
-  private initialized: boolean;
-
-  constructor() {
-    this.servingStore = new MemoryStore<T>();
-    this.persistentStore = null;
-    this.initialized = false;
-  }
+  private readonly servingStore: ISyncStore<T> = new MemoryStore<T>();
+  private initialized = false;
 
   init(): Promise<void> {
     this.initialized = true;