Skip to content

Commit 8ce8737

Browse files
sameeranksameerank
authored
chore: use loggerPrefix (#201)
* chore: use loggerPrefix * chore: export loggerPrefix to use in dependent sdks
1 parent 8a07c10 commit 8ce8737

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

‎src/client/eppo-client.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { v4 as randomUUID } from 'uuid';
22

33
import ApiEndpoints from '../api-endpoints';
4-
import { logger } from '../application-logger';
4+
import { logger, loggerPrefix } from '../application-logger';
55
import { IAssignmentEvent, IAssignmentLogger } from '../assignment-logger';
66
import {
77
ensureActionsWithContextualAttributes,
@@ -809,7 +809,7 @@ export default class EppoClient {
809809

810810
private rethrowIfNotGraceful(err: Error, defaultValue?: EppoValue): EppoValue {
811811
if (this.isGracefulFailureMode) {
812-
logger.error(`[Eppo SDK] Error getting assignment: ${err.message}`);
812+
logger.error(`${loggerPrefix} Error getting assignment: ${err.message}`);
813813
return defaultValue ?? EppoValue.Null();
814814
}
815815
throw err;
@@ -827,7 +827,7 @@ export default class EppoClient {
827827
flagKeys.forEach((flagKey) => {
828828
const flag = this.getFlag(flagKey);
829829
if (!flag) {
830-
logger.debug(`[Eppo SDK] No assigned variation. Flag does not exist.`);
830+
logger.debug(`${loggerPrefix} No assigned variation. Flag does not exist.`);
831831
return;
832832
}
833833

@@ -842,7 +842,7 @@ export default class EppoClient {
842842

843843
// allocationKey is set along with variation when there is a result. this check appeases typescript below
844844
if (!evaluation.variation || !evaluation.allocationKey) {
845-
logger.debug(`[Eppo SDK] No assigned variation: ${flagKey}`);
845+
logger.debug(`${loggerPrefix} No assigned variation: ${flagKey}`);
846846
return;
847847
}
848848

@@ -927,7 +927,7 @@ export default class EppoClient {
927927
const flag = this.getFlag(flagKey);
928928

929929
if (flag === null) {
930-
logger.warn(`[Eppo SDK] No assigned variation. Flag not found: ${flagKey}`);
930+
logger.warn(`${loggerPrefix} No assigned variation. Flag not found: ${flagKey}`);
931931
// note: this is different from the Python SDK, which returns None instead
932932
const flagEvaluationDetails = flagEvaluationDetailsBuilder.buildForNoneResult(
933933
'FLAG_UNRECOGNIZED_OR_DISABLED',
@@ -961,7 +961,7 @@ export default class EppoClient {
961961
}
962962

963963
if (!flag.enabled) {
964-
logger.info(`[Eppo SDK] No assigned variation. Flag is disabled: ${flagKey}`);
964+
logger.info(`${loggerPrefix} No assigned variation. Flag is disabled: ${flagKey}`);
965965
// note: this is different from the Python SDK, which returns None instead
966966
const flagEvaluationDetails = flagEvaluationDetailsBuilder.buildForNoneResult(
967967
'FLAG_UNRECOGNIZED_OR_DISABLED',
@@ -994,7 +994,7 @@ export default class EppoClient {
994994
this.maybeLogAssignment(result);
995995
}
996996
} catch (error) {
997-
logger.error(`[Eppo SDK] Error logging assignment event: ${error}`);
997+
logger.error(`${loggerPrefix} Error logging assignment event: ${error}`);
998998
}
999999

10001000
return result;
@@ -1147,7 +1147,7 @@ export default class EppoClient {
11471147
try {
11481148
logFunction(event);
11491149
} catch (error: any) {
1150-
logger.error(`[Eppo SDK] Error flushing event to logger: ${error.message}`);
1150+
logger.error(`${loggerPrefix} Error flushing event to logger: ${error.message}`);
11511151
}
11521152
});
11531153
}
@@ -1196,7 +1196,7 @@ export default class EppoClient {
11961196
variationKey: variation?.key ?? '__eppo_no_variation',
11971197
});
11981198
} catch (error: any) {
1199-
logger.error(`[Eppo SDK] Error logging assignment event: ${error.message}`);
1199+
logger.error(`${loggerPrefix} Error logging assignment event: ${error.message}`);
12001200
}
12011201
}
12021202

‎src/client/eppo-precomputed-client.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import ApiEndpoints from '../api-endpoints';
2-
import { logger } from '../application-logger';
2+
import { logger, loggerPrefix } from '../application-logger';
33
import { IAssignmentEvent, IAssignmentLogger } from '../assignment-logger';
44
import {
55
ensureContextualSubjectAttributes,
@@ -100,25 +100,25 @@ export default class EppoPrecomputedClient {
100100
// Offline mode depends on pre-populated IConfigurationStores (flags and bandits) to source configuration.
101101
if (!this.precomputedFlagStore.isInitialized()) {
102102
logger.error(
103-
'[Eppo SDK] EppoPrecomputedClient requires an initialized precomputedFlagStore if requestParameters are not provided',
103+
`${loggerPrefix} EppoPrecomputedClient requires an initialized precomputedFlagStore if requestParameters are not provided`,
104104
);
105105
}
106106

107107
if (this.precomputedBanditStore && !this.precomputedBanditStore.isInitialized()) {
108108
logger.error(
109-
'[Eppo SDK] Passing banditOptions without requestParameters requires an initialized precomputedBanditStore',
109+
`${loggerPrefix} Passing banditOptions without requestParameters requires an initialized precomputedBanditStore`,
110110
);
111111
}
112112

113113
if (!this.precomputedFlagStore.salt) {
114114
logger.error(
115-
'[Eppo SDK] EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided',
115+
`${loggerPrefix} EppoPrecomputedClient requires a precomputedFlagStore with a salt if requestParameters are not provided`,
116116
);
117117
}
118118

119119
if (this.precomputedBanditStore && !this.precomputedBanditStore.salt) {
120120
logger.warn(
121-
'[Eppo SDK] EppoPrecomputedClient missing or empty salt for precomputedBanditStore',
121+
`${loggerPrefix} EppoPrecomputedClient missing or empty salt for precomputedBanditStore`,
122122
);
123123
}
124124
}
@@ -202,13 +202,13 @@ export default class EppoPrecomputedClient {
202202
const precomputedFlag = this.getPrecomputedFlag(flagKey);
203203

204204
if (precomputedFlag == null) {
205-
logger.warn(`[Eppo SDK] No assigned variation. Flag not found: ${flagKey}`);
205+
logger.warn(`${loggerPrefix} No assigned variation. Flag not found: ${flagKey}`);
206206
return defaultValue;
207207
}
208208

209209
// Add type checking before proceeding
210210
if (!checkTypeMatch(expectedType, precomputedFlag.variationType)) {
211-
const errorMessage = `[Eppo SDK] Type mismatch: expected ${expectedType} but flag ${flagKey} has type ${precomputedFlag.variationType}`;
211+
const errorMessage = `${loggerPrefix} Type mismatch: expected ${expectedType} but flag ${flagKey} has type ${precomputedFlag.variationType}`;
212212
logger.error(errorMessage);
213213
return defaultValue;
214214
}
@@ -232,15 +232,15 @@ export default class EppoPrecomputedClient {
232232
this.logAssignment(result);
233233
}
234234
} catch (error) {
235-
logger.error(`[Eppo SDK] Error logging assignment event: ${error}`);
235+
logger.error(`${loggerPrefix} Error logging assignment event: ${error}`);
236236
}
237237

238238
try {
239239
return result.variation?.value !== undefined
240240
? valueTransformer(result.variation.value)
241241
: defaultValue;
242242
} catch (error) {
243-
logger.error(`[Eppo SDK] Error transforming value: ${error}`);
243+
logger.error(`${loggerPrefix} Error transforming value: ${error}`);
244244
return defaultValue;
245245
}
246246
}
@@ -314,7 +314,7 @@ export default class EppoPrecomputedClient {
314314
const banditEvaluation = this.getPrecomputedBandit(flagKey);
315315

316316
if (banditEvaluation == null) {
317-
logger.warn(`[Eppo SDK] No assigned variation. Bandit not found: ${flagKey}`);
317+
logger.warn(`${loggerPrefix} No assigned variation. Bandit not found: ${flagKey}`);
318318
return { variation: defaultValue, action: null };
319319
}
320320

@@ -338,7 +338,7 @@ export default class EppoPrecomputedClient {
338338
try {
339339
this.logBanditAction(banditEvent);
340340
} catch (error) {
341-
logger.error(`[Eppo SDK] Error logging bandit action: ${error}`);
341+
logger.error(`${loggerPrefix} Error logging bandit action: ${error}`);
342342
}
343343

344344
return { variation: defaultValue, action: banditEvent.action };
@@ -415,7 +415,7 @@ export default class EppoPrecomputedClient {
415415
logFunction(event);
416416
// eslint-disable-next-line @typescript-eslint/no-explicit-any
417417
} catch (error: any) {
418-
logger.error(`[Eppo SDK] Error flushing event to logger: ${error.message}`);
418+
logger.error(`${loggerPrefix} Error flushing event to logger: ${error.message}`);
419419
}
420420
});
421421
}
@@ -464,7 +464,7 @@ export default class EppoPrecomputedClient {
464464
});
465465
// eslint-disable-next-line @typescript-eslint/no-explicit-any
466466
} catch (error: any) {
467-
logger.error(`[Eppo SDK] Error logging assignment event: ${error.message}`);
467+
logger.error(`${loggerPrefix} Error logging assignment event: ${error.message}`);
468468
}
469469
}
470470

‎src/index.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import ApiEndpoints from './api-endpoints';
2-
import { logger as applicationLogger } from './application-logger';
2+
import { logger as applicationLogger, loggerPrefix } from './application-logger';
33
import { IAssignmentHooks } from './assignment-hooks';
44
import { IAssignmentLogger, IAssignmentEvent } from './assignment-logger';
55
import { IBanditLogger, IBanditEvent } from './bandit-logger';
@@ -66,6 +66,7 @@ import {
6666
import * as validation from './validation';
6767

6868
export {
69+
loggerPrefix,
6970
applicationLogger,
7071
AbstractAssignmentCache,
7172
IAssignmentDetails,

0 commit comments

Comments
 (0)