Skip to content

Commit a24f4a9

Browse files
yfrancisgreghuels
yfrancis
authored and
greghuels
committed
Rename overridesStore to overrideStore
1 parent a9780be commit a24f4a9

File tree

4 files changed

+39
-39
lines changed

4 files changed

+39
-39
lines changed

‎src/client/eppo-client.spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ describe('EppoClient E2E test', () => {
958958
overrideStore = new MemoryOnlyConfigurationStore<Variation>();
959959
client = new EppoClient({
960960
flagConfigurationStore: storage,
961-
overridesStore: overrideStore,
961+
overrideStore: overrideStore,
962962
});
963963
client.setAssignmentLogger(mockLogger);
964964
client.useNonExpiringInMemoryAssignmentCache();
@@ -1143,7 +1143,7 @@ describe('EppoClient E2E test', () => {
11431143
},
11441144
});
11451145

1146-
client.unsetOverridesStore();
1146+
client.unsetOverrideStore();
11471147

11481148
const normalAssignment = client.getStringAssignment(flagKey, 'subject-10', {}, 'default');
11491149
expect(normalAssignment).toBe(variationA.value);

‎src/client/eppo-client.ts‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export default class EppoClient {
116116
private configurationRequestParameters?: FlagConfigurationRequestParameters;
117117
private banditModelConfigurationStore?: IConfigurationStore<BanditParameters>;
118118
private banditVariationConfigurationStore?: IConfigurationStore<BanditVariation[]>;
119-
private overridesStore?: ISyncStore<Variation>;
119+
private overrideStore?: ISyncStore<Variation>;
120120
private flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
121121
private assignmentLogger?: IAssignmentLogger;
122122
private assignmentCache?: AssignmentCache;
@@ -132,7 +132,7 @@ export default class EppoClient {
132132
flagConfigurationStore,
133133
banditVariationConfigurationStore,
134134
banditModelConfigurationStore,
135-
overridesStore,
135+
overrideStore,
136136
configurationRequestParameters,
137137
}: {
138138
// Dispatcher for arbitrary, application-level events (not to be confused with Eppo specific assignment
@@ -141,15 +141,15 @@ export default class EppoClient {
141141
flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>;
142142
banditVariationConfigurationStore?: IConfigurationStore<BanditVariation[]>;
143143
banditModelConfigurationStore?: IConfigurationStore<BanditParameters>;
144-
overridesStore?: ISyncStore<Variation>;
144+
overrideStore?: ISyncStore<Variation>;
145145
configurationRequestParameters?: FlagConfigurationRequestParameters;
146146
isObfuscated?: boolean;
147147
}) {
148148
this.eventDispatcher = eventDispatcher;
149149
this.flagConfigurationStore = flagConfigurationStore;
150150
this.banditVariationConfigurationStore = banditVariationConfigurationStore;
151151
this.banditModelConfigurationStore = banditModelConfigurationStore;
152-
this.overridesStore = overridesStore;
152+
this.overrideStore = overrideStore;
153153
this.configurationRequestParameters = configurationRequestParameters;
154154
this.isObfuscated = isObfuscated;
155155
}
@@ -205,18 +205,18 @@ export default class EppoClient {
205205
this.isObfuscated = isObfuscated;
206206
}
207207

208-
setOverridesStore(store: ISyncStore<Variation>): void {
209-
this.overridesStore = store;
208+
setOverrideStore(store: ISyncStore<Variation>): void {
209+
this.overrideStore = store;
210210
}
211211

212-
unsetOverridesStore(): void {
213-
this.overridesStore = undefined;
212+
unsetOverrideStore(): void {
213+
this.overrideStore = undefined;
214214
}
215215

216216
// Returns a mapping of flag key to variation key for all active overrides
217217
getOverrideVariationKeys(): Record<string, string> {
218218
return Object.fromEntries(
219-
Object.entries(this.overridesStore?.entries() ?? {}).map(([flagKey, value]) => [
219+
Object.entries(this.overrideStore?.entries() ?? {}).map(([flagKey, value]) => [
220220
flagKey,
221221
value.key,
222222
]),
@@ -971,7 +971,7 @@ export default class EppoClient {
971971
validateNotBlank(flagKey, 'Invalid argument: flagKey cannot be blank');
972972

973973
const flagEvaluationDetailsBuilder = this.newFlagEvaluationDetailsBuilder(flagKey);
974-
const overrideVariation = this.overridesStore?.get(flagKey);
974+
const overrideVariation = this.overrideStore?.get(flagKey);
975975
if (overrideVariation) {
976976
return overrideResult(
977977
flagKey,

‎src/client/eppo-precomputed-client.spec.ts‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,7 @@ describe('Precomputed Bandit Store', () => {
10321032
describe('flag overrides', () => {
10331033
let client: EppoPrecomputedClient;
10341034
let mockLogger: IAssignmentLogger;
1035-
let overridesStore: ISyncStore<Variation>;
1035+
let overrideStore: ISyncStore<Variation>;
10361036
let flagStorage: IConfigurationStore<PrecomputedFlag>;
10371037
let subject: Subject;
10381038

@@ -1053,7 +1053,7 @@ describe('flag overrides', () => {
10531053
flagStorage = new MemoryOnlyConfigurationStore();
10541054
flagStorage.setEntries({ [hashedPrecomputedFlagKey]: mockPrecomputedFlag });
10551055
mockLogger = td.object<IAssignmentLogger>();
1056-
overridesStore = new MemoryOnlyConfigurationStore<Variation>();
1056+
overrideStore = new MemoryOnlyConfigurationStore<Variation>();
10571057
subject = {
10581058
subjectKey: 'test-subject',
10591059
subjectAttributes: { attr1: 'value1' },
@@ -1062,13 +1062,13 @@ describe('flag overrides', () => {
10621062
client = new EppoPrecomputedClient({
10631063
precomputedFlagStore: flagStorage,
10641064
subject,
1065-
overridesStore,
1065+
overrideStore,
10661066
});
10671067
client.setAssignmentLogger(mockLogger);
10681068
});
10691069

10701070
it('returns override values for all supported types', () => {
1071-
overridesStore.setEntries({
1071+
overrideStore.setEntries({
10721072
'string-flag': {
10731073
key: 'override-variation',
10741074
value: 'override-string',
@@ -1094,7 +1094,7 @@ describe('flag overrides', () => {
10941094
});
10951095

10961096
it('does not log assignments when override is applied', () => {
1097-
overridesStore.setEntries({
1097+
overrideStore.setEntries({
10981098
[precomputedFlagKey]: {
10991099
key: 'override-variation',
11001100
value: 'override-value',
@@ -1108,7 +1108,7 @@ describe('flag overrides', () => {
11081108

11091109
it('uses normal assignment when no override exists for flag', () => {
11101110
// Set override for a different flag
1111-
overridesStore.setEntries({
1111+
overrideStore.setEntries({
11121112
'other-flag': {
11131113
key: 'override-variation',
11141114
value: 'override-value',
@@ -1144,7 +1144,7 @@ describe('flag overrides', () => {
11441144
expect(td.explain(mockLogger.logAssignment).callCount).toBe(1);
11451145

11461146
// Set override and make second call
1147-
overridesStore.setEntries({
1147+
overrideStore.setEntries({
11481148
[precomputedFlagKey]: {
11491149
key: 'override-variation',
11501150
value: 'override-value',
@@ -1159,7 +1159,7 @@ describe('flag overrides', () => {
11591159

11601160
it('reverts to normal assignment after removing override', () => {
11611161
// Set initial override
1162-
overridesStore.setEntries({
1162+
overrideStore.setEntries({
11631163
[precomputedFlagKey]: {
11641164
key: 'override-variation',
11651165
value: 'override-value',
@@ -1171,15 +1171,15 @@ describe('flag overrides', () => {
11711171
expect(td.explain(mockLogger.logAssignment).callCount).toBe(0);
11721172

11731173
// Remove override and make second call
1174-
overridesStore.setEntries({});
1174+
overrideStore.setEntries({});
11751175

11761176
const normalAssignment = client.getStringAssignment(precomputedFlagKey, 'default');
11771177
expect(normalAssignment).toBe('variation-a');
11781178
// Should log the normal assignment
11791179
expect(td.explain(mockLogger.logAssignment).callCount).toBe(1);
11801180
});
11811181

1182-
describe('setOverridesStore', () => {
1182+
describe('setOverrideStore', () => {
11831183
it('applies overrides after setting store', () => {
11841184
// Create client without overrides store
11851185
const clientWithoutOverrides = new EppoPrecomputedClient({
@@ -1197,13 +1197,13 @@ describe('flag overrides', () => {
11971197
expect(td.explain(mockLogger.logAssignment).callCount).toBe(1);
11981198

11991199
// Set overrides store with override
1200-
overridesStore.setEntries({
1200+
overrideStore.setEntries({
12011201
[precomputedFlagKey]: {
12021202
key: 'override-variation',
12031203
value: 'override-value',
12041204
},
12051205
});
1206-
clientWithoutOverrides.setOverridesStore(overridesStore);
1206+
clientWithoutOverrides.setOverrideStore(overrideStore);
12071207

12081208
// Call after setting override store
12091209
const overriddenAssignment = clientWithoutOverrides.getStringAssignment(
@@ -1217,7 +1217,7 @@ describe('flag overrides', () => {
12171217

12181218
it('reverts to normal assignment after unsetting store', () => {
12191219
// Set initial override
1220-
overridesStore.setEntries({
1220+
overrideStore.setEntries({
12211221
[precomputedFlagKey]: {
12221222
key: 'override-variation',
12231223
value: 'override-value',
@@ -1228,7 +1228,7 @@ describe('flag overrides', () => {
12281228
expect(td.explain(mockLogger.logAssignment).callCount).toBe(0);
12291229

12301230
// Unset overrides store
1231-
client.unsetOverridesStore();
1231+
client.unsetOverrideStore();
12321232

12331233
const normalAssignment = client.getStringAssignment(precomputedFlagKey, 'default');
12341234
expect(normalAssignment).toBe('variation-a');
@@ -1238,17 +1238,17 @@ describe('flag overrides', () => {
12381238

12391239
it('switches between different override stores', () => {
12401240
// Create a second override store
1241-
const secondOverridesStore = new MemoryOnlyConfigurationStore<Variation>();
1241+
const secondOverrideStore = new MemoryOnlyConfigurationStore<Variation>();
12421242

12431243
// Set up different overrides in each store
1244-
overridesStore.setEntries({
1244+
overrideStore.setEntries({
12451245
[precomputedFlagKey]: {
12461246
key: 'override-1',
12471247
value: 'value-1',
12481248
},
12491249
});
12501250

1251-
secondOverridesStore.setEntries({
1251+
secondOverrideStore.setEntries({
12521252
[precomputedFlagKey]: {
12531253
key: 'override-2',
12541254
value: 'value-2',
@@ -1261,13 +1261,13 @@ describe('flag overrides', () => {
12611261
expect(td.explain(mockLogger.logAssignment).callCount).toBe(0);
12621262

12631263
// Switch to second override store
1264-
client.setOverridesStore(secondOverridesStore);
1264+
client.setOverrideStore(secondOverrideStore);
12651265
const secondOverride = client.getStringAssignment(precomputedFlagKey, 'default');
12661266
expect(secondOverride).toBe('value-2');
12671267
expect(td.explain(mockLogger.logAssignment).callCount).toBe(0);
12681268

12691269
// Switch back to first override store
1270-
client.setOverridesStore(overridesStore);
1270+
client.setOverrideStore(overrideStore);
12711271
const backToFirst = client.getStringAssignment(precomputedFlagKey, 'default');
12721272
expect(backToFirst).toBe('value-1');
12731273
expect(td.explain(mockLogger.logAssignment).callCount).toBe(0);

‎src/client/eppo-precomputed-client.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export type PrecomputedFlagsRequestParameters = {
6161
interface EppoPrecomputedClientOptions {
6262
precomputedFlagStore: IConfigurationStore<PrecomputedFlag>;
6363
precomputedBanditStore?: IConfigurationStore<IObfuscatedPrecomputedBandit>;
64-
overridesStore?: ISyncStore<Variation>;
64+
overrideStore?: ISyncStore<Variation>;
6565
subject: Subject;
6666
banditActions?: Record<FlagKey, Record<string, ContextAttributes>>;
6767
requestParameters?: PrecomputedFlagsRequestParameters;
@@ -83,12 +83,12 @@ export default class EppoPrecomputedClient {
8383
private banditActions?: Record<FlagKey, Record<string, ContextAttributes>>;
8484
private precomputedFlagStore: IConfigurationStore<PrecomputedFlag>;
8585
private precomputedBanditStore?: IConfigurationStore<IObfuscatedPrecomputedBandit>;
86-
private overridesStore?: ISyncStore<Variation>;
86+
private overrideStore?: ISyncStore<Variation>;
8787

8888
public constructor(options: EppoPrecomputedClientOptions) {
8989
this.precomputedFlagStore = options.precomputedFlagStore;
9090
this.precomputedBanditStore = options.precomputedBanditStore;
91-
this.overridesStore = options.overridesStore;
91+
this.overrideStore = options.overrideStore;
9292

9393
const { subjectKey, subjectAttributes } = options.subject;
9494
this.subject = {
@@ -204,7 +204,7 @@ export default class EppoPrecomputedClient {
204204
): T {
205205
validateNotBlank(flagKey, 'Invalid argument: flagKey cannot be blank');
206206

207-
const overrideVariation = this.overridesStore?.get(flagKey);
207+
const overrideVariation = this.overrideStore?.get(flagKey);
208208
if (overrideVariation) {
209209
return valueTransformer(overrideVariation.value);
210210
}
@@ -526,11 +526,11 @@ export default class EppoPrecomputedClient {
526526
};
527527
}
528528

529-
public setOverridesStore(store: ISyncStore<Variation>): void {
530-
this.overridesStore = store;
529+
public setOverrideStore(store: ISyncStore<Variation>): void {
530+
this.overrideStore = store;
531531
}
532532

533-
public unsetOverridesStore(): void {
534-
this.overridesStore = undefined;
533+
public unsetOverrideStore(): void {
534+
this.overrideStore = undefined;
535535
}
536536
}

0 commit comments

Comments
 (0)