Skip to content

Commit ac8655e

Browse files
committed
merge clean
1 parent 467364b commit ac8655e

File tree

4 files changed

+25
-25
lines changed

4 files changed

+25
-25
lines changed

src/client/eppo-client-with-bandits.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
import * as base64 from 'js-base64';
22

33
import {
4-
readMockUFCResponse,
4+
BANDIT_TEST_DATA_DIR,
5+
BANDITS_WIRE_FILE,
6+
BanditTestCase,
57
MOCK_BANDIT_MODELS_RESPONSE_FILE,
68
MOCK_FLAGS_WITH_BANDITS_RESPONSE_FILE,
7-
testCasesByFileName,
8-
BanditTestCase,
9-
BANDIT_TEST_DATA_DIR,
109
readMockConfigurationWireResponse,
11-
BANDITS_WIRE_FILE,
10+
readMockUFCResponse,
11+
testCasesByFileName,
1212
} from '../../test/testHelpers';
1313
import ApiEndpoints from '../api-endpoints';
1414
import { IAssignmentEvent, IAssignmentLogger } from '../assignment-logger';
@@ -18,18 +18,18 @@ import ConfigurationRequestor from '../configuration-requestor';
1818
import { ConfigurationManager } from '../configuration-store/configuration-manager';
1919
import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
2020
import {
21+
ConfigurationWireV1,
2122
IConfigurationWire,
22-
IPrecomputedConfiguration,
2323
IObfuscatedPrecomputedConfigurationResponse,
24-
configurationFromString,
24+
IPrecomputedConfiguration,
2525
} from '../configuration-wire/configuration-wire-types';
2626
import { Evaluator, FlagEvaluation } from '../evaluator';
2727
import {
2828
AllocationEvaluationCode,
2929
IFlagEvaluationDetails,
3030
} from '../flag-evaluation-details-builder';
3131
import FetchHttpClient from '../http-client';
32-
import { BanditVariation, BanditParameters, Flag } from '../interfaces';
32+
import { BanditParameters, BanditVariation, Flag } from '../interfaces';
3333
import { attributeEncodeBase64 } from '../obfuscation';
3434
import { Attributes, BanditActions, ContextAttributes } from '../types';
3535

@@ -137,7 +137,7 @@ describe('EppoClient Bandits E2E test', () => {
137137
}
138138

139139
describe('bootstrapped client', () => {
140-
const banditFlagsConfig = configurationFromString(
140+
const banditFlagsConfig = ConfigurationWireV1.fromString(
141141
readMockConfigurationWireResponse(BANDITS_WIRE_FILE),
142142
);
143143

src/client/eppo-client.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { AssignmentCache } from '../cache/abstract-assignment-cache';
2121
import { IConfigurationStore } from '../configuration-store/configuration-store';
2222
import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
2323
import {
24-
configurationFromString,
24+
ConfigurationWireV1,
2525
IConfigurationWire,
2626
IObfuscatedPrecomputedConfigurationResponse,
2727
ObfuscatedPrecomputedConfigurationResponse,
@@ -356,10 +356,10 @@ describe('EppoClient E2E test', () => {
356356
const testCases = testCasesByFileName<IAssignmentTestCase>(ASSIGNMENT_TEST_DATA_DIR);
357357

358358
describe('boostrapped client', () => {
359-
const bootstrapFlagsConfig = configurationFromString(
359+
const bootstrapFlagsConfig = ConfigurationWireV1.fromString(
360360
readMockConfigurationWireResponse(FLAGS_WIRE_FILE),
361361
);
362-
const bootstrapFlagsObfuscatedConfig = configurationFromString(
362+
const bootstrapFlagsObfuscatedConfig = ConfigurationWireV1.fromString(
363363
readMockConfigurationWireResponse(OBFUSCATED_FLAGS_WIRE_FILE),
364364
);
365365

src/configuration-wire/configuration-wire-types.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,6 @@ import { ContextAttributes, FlagKey, HashedFlagKey } from '../types';
1111

1212
import { deflateJsonObject, inflateJsonObject, JsonString } from './json-util';
1313

14-
/**
15-
* Builds an `IConfigurationWire` instance from the payload string.
16-
* To generate the payload string, see `ConfigurationWireHelper.fetchBootstrapConfiguration`.
17-
*
18-
* @param payloadString
19-
*/
20-
export function configurationFromString(
21-
payloadString: string | JsonString<IConfigurationWire>,
22-
): IConfigurationWire {
23-
return inflateJsonObject(payloadString as JsonString<IConfigurationWire>);
24-
}
25-
2614
// Base interface for all configuration responses
2715
interface IBasePrecomputedConfigurationResponse {
2816
readonly format: FormatEnum.PRECOMPUTED;
@@ -203,6 +191,18 @@ export class ConfigurationWireV1 implements IConfigurationWire {
203191
readonly bandits?: IConfigResponse<IBanditParametersResponse>,
204192
) {}
205193

194+
/**
195+
* Builds an `IConfigurationWire` instance from the payload string.
196+
* To generate the payload string, see `ConfigurationWireHelper.fetchBootstrapConfiguration`.
197+
*
198+
* @param payloadString
199+
*/
200+
public static fromString(
201+
payloadString: string | JsonString<IConfigurationWire>,
202+
): IConfigurationWire {
203+
return inflateJsonObject(payloadString as JsonString<IConfigurationWire>);
204+
}
205+
206206
public static fromResponses(
207207
flagConfig: IUniversalFlagConfigResponse,
208208
banditConfig?: IBanditParametersResponse,

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ import EppoPrecomputedClient, {
2626
Subject,
2727
} from './client/eppo-precomputed-client';
2828
import FlagConfigRequestor from './configuration-requestor';
29+
import { ConfigurationStoreBundle } from './configuration-store/configuration-manager';
2930
import {
3031
IConfigurationStore,
3132
IAsyncStore,
3233
ISyncStore,
3334
} from './configuration-store/configuration-store';
3435
import { HybridConfigurationStore } from './configuration-store/hybrid.store';
35-
import { ConfigurationStoreBundle } from './configuration-store/i-configuration-manager';
3636
import { MemoryStore, MemoryOnlyConfigurationStore } from './configuration-store/memory.store';
3737
import { ConfigurationWireHelper } from './configuration-wire/configuration-wire-helper';
3838
import {

0 commit comments

Comments
 (0)