Skip to content

Commit daabd57

Browse files
authored
fix: bandit model version in tests (#130)
* Fix eppo client with bandits test * Fix configuration requestor test
1 parent e50d8fd commit daabd57

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/client/eppo-client-with-bandits.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ describe('EppoClient Bandits E2E test', () => {
163163
expect(banditEvent.action).toBe('adidas');
164164
expect(banditEvent.actionProbability).toBeCloseTo(0.099);
165165
expect(banditEvent.optimalityGap).toBe(7.1);
166-
expect(banditEvent.modelVersion).toBe('v123');
166+
expect(banditEvent.modelVersion).toBe('123');
167167
expect(banditEvent.subjectNumericAttributes).toStrictEqual({ age: 25 });
168168
expect(banditEvent.subjectCategoricalAttributes).toStrictEqual({
169169
country: 'USA',

src/configuration-requestor.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ describe('ConfigurationRequestor', () => {
141141
const bannerBandit = banditModelStore.get('banner_bandit');
142142
expect(bannerBandit?.banditKey).toBe('banner_bandit');
143143
expect(bannerBandit?.modelName).toBe('falcon');
144-
expect(bannerBandit?.modelVersion).toBe('v123');
144+
expect(bannerBandit?.modelVersion).toBe('123');
145145
const bannerModelData = bannerBandit?.modelData;
146146
expect(bannerModelData?.gamma).toBe(1);
147147
expect(bannerModelData?.defaultActionScore).toBe(0);

0 commit comments

Comments
 (0)