fix: Use js-base64 polyfill instead of Buffer for browser env (#159)

* fix: Use base64 polyfill instead of Buffer

* version bump

Author: felipecsl

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eppo/js-client-sdk-common",
-  "version": "4.5.3",
+  "version": "4.5.4",
   "description": "Eppo SDK for client-side JavaScript applications (base for both web and react native)",
   "main": "dist/index.js",
   "files": [

src/events/sdk-key-decoder.spec.ts

@@ -1,16 +1,23 @@
 import SdkKeyDecoder from './sdk-key-decoder';
 
 describe('SdkKeyDecoder', () => {
+  const decoder = new SdkKeyDecoder();
   it('should decode the event ingestion hostname from the SDK key', () => {
-    const decoder = new SdkKeyDecoder();
     const hostname = decoder.decodeEventIngestionHostName(
       'zCsQuoHJxVPp895.ZWg9MTIzNDU2LmUudGVzdGluZy5lcHBvLmNsb3Vk',
     );
     expect(hostname).toEqual('123456.e.testing.eppo.cloud');
   });
 
+  it('should decode strings with non URL-safe characters', () => {
+    // this is not a really valid ingestion URL, but it's useful for testing the decoder
+    const invalidUrl = 'eh=12+3456/.e.testing.eppo.cloud';
+    const encoded = Buffer.from(invalidUrl).toString('base64url');
+    const hostname = decoder.decodeEventIngestionHostName(`zCsQuoHJxVPp895.${encoded}`);
+    expect(hostname).toEqual('12 3456/.e.testing.eppo.cloud');
+  });
+
   it("should return null if the SDK key doesn't contain the event ingestion hostname", () => {
-    const decoder = new SdkKeyDecoder();
     expect(decoder.decodeEventIngestionHostName('zCsQuoHJxVPp895')).toBeNull();
     expect(decoder.decodeEventIngestionHostName('zCsQuoHJxVPp895.xxxxxx')).toBeNull();
   });

src/events/sdk-key-decoder.ts

@@ -1,3 +1,5 @@
+import { Base64 } from 'js-base64';
+
 export default class SdkKeyDecoder {
   /**
    * Decodes and returns the event ingestion hostname from the provided Eppo SDK key string.
@@ -7,7 +9,7 @@ export default class SdkKeyDecoder {
     const encodedPayload = sdkKey.split('.')[1];
     if (!encodedPayload) return null;
 
-    const decodedPayload = Buffer.from(encodedPayload, 'base64url').toString('utf-8');
+    const decodedPayload = Base64.decode(encodedPayload);
     const params = new URLSearchParams(decodedPayload);
     return params.get('eh');
   }