Skip to content

Commit e4d1d26

Browse files
fixed older unit tests
1 parent 90429c1 commit e4d1d26

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

src/client/eppo-client-with-bandits.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ describe('EppoClient Bandits E2E test', () => {
163163
expect(banditEvent.action).toBe('adidas');
164164
expect(banditEvent.actionProbability).toBeCloseTo(0.099);
165165
expect(banditEvent.optimalityGap).toBe(7.1);
166-
expect(banditEvent.modelVersion).toBe('v123');
166+
expect(banditEvent.modelVersion).toBe('123');
167167
expect(banditEvent.subjectNumericAttributes).toStrictEqual({ age: 25 });
168168
expect(banditEvent.subjectCategoricalAttributes).toStrictEqual({
169169
country: 'USA',

src/client/eppo-client.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { IAssignmentEvent, IAssignmentLogger } from '../assignment-logger';
44
import { BanditEvaluator } from '../bandit-evaluator';
55
import { IBanditEvent, IBanditLogger } from '../bandit-logger';
66
import { AssignmentCache } from '../cache/abstract-assignment-cache';
7+
import { ExpiringLRUInMemoryAssignmentCache } from '../cache/expiring-lru-in-memory-assignment-cache';
78
import { LRUInMemoryAssignmentCache } from '../cache/lru-in-memory-assignment-cache';
89
import { NonExpiringInMemoryAssignmentCache } from '../cache/non-expiring-in-memory-cache-assignment';
910
import ConfigurationRequestor from '../configuration-requestor';
@@ -985,6 +986,14 @@ export default class EppoClient {
985986
this.banditAssignmentCache = new LRUInMemoryAssignmentCache(maxSize);
986987
}
987988

989+
/**
990+
* @param {number} maxSize - Maximum cache size
991+
* @param {number} timeout - TTL of cache entries
992+
*/
993+
public useExpiringInMemoryBanditAssignmentCache(maxSize: number, timeout?: number) {
994+
this.banditAssignmentCache = new ExpiringLRUInMemoryAssignmentCache(maxSize, timeout);
995+
}
996+
988997
public useCustomBanditAssignmentCache(cache: AssignmentCache) {
989998
this.banditAssignmentCache = cache;
990999
}

src/configuration-requestor.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ describe('ConfigurationRequestor', () => {
141141
const bannerBandit = banditModelStore.get('banner_bandit');
142142
expect(bannerBandit?.banditKey).toBe('banner_bandit');
143143
expect(bannerBandit?.modelName).toBe('falcon');
144-
expect(bannerBandit?.modelVersion).toBe('v123');
144+
expect(bannerBandit?.modelVersion).toBe('123');
145145
const bannerModelData = bannerBandit?.modelData;
146146
expect(bannerModelData?.gamma).toBe(1);
147147
expect(bannerModelData?.defaultActionScore).toBe(0);

0 commit comments

Comments
 (0)