Skip to content

Commit f1db0f1

Browse files
committed
lint and revert setStore changes
1 parent a404826 commit f1db0f1

File tree

2 files changed

+2
-21
lines changed

2 files changed

+2
-21
lines changed

src/client/eppo-client.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,6 @@ describe('EppoClient E2E test', () => {
321321
});
322322
});
323323

324-
const testCases = testCasesByFileName<IAssignmentTestCase>(ASSIGNMENT_TEST_DATA_DIR);
325-
326324
function testCasesAgainstClient(client: EppoClient, testCase: IAssignmentTestCase) {
327325
const { flag, variationType, defaultValue, subjects } = testCase;
328326

src/client/eppo-client.ts

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ import { TLRUInMemoryAssignmentCache } from '../cache/tlru-in-memory-assignment-
1717
import ConfigurationRequestor from '../configuration-requestor';
1818
import { ConfigurationManager } from '../configuration-store/configuration-manager';
1919
import { IConfigurationStore, ISyncStore } from '../configuration-store/configuration-store';
20-
import {
21-
ConfigurationStoreBundle,
22-
IConfigurationManager,
23-
} from '../configuration-store/i-configuration-manager';
20+
import { IConfigurationManager } from '../configuration-store/i-configuration-manager';
2421
import { MemoryOnlyConfigurationStore } from '../configuration-store/memory.store';
2522
import {
2623
ConfigurationWireV1,
@@ -249,15 +246,7 @@ export default class EppoClient {
249246
this.configurationRequestParameters = configurationRequestParameters;
250247
}
251248

252-
public setConfigurationStores(configStores: ConfigurationStoreBundle) {
253-
// Update the configuration manager
254-
this.configurationManager.setConfigurationStores(configStores);
255-
}
256-
257249
// noinspection JSUnusedGlobalSymbols
258-
/**
259-
* @deprecated use `setConfigurationStores` instead
260-
*/
261250
setFlagConfigurationStore(flagConfigurationStore: IConfigurationStore<Flag | ObfuscatedFlag>) {
262251
this.flagConfigurationStore = flagConfigurationStore;
263252
this.configObfuscatedCache = undefined;
@@ -267,9 +256,6 @@ export default class EppoClient {
267256
}
268257

269258
// noinspection JSUnusedGlobalSymbols
270-
/**
271-
* @deprecated use `setConfigurationStores` instead
272-
*/
273259
setBanditVariationConfigurationStore(
274260
banditVariationConfigurationStore: IConfigurationStore<BanditVariation[]>,
275261
) {
@@ -280,9 +266,6 @@ export default class EppoClient {
280266
}
281267

282268
// noinspection JSUnusedGlobalSymbols
283-
/**
284-
* @deprecated use `setConfigurationStores` instead
285-
*/
286269
setBanditModelConfigurationStore(
287270
banditModelConfigurationStore: IConfigurationStore<BanditParameters>,
288271
) {
@@ -294,7 +277,7 @@ export default class EppoClient {
294277

295278
private innerSetConfigurationStores() {
296279
// Set the set of configuration stores to those owned by the `this`.
297-
this.setConfigurationStores({
280+
this.configurationManager.setConfigurationStores({
298281
flagConfigurationStore: this.flagConfigurationStore,
299282
banditReferenceConfigurationStore: this.banditVariationConfigurationStore,
300283
banditConfigurationStore: this.banditModelConfigurationStore,

0 commit comments

Comments
 (0)