From 7723403a7b14d8746a4513fa4190c17eb658fad9 Mon Sep 17 00:00:00 2001 From: Sameeran Kunche Date: Mon, 18 Nov 2024 10:17:47 -0800 Subject: [PATCH 1/2] Fix eppo client with bandits test --- src/client/eppo-client-with-bandits.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/eppo-client-with-bandits.spec.ts b/src/client/eppo-client-with-bandits.spec.ts index 0610a90..9a8ccc8 100644 --- a/src/client/eppo-client-with-bandits.spec.ts +++ b/src/client/eppo-client-with-bandits.spec.ts @@ -163,7 +163,7 @@ describe('EppoClient Bandits E2E test', () => { expect(banditEvent.action).toBe('adidas'); expect(banditEvent.actionProbability).toBeCloseTo(0.099); expect(banditEvent.optimalityGap).toBe(7.1); - expect(banditEvent.modelVersion).toBe('v123'); + expect(banditEvent.modelVersion).toBe('123'); expect(banditEvent.subjectNumericAttributes).toStrictEqual({ age: 25 }); expect(banditEvent.subjectCategoricalAttributes).toStrictEqual({ country: 'USA', From e28bbd2f54041c29d73cc0a97c90ba8c4261f8d6 Mon Sep 17 00:00:00 2001 From: Sameeran Kunche Date: Mon, 18 Nov 2024 10:19:48 -0800 Subject: [PATCH 2/2] Fix configuration requestor test --- src/configuration-requestor.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/configuration-requestor.spec.ts b/src/configuration-requestor.spec.ts index 746bb0f..b3bb05f 100644 --- a/src/configuration-requestor.spec.ts +++ b/src/configuration-requestor.spec.ts @@ -141,7 +141,7 @@ describe('ConfigurationRequestor', () => { const bannerBandit = banditModelStore.get('banner_bandit'); expect(bannerBandit?.banditKey).toBe('banner_bandit'); expect(bannerBandit?.modelName).toBe('falcon'); - expect(bannerBandit?.modelVersion).toBe('v123'); + expect(bannerBandit?.modelVersion).toBe('123'); const bannerModelData = bannerBandit?.modelData; expect(bannerModelData?.gamma).toBe(1); expect(bannerModelData?.defaultActionScore).toBe(0);