fix: server overrides key validation should be serverd from https://eppo.cloud #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
approved these changes
Mar 5, 2025
| import { FlagKey } from './types'; | ||
|
|
||
| const FIVE_MINUTES_IN_MS = 5 * 3600 * 1000; | ||
| const KEY_VALIDATION_URL = 'https://eppo.cloud/api/flag-overrides/v1/validate-key'; |
There was a problem hiding this comment.
FLAG_OVERRIDES_KEY_VALIDATION_URL is still in src/constants.ts and now unused anywhere in the code.
Would suggest either deleting it in src/constants.ts, or replacing it with this
There was a problem hiding this comment.
Good catch -- will do!
greghuels
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for FF-4046
Key validation should always be pointed to https://eppo.coud as there is no fscdn equivalent.