feat: use encoded subdomain for endpoints #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
approved these changes
Mar 28, 2025
petzel
approved these changes
Mar 28, 2025
leoromanovsky
approved these changes
Mar 28, 2025
This was referenced Mar 28, 2025
typotter
added a commit
that referenced
this pull request
Apr 22, 2025
* move event URL into api endpoints * Expand, move, and rename SdkKeyDecoder to produce customer subdomain * v4.15.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FF-4143
📜 Design Doc
👯♀️ PR/12588
Motivation and Context
In order to support off-boarding of customers, we have created an architecture where requests to the CDN, Edge Compute, and Event Ingestion are all routed through customer-specific subdomains (which can be blocked when customers off-board.
Description
SdkKeyDecoderand relocated itApiEndpointsto inject subdomains and build event URLsbaseURLparam can NO LONGER equal the default URLHow has this been tested?