chore: upgrade to [email protected] #112
Conversation
| }, | ||
| "homepage": "https://github.com/Eppo-exp/node-server-sdk#readme", | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "^4.15.1" |
There was a problem hiding this comment.
I'm recalling that we had decided in the past to avoid using loose semver notations (~ and ^) because we run the risk that if we release a change in common that is incompatible with one of the SDKs, that it might automatically get picked up and cause issues?
There was a problem hiding this comment.
Yes good catch this is safer
| "resolutions": { | ||
| "minimatch": "^3.1.2" | ||
| } |
There was a problem hiding this comment.
I was running into this error:
Run yarn --frozen-lockfile
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.8"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
I.e. dependencies were resolving to a version of minimatch that is not compatible with node 18. I believe this will maintain compatibility with the old node version
There was a problem hiding this comment.
Interesting. Thanks for addressing
| }, | ||
| "homepage": "https://github.com/Eppo-exp/node-server-sdk#readme", | ||
| "dependencies": { | ||
| "@eppo/js-client-sdk-common": "^4.15.1" |
There was a problem hiding this comment.
Yes good catch this is safer
| "resolutions": { | ||
| "minimatch": "^3.1.2" | ||
| } |
There was a problem hiding this comment.
Interesting. Thanks for addressing
| version "2.2.1" | ||
| resolved "https://registry.yarnpkg.com/@ampproject/remapping/-/remapping-2.2.1.tgz#99e8e11851128b8702cd57c33684f1d0f260b630" | ||
| integrity sha512-lFMjJTrFL3j7L9yBxwYfCq2k6qqwHyzuUl/XBnif78PWTJYyL/dfowQHWE3sp6U6ZzqWiiIZnpTMO96zhkjwtg== | ||
| version "2.3.0" |
There was a problem hiding this comment.
Lots of yarn changes were these dependabot upgrades or from running yarn with a different node version?
There was a problem hiding this comment.
Still lots of yarn.lock changes, even though my local environment is the following:
% node --version
v18.20.8
% yarn --version
1.22.22
There have been a lot of changes to the underlying dependencies though. The latest common release includes quite a few deps-dev version bumps
https://github.com/Eppo-exp/js-sdk-common/releases/tag/v4.15.2
My hunch is that some of these bumps probably resolve to versions of minimatch and @types/node that are incompatible with node 18, hence the need to add the resolutions fields to the package.json to get yarn install to still work
| | Package | Description | | ||
| | --- | --- | | ||
| | [@eppo/node-server-sdk](./node-server-sdk.md) | | | ||
| <table><thead><tr><th> |
There was a problem hiding this comment.
Big regeneration of docs guessing the auto doc package updated?
There was a problem hiding this comment.
You can see that it jumped a few patch versions
Lines 628 to 667 in b96a888
And the dependencies (like typescript and minimatch) eventually trace their way back to the dependabot bumped versions in the latest common release https://github.com/Eppo-exp/js-sdk-common/releases/tag/v4.15.2
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
To incorporate the changes from Eppo-exp/js-sdk-common#292
Description
How has this been documented?
How has this been tested?