Handle exceptions in polling task (#14)

* Don't stop polling when there is an exception

* fix log message

* fix linter error

Author: ploomiz

eppo_client/__init__.py

@@ -10,7 +10,7 @@
 from eppo_client.http_client import HttpClient, SdkParams
 from eppo_client.read_write_lock import ReadWriteLock
 
-__version__ = "1.1.0"
+__version__ = "1.1.1"
 
 __client: Optional[EppoClient] = None
 __lock = ReadWriteLock()

eppo_client/configuration_requestor.py

@@ -2,7 +2,7 @@
 from typing import Any, Dict, List, Optional, cast
 from eppo_client.base_model import SdkBaseModel
 from eppo_client.configuration_store import ConfigurationStore
-from eppo_client.http_client import HttpClient, HttpRequestError
+from eppo_client.http_client import HttpClient
 from eppo_client.rules import Rule
 
 from eppo_client.shard import ShardRange
@@ -56,9 +56,6 @@ def fetch_and_store_configurations(self) -> Dict[str, ExperimentConfigurationDto
                 configs[exp_key] = ExperimentConfigurationDto(**exp_config)
             self.__config_store.set_configurations(configs)
             return configs
-        except HttpRequestError as e:
+        except Exception as e:
             logger.error("Error retrieving assignment configurations: " + str(e))
-            if e.is_recoverable():
-                return {}
-            else:
-                raise e  # caught by the polling task; causes assignment polling to stop
+            return {}

eppo_client/http_client.py

@@ -20,14 +20,6 @@ def __init__(self, message: str, status_code: int):
         self.status_code = status_code
         super().__init__(message)
 
-    def is_recoverable(self) -> bool:
-        if self.status_code >= 400 and self.status_code < 500:
-            return (
-                self.status_code == HTTPStatus.TOO_MANY_REQUESTS
-                or self.status_code == HTTPStatus.REQUEST_TIMEOUT
-            )
-        return True
-
 
 REQUEST_TIMEOUT_SECONDS = 2
 # Retry reference: https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#module-urllib3.util.retry