FF-2139 Fixes "Property 'atob' doesn't exist" errors in RN 0.72 (#48)

* Fixes "Property 'atob' doesn't exist" errors in RN 0.72

* fix types

Author: greghuels

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@eppo/react-native-sdk",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Eppo React Native SDK",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
@@ -51,7 +51,7 @@
     "registry": "https://registry.npmjs.org/"
   },
   "dependencies": {
-    "@eppo/js-client-sdk-common": "3.0.2",
+    "@eppo/js-client-sdk-common": "3.2.0",
     "@react-native-async-storage/async-storage": "^1.18.0",
     "md5": "^2.3.0"
   },
@@ -147,4 +147,4 @@
       ]
     ]
   }
-}
+}

src/async-storage.spec.ts

@@ -1,5 +1,7 @@
+import type { Flag, VariationType } from '@eppo/js-client-sdk-common';
 import { EppoAsyncStorage, STORAGE_KEY } from './async-storage';
 import AsyncStorage from '@react-native-async-storage/async-storage';
+import type { Variation } from '@eppo/js-client-sdk-common/dist/interfaces';
 
 describe('EppoAsyncStorage', () => {
   let storage: EppoAsyncStorage;
@@ -10,26 +12,49 @@ describe('EppoAsyncStorage', () => {
     AsyncStorage.getItem = jest.fn();
   });
 
+  const buildFlag = (key: string, variationValues: string[]): Flag => {
+    const variations: Record<string, Variation> = {};
+    variationValues.forEach((variationValue) => {
+      variations[variationValue] = {
+        key: variationValue,
+        value: variationValue,
+      };
+    });
+    return {
+      key,
+      enabled: true,
+      variationType: 'STRING' as VariationType,
+      variations,
+      allocations: [],
+      totalShards: 1,
+    };
+  };
+
   describe('setEntries', () => {
     it('should set entries and update AsyncStorage', async () => {
       expect(storage.isInitialized()).toBe(false);
 
-      const entries = { key1: 'newvalue1', key2: 'newvalue2' };
+      const flag1 = buildFlag('flag-key1', ['control-1', 'experiment-1']);
+      const flag2 = buildFlag('flag-key2', ['control-2', 'experiment-2']);
+      const entries = { key1: flag1, key2: flag2 };
       await storage.setEntries(entries);
 
       expect(AsyncStorage.setItem).toHaveBeenCalledWith(
         STORAGE_KEY,
         JSON.stringify(entries)
       );
-      expect(storage.get('key1')).toBe('newvalue1');
-      expect(storage.get('key2')).toBe('newvalue2');
+      expect(storage.get('key1')).toEqual(flag1);
+      expect(storage.get('key2')).toEqual(flag2);
       expect(storage.isInitialized()).toBe(true);
     });
   });
 
   describe('getKeys', () => {
     it('should return all keys in the cache', async () => {
-      const entries = { key1: 'value1', key2: 'value2', key3: 'value3' };
+      const flag1 = buildFlag('flag-key1', ['control-1', 'experiment-1']);
+      const flag2 = buildFlag('flag-key2', ['control-2', 'experiment-2']);
+      const flag3 = buildFlag('flag-key3', ['control-3', 'experiment-3']);
+      const entries = { key1: flag1, key2: flag2, key3: flag3 };
       await storage.setEntries(entries);
 
       const keys = storage.getKeys();

src/async-storage.ts

@@ -1,10 +1,18 @@
-import type { IConfigurationStore } from '@eppo/js-client-sdk-common';
+import type {
+  IAsyncStore,
+  IConfigurationStore,
+  ISyncStore,
+} from '@eppo/js-client-sdk-common';
+import type {
+  Flag,
+  ObfuscatedFlag,
+} from '@eppo/js-client-sdk-common/dist/interfaces';
 import AsyncStorage from '@react-native-async-storage/async-storage';
 
 // Bump this version number when we make breaking changes to the cache.
 export const STORAGE_KEY = '@eppo/sdk-cache-ufc';
 
-export class EppoAsyncStorage implements IConfigurationStore {
+class AsyncStorageStore<T> implements ISyncStore<T> {
   private cache: { [key: string]: any } = {};
   private _isInitialized = false;
 
@@ -27,7 +35,7 @@ export class EppoAsyncStorage implements IConfigurationStore {
     return Object.keys(this.cache);
   }
 
-  public setEntries<T>(entries: Record<string, T>): void {
+  public setEntries(entries: Record<string, T>): void {
     for (var key in entries) {
       this.cache[key] = entries[key];
     }
@@ -36,3 +44,45 @@ export class EppoAsyncStorage implements IConfigurationStore {
     this._isInitialized = true;
   }
 }
+
+export class EppoAsyncStorage
+  implements IConfigurationStore<Flag | ObfuscatedFlag>
+{
+  servingStore: ISyncStore<Flag | ObfuscatedFlag>;
+  persistentStore: IAsyncStore<Flag | ObfuscatedFlag> | null;
+  private initialized: boolean;
+
+  constructor() {
+    this.servingStore = new AsyncStorageStore<Flag | ObfuscatedFlag>();
+    this.persistentStore = null;
+    this.initialized = false;
+  }
+
+  init(): Promise<void> {
+    this.initialized = true;
+    return Promise.resolve();
+  }
+
+  get(key: string): Flag | ObfuscatedFlag | null {
+    return this.servingStore.get(key);
+  }
+
+  getKeys(): string[] {
+    return this.servingStore.getKeys();
+  }
+
+  async isExpired(): Promise<boolean> {
+    return true;
+  }
+
+  isInitialized(): boolean {
+    return this.initialized;
+  }
+
+  async setEntries(
+    entries: Record<string, Flag | ObfuscatedFlag>
+  ): Promise<void> {
+    this.servingStore.setEntries(entries);
+    this.initialized = true;
+  }
+}

yarn.lock

@@ -1213,15 +1213,15 @@
   resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
   integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==
 
-"@eppo/js-client-sdk-common@3.0.2":
-  version "3.0.2"
-  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-3.0.2.tgz#c1929fcad1b67676657d721cdc37561da108565d"
-  integrity sha512-Px7ppXMiWSNYYBRWORLcPSnOSreZASYzvn58CD1ZmKXDIruEOMD/39OUttDHex+tIj26f/BsVZNJzkR4zaD4Lg==
+"@eppo/js-client-sdk-common@3.2.0":
+  version "3.2.0"
+  resolved "https://registry.yarnpkg.com/@eppo/js-client-sdk-common/-/js-client-sdk-common-3.2.0.tgz#e96895e3c74471f41892feb31d56c67f36c1b3e6"
+  integrity sha512-ua+4Mez7Ti/4XDPSKWbR8gg611UN9XnvModWAE7sjrHP60QNfmhvW6m+jXepDgQFRsybU0xXrddZQiVbDcCrUQ==
   dependencies:
+    js-base64 "^3.7.7"
     md5 "^2.3.0"
     pino "^8.19.0"
     semver "^7.5.4"
-    universal-base64 "^2.1.0"
 
 "@eslint-community/eslint-utils@^4.2.0":
   version "4.4.0"
@@ -5526,6 +5526,11 @@ joi@^17.2.1:
     "@sideway/formula" "^3.0.1"
     "@sideway/pinpoint" "^2.0.0"
 
+js-base64@^3.7.7:
+  version "3.7.7"
+  resolved "https://registry.yarnpkg.com/js-base64/-/js-base64-3.7.7.tgz#e51b84bf78fbf5702b9541e2cb7bfcb893b43e79"
+  integrity sha512-7rCnleh0z2CkXhH67J8K1Ytz0b2Y+yxTPL+/KOJoa20hfnVQ/3/T6W/KflYI4bRHRagNeXeU2bkNGI3v1oS/lw==
+
 js-sdsl@^4.1.4:
   version "4.4.0"
   resolved "https://registry.npmjs.org/js-sdsl/-/js-sdsl-4.4.0.tgz"
@@ -8256,11 +8261,6 @@ union-value@^1.0.0:
     is-extendable "^0.1.1"
     set-value "^2.0.1"
 
-universal-base64@^2.1.0:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/universal-base64/-/universal-base64-2.1.0.tgz#511af92b3a07340fc2647036045aadb3bedcc320"
-  integrity sha512-WeOkACVnIXJZr/qlv7++Rl1zuZOHN96v2yS5oleUuv8eJOs5j9M5U3xQEIoWqn1OzIuIcgw0fswxWnUVGDfW6g==
-
 universalify@^0.1.0:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.2.tgz#b646f69be3942dabcecc9d6639c80dc105efaa66"