chore: v4 - android21 compatible mega PR #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
Apr 25, 2025
| private final CallbackManager<Configuration, Configuration.ConfigurationCallback> | ||
| configChangeManager = | ||
| new CallbackManager<>( | ||
| // no lambdas before java8 |
There was a problem hiding this comment.
Are they android 21 compatible through its "desugaring"? Would that be ok to support or, do we need stay away from that entirely?
There was a problem hiding this comment.
The handy thing is that for the dev, if they're using a platform that supports lambdas, they can use a lambda when they register a callback (this is in EppoClient). Since the callback interface there is a once function interface, Java will treat it interchangeably with a lambda whose signature matches the function.
Simplified callback interface Renamed methods to match "gen2" sdk naming Added activateConfiguration method expose isGracefulMode to subclasses moved graceful mode check top-level callsites (in poller and in assignment calls) renamed callbacks clarified init in tests
typotter
changed the title
* chore: replace use of string.join for android 21 (#111) * extract base64 codec for portation
* chore: refactor out JSON parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eppo Internal:
🎟️ Fixes FF-4351
Motivation and Context
In order to support Android API level 21, we need to remove some of the more modern features previously integrated. One such construct is the
CompletableFuture, java's version of thePromise. In order to be compatible all the way back to java6, we need to replace these async structures with Callbacks for better or worse (and we can't even use lambdas)Description
CallbackManagerclass to use a dispatcher that gets around using different callback structures with a callback manager (needed only because we can't use lambdas)CompletableFutures, plumb callbacks everywhere for asyncBreaking Changes
protected void loadConfigurationAsync(EppoActionCallback<Configuration> callback)public void saveConfiguration(@NotNull final Configuration configuration)apiKeytosdkKeyexpectObfuscatedparameterhostparameterNew API
activateConfigurationHow has this been documented?
How has this been tested?