Add test cases for the new file logic

Its absolutely unhinged, woo!

Author: Epse

BeluxPlugin/SidAllocation.cpp

@@ -267,8 +267,8 @@ bool SidAllocation::does_activation_match(const std::optional<TimeActivation>& r
 	}
 
 	const auto zoned_now = chrono::zoned_time{ dest_zone, now };
-	const auto ymw = chrono::year_month_weekday{ chrono::floor<chrono::days>(zoned_now.get_sys_time()) };
-	const auto time = chrono::hh_mm_ss(zoned_now.get_sys_time() - chrono::floor<chrono::days>(zoned_now.get_sys_time()));
+	const auto ymw = chrono::year_month_weekday{ chrono::floor<chrono::days>(zoned_now.get_local_time()) };
+	const auto time = chrono::hh_mm_ss(zoned_now.get_local_time() - chrono::floor<chrono::days>(zoned_now.get_local_time()));
 	const auto hours = time.hours().count();
 	const auto minutes = time.minutes().count();
 

BeluxPluginTest/BeluxPluginTest.cpp

@@ -5,6 +5,7 @@
 #include <string>
 #include <chrono>
 
+
 using namespace std::chrono;
 
 using namespace Microsoft::VisualStudio::CppUnitTestFramework;
@@ -166,12 +167,60 @@ namespace BeluxPluginTest
 			Assert::AreEqual(std::string("LNO7E"), maybe_sid->sid);
 		}
 
-		TEST_METHOD(RespectsTiemZones)
+		TEST_METHOD(RespectsTimeZonesPositive)
 		{
+			// DENUT7N gets assigned for RWY19, if between 2345 and 0344L, or 25R is not active.
+			// We will test with 25R active of course
+
+			const auto allocator = get_filled_allocator();
+
+			// This is local. October 1st is winter time, so at 01:05L it should be active. This is 2305Z, so not active if incorrectly converted.
+			tm fake_now{};
+			fake_now.tm_mday = 2;
+			fake_now.tm_mon = 9; // October, somehow
+			fake_now.tm_year = 2023 - 1900;
+			fake_now.tm_hour = 1;
+			fake_now.tm_min = 5;
+			fake_now.tm_isdst = -1;
+			const time_t epoch = mktime(&fake_now);
+			Assert::IsTrue(epoch > 0);
+			const auto clock = system_clock::from_time_t(epoch);
+
+			const LaraParser parser = get_filled_lara();
+			const auto active = parser.get_active(fake_now);
+
+			const auto maybe_sid = allocator.find("EBBR", "DENUT", "EDDF", 2, "19", clock, active, std::vector<std::string>{"25R"});
+			Assert::IsTrue(maybe_sid.has_value());
+			Assert::AreEqual(std::string("DENUT7N"), maybe_sid->sid);
 		}
 
-		TEST_METHOD(RespectsDisallowedRunways)
+		TEST_METHOD(RespectsTimeZonesNegative)
 		{
+			// DENUT7N gets assigned for RWY19, if between 2345 and 0344L, or 25R is not active.
+			// We will test with 25R active of course
+			// This also tests that it respects the 25R being disallowed, otherwise we'd get that
+			// Instead we select DENUT1F, which is F-ictional
+
+			const auto allocator = get_filled_allocator();
+
+			// This is local. October 1st is winter time, so at 03:50L it should not be active. This is 0150Z, so active if incorrectly converted.
+			tm fake_now{};
+			fake_now.tm_mday = 2;
+			fake_now.tm_mon = 9; // October, somehow
+			fake_now.tm_year = 2023 - 1900;
+			fake_now.tm_hour = 3;
+			fake_now.tm_min = 50;
+			fake_now.tm_isdst = -1;
+			const time_t epoch = mktime(&fake_now);
+			Assert::IsTrue(epoch > 0);
+			const auto clock = system_clock::from_time_t(epoch);
+
+			const LaraParser parser = get_filled_lara();
+			const auto active = parser.get_active(fake_now);
+
+			const auto maybe_sid = allocator.find("EBBR", "DENUT", "EDDF", 2, "19", clock, active, std::vector<std::string>{"25R"});
+			Assert::IsTrue(maybe_sid.has_value());
+			Assert::AreNotEqual(std::string("DENUT7N"), maybe_sid->sid);
 		}
 	};
 }

BeluxPluginTest/res/SID_ALLOCATION.txt

@@ -41,6 +41,7 @@ CIV  |   |1|               |               |CIV2L  | EBBR | 19  | F060 |       |
 DENUT|   |1|    0345       |     2044      |DENUT8L| EBBR | 19  | F060 |       |        | | 19
 DENUT|   |1|    2245L      |     0344L     |DENUT7N| EBBR | 19  | F060 |       |        | | 19
 DENUT|   |1|               |               |DENUT7N| EBBR | 19  | F060 |       |        | 25R | 19
+DENUT|   |1|               |               |DENUT1F| EBBR | 19  | F060 |       |        | | FICTIONAL
 ELSIK|   |1|               |               |ELSIK2L| EBBR | 19  | F060 |       | EBTRANA EBTRANB | | 19
 HELEN|   |1|    0345       |     2044      |HELEN6L| EBBR | 19  | F060 |       |        | | 19
 HELEN|   |1|    2045       |     0344      |HELEN6N| EBBR | 19  | F060 |       |        | | 19