Merge pull request #18 from ErickOF/dev

Adding quality checks

Author: ErickOF

.github/workflows/cpp.yml

@@ -0,0 +1,27 @@
+name: C/C++ CI
+
+on:
+  push:
+    branches:
+    - main
+    - dev
+  pull_request:
+    branches: 
+    - main
+    - dev
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+    - name: install dependencies
+      run: sudo apt-get install -y libopencv-dev
+    - name: compile compression
+      working-directory: ./modules/compression
+      run: make IPS_JPG_AT_EN=1 INCLUDE_OPENCV_PKG=1
+    - name: compile edge detector
+      working-directory: ./modules/edge-detector
+      run: make EDGE_DETECTOR_AT_EN=1 INCLUDE_OPENCV_PKG=1

.gitignore

@@ -220,11 +220,11 @@ pyrightconfig.json
 # End of https://www.toptal.com/developers/gitignore/api/c++,python,jupyternotebooks
 
 # Ignore generate images from datagen tool
-modules/unification/*.bitmap
-modules/unification/*.gif
-modules/unification/*.jpeg
-modules/unification/*.jpg
-modules/unification/*.png
+modules/*/*.bitmap
+modules/*/*.gif
+modules/*/*.jpeg
+modules/*/*.jpg
+modules/*/*.png
 tools/datagen/src/imgs/*_grayscale_image*
 tools/datagen/src/imgs/*_noisy_image*
 tools/datagen/src/imgs/*_sobel_*

modules/compression/Makefile

@@ -22,4 +22,4 @@ run:
 
 # Show waveform
 waveform:
-	@gtkwave input_matrix.vcd
+	@gtkwave jpeg_compressor.vcd

modules/compression/src/ips_jpg_at_testbench.cpp

@@ -15,13 +15,17 @@
 const int n_rows = 208;
 const int n_cols = 288;
 
+
+namespace ips
+{
 struct Image {
-    int matrix[n_rows][n_cols];
+    int matrix[n_rows][n_cols] = {0};
 };
+}
 
-Image dummy_img(int i_rows, int i_cols)
+ips::Image dummy_img(int i_rows, int i_cols)
 {
-    Image dummy;
+    ips::Image dummy = {};
     // Fill the image with values
 	int filler = 10;
     for (int i = 0; i < i_rows; i++) {
@@ -33,32 +37,15 @@ Image dummy_img(int i_rows, int i_cols)
  	return dummy;
 }
 
-void print_matrix(Image image, int image_rows, int image_cols)
-{
-    for (int i = 0; i < image_rows; ++i) {
-        for (int j = 0; j < image_cols; ++j) {
-            cout << image.matrix[i][j]<<" ";
-        }
-        cout << endl;
-    }
-}
-
-void print_array(signed char *Arr, int array_length)
-{
-    for (int i = 0; i < array_length; ++i) {
-       cout << int(Arr[i])<<" ";
-    }
-	cout << endl;
-}
-int sc_main (int argc, char* argv[]) {
+int sc_main(int, char*[]) {
   sc_signal<sc_int<32> > matrix_element;
   sc_signal<sc_int<32> > matrix_row;
   sc_signal<sc_int<32> > matrix_col;
   sc_signal<sc_int<8> > Array_element;
   sc_signal<sc_int<32> > array_index;
   sc_signal<sc_int<32> > Array_size;
 
-  Image input_image = dummy_img(n_rows, n_cols);
+  ips::Image input_image = dummy_img(n_rows, n_cols);
   int image_rows = sizeof(input_image.matrix)/ sizeof(input_image.matrix[0]);
   int image_cols = sizeof(input_image.matrix[0])/ sizeof(int);
   //Image output_image;
@@ -128,6 +115,5 @@ int sc_main (int argc, char* argv[]) {
   cout << "@" << sc_time_stamp() <<" Terminating simulation\n" << endl;
   sc_close_vcd_trace_file(wf);
   return 0;// Terminate simulation
-
- }
+}
 #endif // IPS_JPG_AT_EN

modules/compression/src/ips_jpg_lt_testbench.cpp

@@ -15,13 +15,16 @@
 const int n_rows = 208;
 const int n_cols = 288;
 
+namespace ips
+{
 struct Image {
     int matrix[n_rows][n_cols] = {0};
 };
+}
 
-Image dummy_img(int i_rows, int i_cols)
+ips::Image dummy_img(int i_rows, int i_cols)
 {
-    Image dummy;
+    ips::Image dummy = {};
     // Fill the image with values
 	int filler = 10;
     for (int i = 0; i < i_rows; i++) {
@@ -33,25 +36,8 @@ Image dummy_img(int i_rows, int i_cols)
  	return dummy;
 }
 
-void print_matrix(Image image, int image_rows, int image_cols)
-{
-    for (int i = 0; i < image_rows; ++i) {
-        for (int j = 0; j < image_cols; ++j) {
-            cout << image.matrix[i][j]<<" ";
-        }
-        cout << endl;
-    }
-}
-
-void print_array(signed char *Arr, int array_length)
-{
-    for (int i = 0; i < array_length; ++i) {
-       cout << int(Arr[i])<<" ";
-    }
-	cout << endl;
-}
-int sc_main (int argc, char* argv[]) {
-  Image input_image = dummy_img(n_rows, n_cols);
+int sc_main (int, char*[]) {
+  ips::Image input_image = dummy_img(n_rows, n_cols);
   int image_rows = sizeof(input_image.matrix)/ sizeof(input_image.matrix[0]);
   int image_cols = sizeof(input_image.matrix[0])/ sizeof(int);
   //Image output_image;
@@ -104,6 +90,5 @@ int sc_main (int argc, char* argv[]) {
   cout << "@" << sc_time_stamp() <<" Terminating simulation\n" << endl;
   sc_close_vcd_trace_file(wf);
   return 0;// Terminate simulation
-
- }
+}
 #endif // IPS_JPG_LT_EN

modules/compression/src/ips_jpg_pv_testbench.cpp

@@ -15,13 +15,17 @@
 const int n_rows = 452;
 const int n_cols = 640;
 
+namespace ips
+{
 struct Image {
     int matrix[n_rows][n_cols] = {0};
 };
+}
 
-Image dummy_img(int i_rows, int i_cols)
+ips::Image dummy_img(int i_rows, int i_cols)
 {
-    Image dummy;
+    ips::Image dummy = {};
+
     // Fill the image with values
 	int filler = 10;
     for (int i = 0; i < i_rows; i++) {
@@ -33,25 +37,8 @@ Image dummy_img(int i_rows, int i_cols)
  	return dummy;
 }
 
-void print_matrix(Image image, int image_rows, int image_cols)
-{
-    for (int i = 0; i < image_rows; ++i) {
-        for (int j = 0; j < image_cols; ++j) {
-            cout << image.matrix[i][j]<<" ";
-        }
-        cout << endl;
-    }
-}
-
-void print_array(signed char *Arr, int array_length)
-{
-    for (int i = 0; i < array_length; ++i) {
-       cout << int(Arr[i])<<" ";
-    }
-	cout << endl;
-}
-int sc_main (int argc, char* argv[]) {
-  Image input_image = dummy_img(n_rows, n_cols);
+int sc_main(int, char*[]) {
+  ips::Image input_image = dummy_img(n_rows, n_cols);
   int image_rows = sizeof(input_image.matrix)/ sizeof(input_image.matrix[0]);
   int image_cols = sizeof(input_image.matrix[0])/ sizeof(int);
   //Image output_image;
@@ -102,5 +89,5 @@ int sc_main (int argc, char* argv[]) {
   sc_close_vcd_trace_file(wf);
   return 0;// Terminate simulation
 
- }
+}
 #endif // IPS_JPG_PV_EN

modules/unification/src/unification_tb.cpp

@@ -10,17 +10,15 @@
 #include "include/stb_image_write.h"
 
 #include <systemc.h>
-#include "math.h"
+#include <math.h>
 
 #ifdef IMG_UNIFICATE_PV_EN
 #include "unification_pv_model.hpp"
 #endif
 
-int sc_main (int argc, char* argv[]) {
-              
+int sc_main(int, char*[]) {
   unsigned char pixel_x, pixel_y;
   unsigned char pixel_magnitude;
-  int i;
   int width, height, channels, pixel_count;
   unsigned char *img_x, *img_y, *img_unificated;