Clear checker report view when needed (#185)

When changing from a project which isn't CodeChecker enabled or when changing between files, the report views will show no reports.

Author: vodorok

bundles/org.codechecker.eclipse.plugin/src/org/codechecker/eclipse/plugin/config/CodeCheckerContext.java

@@ -254,26 +254,23 @@ public void refreshChangeEditorPart(IEditorPart partRef) {
             activeEditorPart = partRef;
             IFile file = ((IFileEditorInput) partRef.getEditorInput()).getFile();
             IProject project = file.getProject();
-            try {
-                if (project.hasNature(CodeCheckerNature.NATURE_ID)) {
-                    String filename = projects.get(project).getAsProjectRelativePath(file.getProjectRelativePath().toString());
 
-                    IWorkbenchWindow activeWindow = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-                    if (activeWindow == null) {
-                        Logger.log(IStatus.ERROR, NULL_WINDOW);
-                        return;
-                    }
-                    IWorkbenchPage[] pages = activeWindow.getPages();
+            CodeCheckerProject ccProj = projects.get(project);
+            String filename = "";
+            if (ccProj != null)
+                filename = ccProj.getAsProjectRelativePath(file.getProjectRelativePath().toString());
 
-                    this.refreshProject(pages, project, true);
-                    this.refreshCurrent(pages, project, filename, true);
-                    this.refreshCustom(pages, project, "", true);
-                    this.activeProject = project;
-                }
-            } catch (CoreException e) {
-                // TODO Auto-generated catch block
-                e.printStackTrace();
+            IWorkbenchWindow activeWindow = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
+            if (activeWindow == null) {
+                Logger.log(IStatus.ERROR, NULL_WINDOW);
+                return;
             }
+            IWorkbenchPage[] pages = activeWindow.getPages();
+
+            this.refreshProject(pages, project, true);
+            this.refreshCurrent(pages, project, filename, true);
+            this.refreshCustom(pages, project, "", true);
+            this.activeProject = project;
         }
     }
 
@@ -333,7 +330,19 @@ public void refreshAddCustomReportListView(String secondaryId) {
      */
     public void runReportJob(ReportListView target, String currentFileName) {
         IProject project = target.getCurrentProject();
-        if (project == null) return;
+        if (project == null)
+            return;
+        try {
+            if (!project.hasNature(CodeCheckerNature.NATURE_ID)) {
+                target.clearModel();
+                return;
+            }
+        } catch (CoreException e) {
+            // If there is a problem with the project, clear it anyway.
+            target.clearModel();
+            return;
+        }
+
         Logger.log(IStatus.INFO, "Started Filtering Reports for project: "+project.getName());
 
         ReportParser parser = new ReportParser(reports.get(project), currentFileName);

bundles/org.codechecker.eclipse.plugin/src/org/codechecker/eclipse/plugin/init/ProjectExplorerSelectionListener.java

@@ -1,17 +1,14 @@
 package org.codechecker.eclipse.plugin.init;
 
+import org.codechecker.eclipse.plugin.config.CodeCheckerContext;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;
-import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IAdaptable;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.ui.ISelectionListener;
 import org.eclipse.ui.IWorkbenchPart;
 
-import org.codechecker.eclipse.plugin.CodeCheckerNature;
-import org.codechecker.eclipse.plugin.config.CodeCheckerContext;
-
 public class ProjectExplorerSelectionListener implements ISelectionListener {
 
     @Override
@@ -22,13 +19,9 @@ public void selectionChanged(IWorkbenchPart part, ISelection selection) {
                 IResource resource = (IResource) ((IAdaptable) element).getAdapter(IResource.class);
                 if (resource != null) {
                     final IProject project = resource.getProject();
-                    try {
-                        if (project != null && project.hasNature(CodeCheckerNature.NATURE_ID))
-                            CodeCheckerContext.getInstance().refreshChangeProject(project);
-                    } catch (CoreException e) {
-                        // TODO Auto-generated catch block
-                        e.printStackTrace();
-                    }
+                    if (project != null)
+                        CodeCheckerContext.getInstance().refreshChangeProject(project);
+
                 }
             }
         }