-
-
Notifications
You must be signed in to change notification settings - Fork 59
Description
Describe the bug
The dedicated keyboard brightness support introduced in PR #185 seems to be entirely missing from the CLI after the migration to clap (PR #187). There are no keyboard-specific arguments (like --kbd-backlight or --keyboard-brightness) exposed in swayosd-client --help on version 0.3.0.
Currently, the only way to adjust the keyboard backlight is by treating it as a standard display using the generic --brightness and --device flags. This leads to two distinct UX regressions.
The Problem (Current workarounds and their flaws)
When using the --brightness fallback, swayosd treats the keyboard exactly like a main monitor:
Wrong Icon: It displays the generic display brightness icon (the sun) instead of a keyboard-specific one.
0% Lockout: It enforces the min_brightness safety threshold (added in PR #183), preventing the user from completely turning off the keyboard backlight. This safety feature makes sense for monitors, but completely breaks keyboard backlight usage.
Expected behavior
Re-expose a dedicated CLI flag (e.g., --kbd-brightness) that:
Uses the correct icon (e.g., keyboard-brightness-symbolic or input-keyboard).
Bypasses the min_brightness limit, allowing the value to drop safely to 0%.
Environment
OS: Fedora Linux
Hardware: MacBook Air 7,2 (using apple::kbd_backlight controller)
SwayOSD version: 0.3.0
(yes i used gemini to file the issue love your code tho)