fix bot crash when proxy is unusable

Author: vinaghost

TbsCore/Core/WebBrowserInfo.cs

@@ -35,19 +35,21 @@ public WebBrowserInfo()
 
         public string CurrentUrl { get => Driver?.Url; }
 
-        public async Task Init(Account acc, bool newAccess = true)
+        public async Task<bool> Init(Account acc, bool newAccess = true)
         {
             this.acc = acc;
             Access.Access access = newAccess ? acc.Access.GetNewAccess() : acc.Access.GetCurrentAccess();
 
-            SetupChromeDriver(access, acc.AccInfo.Nickname, acc.AccInfo.ServerUrl);
-
             if (!string.IsNullOrEmpty(access.Proxy))
             {
-                await CheckProxy(acc);
+                var checkResult = await CheckProxy(acc);
+                if (!checkResult) return false;
             }
 
+            SetupChromeDriver(access, acc.AccInfo.Nickname, acc.AccInfo.ServerUrl);
+
             await Navigate($"{acc.AccInfo.ServerUrl}/dorf1.php");
+            return true;
         }
 
         private void SetupChromeDriver(Access.Access access, string username, string server)
@@ -229,6 +231,18 @@ public async Task<bool> CheckProxy(Account acc)
             do
             {
                 var currentAccess = acc.Access.GetCurrentAccess();
+                if (string.IsNullOrEmpty(currentAccess.Proxy))
+                {
+                    return true;
+                }
+
+                if (!currentAccess.Ok)
+                {
+                    acc.Logger.Warning($"All proxies in your account is unusable! Please check your proxy status.");
+
+                    return false;
+                }
+
                 var currentProxy = currentAccess.Proxy;
                 acc.Logger.Information("Checking proxy " + currentProxy);
 

TbsCore/Helpers/IoHelperCore.cs

@@ -171,7 +171,7 @@ public static void SaveAccounts(List<Account> accounts, bool logout)
         /// Login into account and initialize everything
         /// </summary>
         /// <param name="acc">Account</param>
-        public static async Task LoginAccount(Account acc)
+        public static async Task<bool> LoginAccount(Account acc)
         {
             if (acc.Wb == null)
             {
@@ -182,7 +182,12 @@ public static async Task LoginAccount(Account acc)
                 acc.Villages.ForEach(vill => vill.UnfinishedTasks = new List<VillUnfinishedTask>());
 
                 acc.Wb = new WebBrowserInfo();
-                await acc.Wb.Init(acc);
+                var opened = await acc.Wb.Init(acc);
+                if (!opened)
+                {
+                    acc.Logger.Warning("Cannot open browser. Check warning below");
+                    return false;
+                }
                 AccountHelper.StartAccountTasks(acc);
                 acc.TaskTimer.Start();
             }
@@ -195,6 +200,7 @@ public static async Task LoginAccount(Account acc)
                     DiscordHelper.SendMessage(acc, "TravianBotSharp is online now");
                 }
             }
+            return true;
         }
 
         /// <summary>

TbsCore/Helpers/ProxyHelper.cs

@@ -31,8 +31,15 @@ public static async Task<bool> TestProxy(RestClient client, string proxyIp)
             {
                 Method = Method.Get,
             };
-            var response = await client.ExecuteAsync(request);
-            return response.Content.Equals(proxyIp);
+            try
+            {
+                var response = await client.ExecuteAsync(request);
+                return response.Content.Equals(proxyIp);
+            }
+            catch
+            {
+                return false;
+            }
         }
     }
 }

TravBotSharp/ControlPanel.cs

@@ -77,7 +77,8 @@ private void LoadAccounts()
                 ObjectHelper.FixAccObj(x, x);
                 x.Tasks = new TaskList(x);
                 x.TaskTimer = new TaskTimer(x);
-
+                // we will check again before we login
+                x.Access.AllAccess.ForEach(a => a.Ok = true);
                 // x.Tasks.Load();
             });
 
@@ -135,19 +136,30 @@ private void InsertAccIntoListView(string nick, string url, string proxy, int po
             accListView.Items.Add(item);
         }
 
-        private void button2_Click(object sender, EventArgs e) //login button
+        private async void button2_Click(object sender, EventArgs e) //login button
         {
             var acc = GetSelectedAcc();
             if (0 < acc.Access.AllAccess.Count)
             {
-                new Thread(async () =>
+                var task = await Task.Run(async () =>
                 {
-                    await IoHelperCore.LoginAccount(acc);
+                    var success = await IoHelperCore.LoginAccount(acc);
+                    if (!success) return false;
                     acc.Tasks.OnUpdateTask = debugUc1.UpdateTaskTable;
                     debugUc1.UpdateTaskTable();
-                }).Start();
-                generalUc1.UpdateBotRunning("true");
-                return;
+
+                    return true;
+                });
+
+                if (task)
+                {
+                    generalUc1.UpdateBotRunning("true");
+                }
+                else
+                {
+                    _ = MessageBox.Show("Check debug log to more info", "Error in account", MessageBoxButtons.OK);
+                    return;
+                }
             }
 
             // Alert user that account has no access defined
@@ -185,7 +197,7 @@ private void accListView_SelectedIndexChanged(object sender, EventArgs e) // Dif
             }
             var acc = GetSelectedAcc();
             // If account has no Wb object, it's not logged in at the moment
-            button2.Enabled = acc != null && acc.Wb == null;
+            button2.Enabled = !(acc?.TaskTimer?.IsBotRunning ?? false);
 
             UpdateFrontEnd();