Skip to content

Commit 863f085

Browse files
committed
[android] improve missing controller error and align AGP/Gradle
1 parent e2cea18 commit 863f085

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

spine-android/gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[versions]
2-
agp = "8.3.1"
2+
agp = "8.11.2"
33
kotlin = "1.9.0"
44
coreKtx = "1.10.1"
55
junit = "4.13.2"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#Thu Apr 25 11:12:13 CEST 2024
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
4-
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
4+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
55
zipStoreBase=GRADLE_USER_HOME
66
zipStorePath=wrapper/dists

spine-android/spine-android/src/main/java/com/esotericsoftware/spine/android/SpineView.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,18 @@ public void setRendering (Boolean rendering) {
351351
}
352352

353353
private void loadFrom (AndroidSkeletonDrawableLoader loader) {
354+
if (controller == null) {
355+
throw new IllegalStateException(
356+
"SpineController is not set. When using SpineView from XML, call setController(...) before loadFromAsset/loadFromFile/loadFromHttp/loadFromDrawable.");
357+
}
354358
Handler mainHandler = new Handler(Looper.getMainLooper());
355359
Thread backgroundThread = new Thread( () -> {
356360
final AndroidSkeletonDrawable skeletonDrawable = loader.load();
357361
mainHandler.post( () -> {
362+
if (controller == null) {
363+
throw new IllegalStateException(
364+
"SpineController became null before initialization. Ensure setController(...) is called and not cleared until loading completes.");
365+
}
358366
computedBounds = boundsProvider.computeBounds(skeletonDrawable);
359367
updateCanvasTransform();
360368

0 commit comments

Comments
 (0)