Skip to content

Commit 4030ffd

Browse files
authored
Revert "Update loggings to make sure builders are run correctly (#1867)" (#1869)
This reverts commit a712190, reversing changes made to 036d0a9. Closes #<ISSUE_NUMBER> <!-- These comments should help create a useful PR message, please delete any remaining comments before opening the PR. --> <!-- If there is no issue number make sure to describe clearly *why* this PR is necessary. --> <!-- Mention open questions, remaining TODOs, if any --> ### This PR: <!-- Describe what this PR adds to this repo and why --> <!-- E.g. --> <!-- * Implements feature 1 --> <!-- * Fixes bug 3 --> ### This PR does not: <!-- Describe what is out of scope for this PR, if applicable. Leave this section blank if it's not applicable --> <!-- This section helps avoid the reviewer having to needlessly point out missing parts --> <!-- * Implement feature 3 because that feature is blocked by Issue 4 --> <!-- * Implement xyz because that is tracked in issue #123. --> <!-- * Address xzy for which I opened issue #456 --> ### Key places to review: <!-- Describe key places for reviewers to pay close attention to --> <!-- * file.rs, `add_integers` function --> <!-- Or directly comment on those files/lines to make it easier for the reviewers --> <!-- ### How to test this PR: --> <!-- Optional, uncomment the above line if this is relevant to your PR --> <!-- If your PR is fully tested through CI there is no need to add this section --> <!-- * E.g. `just test` --> <!-- ### Things tested --> <!-- Anything that was manually tested (that is not tested in CI). --> <!-- E.g. building/running of docker containers. Changes to docker demo, ... --> <!-- Especially mention anything untested, with reasoning and link an issue to resolve this. --> <!-- Complete the following items before creating this PR --> <!-- [ ] Issue linked or PR description mentions why this change is necessary. --> <!-- [ ] PR description is clear enough for reviewers. --> <!-- [ ] Documentation for changes (additions) has been updated (added). --> <!-- [ ] If this is a draft it is marked as "draft". --> <!-- To make changes to this template edit https://github.com/EspressoSystems/.github/blob/main/PULL_REQUEST_TEMPLATE.md -->
2 parents a712190 + fd3c5c4 commit 4030ffd

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

data/genesis/demo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ fee_contract = '0xa15bb66138824a1c7167f5e85b957d04dd34e468'
1212
timestamp = "1970-01-01T00:00:00Z"
1313

1414
[[upgrade]]
15-
version = "0.3"
15+
version = "0.2"
1616
start_proposing_view = 5
1717
stop_proposing_view = 15
1818

marketplace-builder/src/builder.rs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -206,29 +206,26 @@ impl BuilderConfig {
206206
let res =
207207
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
208208
.await;
209-
tracing::error!(?res, "Reserve builder service exited");
209+
tracing::error!(?res, "builder service exited");
210210
if res.is_err() {
211-
panic!("Reserve builder should restart.");
211+
panic!("Builder should restart.");
212212
}
213213
});
214-
215-
tracing::info!("Reserve builder init finished");
216214
} else {
217215
let hooks = hooks::EspressoFallbackHooks { solver_api_url };
218216

219217
async_spawn(async move {
220218
let res =
221219
run_non_permissioned_standalone_builder_service(hooks, senders, events_url)
222220
.await;
223-
tracing::error!(?res, "Fallback builder service exited");
221+
tracing::error!(?res, "builder service exited");
224222
if res.is_err() {
225-
panic!("Fallback builder should restart.");
223+
panic!("Builder should restart.");
226224
}
227225
});
228-
229-
tracing::info!("Fallback builder init finished");
230226
}
231227

228+
tracing::info!("Builder init finished");
232229
Ok(Self {
233230
global_state,
234231
hotshot_events_api_url,

process-compose.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,8 @@ processes:
367367
path: /healthcheck
368368
failure_threshold: 100
369369

370-
# We use KeyDB (a Redis variant) to maintain consistency between
370+
371+
# We use KeyDB (a Redis variant) to maintain consistency between
371372
# different parts of the CDN
372373
# Cheating a bit here too, but KeyDB is not available as a Nix package.
373374
# Could do local (SQLite) discovery, but removes some of the spirit
@@ -490,7 +491,7 @@ processes:
490491
failure_threshold: 100
491492

492493
marketplace-reserve-builder:
493-
# disabled: true
494+
disabled: true
494495
command: marketplace-builder
495496
ports:
496497
- "$ESPRESSO_BUILDER_SERVER_PORT:$ESPRESSO_BUILDER_SERVER_PORT"
@@ -515,7 +516,7 @@ processes:
515516
failure_threshold: 100
516517

517518
marketplace-fallback-builder:
518-
# disabled: true
519+
disabled: true
519520
command: marketplace-builder
520521
ports:
521522
- "$ESPRESSO_FALLBACK_BUILDER_SERVER_PORT:$ESPRESSO_FALLBACK_BUILDER_SERVER_PORT"
@@ -541,7 +542,6 @@ processes:
541542
failure_threshold: 100
542543

543544
permissionless-builder:
544-
disabled: true
545545
command: permissionless-builder
546546
ports:
547547
- "$ESPRESSO_BUILDER_SERVER_PORT:$ESPRESSO_BUILDER_SERVER_PORT"

types/src/v0/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ impl NodeType for SeqTypes {
131131
type Membership = GeneralStaticCommittee<Self, PubKey>;
132132
type BuilderSignatureKey = FeeAccount;
133133
type Base = StaticVersion<0, 1>;
134-
type Upgrade = StaticVersion<0, 3>;
134+
type Upgrade = StaticVersion<0, 2>;
135135
type AuctionResult = SolverAuctionResults;
136136
const UPGRADE_HASH: [u8; 32] = [
137137
1, 0, 1, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0,

0 commit comments

Comments
 (0)