trigger catchup for membership every 200 views

Author: imabdulbasit

crates/hotshot/task-impls/src/consensus/mod.rs

@@ -153,10 +153,12 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions> ConsensusTaskSt
             HotShotEvent::ViewChange(new_view_number, epoch_number) => {
                 // Request the randomized stake table for the subsequent epoch,
                 // to trigger catchup and the DRB calculation if it happens to be missing.
-                let _ = self
-                    .membership_coordinator
-                    .membership_for_epoch(epoch_number.map(|e| e + 1))
-                    .await;
+                if **new_view_number % 200 == 0 {
+                    let _ = self
+                        .membership_coordinator
+                        .membership_for_epoch(epoch_number.map(|e| e + 1))
+                        .await;
+                }
 
                 if let Err(e) =
                     handle_view_change(*new_view_number, *epoch_number, &sender, self).await

sequencer/src/api.rs

@@ -923,22 +923,6 @@ impl<
         self.inner().get_chain_config(commitment).await
     }
     async fn get_leaf_chain(&self, height: u64) -> anyhow::Result<Vec<Leaf2>> {
-        {
-            let decided_height = self
-                .as_ref()
-                .consensus()
-                .await
-                .read()
-                .await
-                .decided_leaf()
-                .await
-                .height();
-
-            ensure!(
-                decided_height >= height,
-                "Requested leaf chain at height {height} but decided height is {decided_height}"
-            );
-        }
         // Check if we have the desired state in memory.
         match self.as_ref().get_leaf_chain(height).await {
             Ok(cf) => return Ok(cf),