Fetch multiple stake table events in one rpc call (#3585)

* get all the events in one rpc call

* fix log

* use decode_raw_log()

* fix comment

* remove StakeTableEvents type

* skip if authentication fails

* sort events when fetching

* add commission updated event

Author: imabdulbasit

sequencer/src/api.rs

@@ -2117,7 +2117,6 @@ mod test {
     };
     use espresso_types::{
         config::PublicHotShotConfig,
-        sparse_mt::KeccakNode,
         traits::{NullEventConsumer, PersistenceOptions},
         v0_3::{Fetcher, RewardAmount, COMMISSION_BASIS_POINTS, REWARD_MERKLE_TREE_V1_ARITY},
         v0_4::REWARD_MERKLE_TREE_V2_ARITY,
@@ -3496,14 +3495,13 @@ mod test {
             }
             let l1_block = header.l1_finalized().expect("l1 block not found");
 
-            let events = Fetcher::fetch_events_from_contract(
+            let sorted_events = Fetcher::fetch_events_from_contract(
                 l1_client.clone(),
                 stake_table,
                 None,
                 l1_block.number(),
             )
-            .await;
-            let sorted_events = events.sort_events().expect("failed to sort");
+            .await?;
 
             let mut sorted_dedup_removed = sorted_events.clone();
             sorted_dedup_removed.dedup();
@@ -5967,6 +5965,8 @@ mod test {
             wait_until_block_height(&client, "reward-state-v2/block-height", height).await;
 
             for (address, _) in validated_state.reward_merkle_tree_v2.iter() {
+                use espresso_types::sparse_mt::KeccakNode;
+
                 let (_, expected_proof) = validated_state
                     .reward_merkle_tree_v2
                     .lookup(*address)

sequencer/src/persistence.rs

@@ -1272,8 +1272,7 @@ mod tests {
             None,
             block,
         )
-        .await
-        .sort_events()?;
+        .await?;
         assert_eq!(
             contract_events, events,
             "Events from contract and persistence do not match"
@@ -1546,6 +1545,7 @@ mod tests {
         for _i in 0..10 {
             // Wait for more than update interval to assert that persistence was updated
             // L1 update interval is 7s in this test
+
             tokio::time::sleep(std::time::Duration::from_secs(8)).await;
 
             let block = anvil_provider
@@ -1567,8 +1567,7 @@ mod tests {
 
             let contract_events =
                 Fetcher::fetch_events_from_contract(l1_client.clone(), st_addr, None, l1_block)
-                    .await
-                    .sort_events()?;
+                    .await?;
             assert_eq!(persisted_events, contract_events);
 
             prev_l1_block = l1_block;

staking-cli/src/registration.rs

@@ -340,8 +340,7 @@ mod test {
             Some(0),
             receipt.block_number.unwrap(),
         )
-        .await
-        .sort_events()?;
+        .await?;
 
         // verify that we only have the first RegisterV2 event
         assert_eq!(events.len(), 1);
@@ -402,8 +401,7 @@ mod test {
             Some(0),
             receipt.block_number.unwrap(),
         )
-        .await
-        .sort_events()?;
+        .await?;
 
         // verify that we only have the RegisterV2 event
         assert_eq!(events.len(), 1);