chore: better state relay log (#3618)

* relay log & logic

* fmt

* revert bad relay logic change

Author: mrain

sequencer/src/state_signature/relay_server/lcv1_relay.rs

@@ -35,12 +35,12 @@ pub struct LCV1StateRelayServerState {
     /// Bundles for light client V1
     bundles: HashMap<u64, HashMap<LightClientState, LCV1StateSignaturesBundle>>,
 
-    /// The latest state signatures bundle for legacy light client
+    /// The latest state signatures bundle for LCV1 light client
     latest_available_bundle: Option<LCV1StateSignaturesBundle>,
-    /// The block height of the latest available legacy state signature bundle
+    /// The block height of the latest available LCV1 state signature bundle
     latest_block_height: Option<u64>,
 
-    /// A ordered queue of block heights for legacy light client state, used for garbage collection.
+    /// A ordered queue of block heights for V1 light client state, used for garbage collection.
     gc_queue: BTreeSet<u64>,
 
     /// Stake table tracker
@@ -75,13 +75,10 @@ impl LCV1StateRelayServerDataSource for LCV1StateRelayServerState {
                 ServerError::catch_all(StatusCode::INTERNAL_SERVER_ERROR, e.to_string())
             })?;
         let Some(weight) = stake_table.known_nodes.get(&req.key) else {
-            tracing::warn!(
-                "Received invalid legacy signature from unknown node: {:?}",
-                req
-            );
+            tracing::warn!("Received LCV1 signature from unknown node: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::UNAUTHORIZED,
-                "Legacy signature posted by nodes not on the stake table".to_owned(),
+                "LCV1 signature posted by nodes not on the stake table".to_owned(),
             ));
         };
 
@@ -91,10 +88,10 @@ impl LCV1StateRelayServerDataSource for LCV1StateRelayServerState {
             &req.signature,
             &req.state,
         ) {
-            tracing::warn!("Received invalid legacy signature: {:?}", req);
+            tracing::warn!("Couldn't verify the received LCV1 signature: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::BAD_REQUEST,
-                "The posted legacy signature is not valid.".to_owned(),
+                "The posted LCV1 signature is not valid.".to_owned(),
             ));
         }
 
@@ -109,7 +106,7 @@ impl LCV1StateRelayServerDataSource for LCV1StateRelayServerState {
                 accumulated_weight: U256::from(0),
             });
         tracing::debug!(
-            "Accepting new legacy signature for block height {} from {}.",
+            "Accepting new LCV1 signature for block height {} from {}.",
             block_height,
             req.key
         );
@@ -118,8 +115,8 @@ impl LCV1StateRelayServerDataSource for LCV1StateRelayServerState {
                 // A signature is already posted for this key with this state
                 return Err(ServerError::catch_all(
                     StatusCode::BAD_REQUEST,
-                    "A legacy signature of this light client state is already posted at this \
-                     block height for this key."
+                    "A LCV1 signature of this light client state is already posted at this block \
+                     height for this key."
                         .to_owned(),
                 ));
             },

sequencer/src/state_signature/relay_server/lcv2_relay.rs

@@ -35,12 +35,12 @@ pub struct LCV2StateRelayServerState {
     /// Bundles for light client V2
     bundles: HashMap<u64, HashMap<LightClientState, LCV2StateSignaturesBundle>>,
 
-    /// The latest state signatures bundle for legacy light client
+    /// The latest state signatures bundle for LCV2 light client
     latest_available_bundle: Option<LCV2StateSignaturesBundle>,
-    /// The block height of the latest available legacy state signature bundle
+    /// The block height of the latest available LCV2 state signature bundle
     latest_block_height: Option<u64>,
 
-    /// A ordered queue of block heights for legacy light client state, used for garbage collection.
+    /// A ordered queue of block heights for V2 light client state, used for garbage collection.
     gc_queue: BTreeSet<u64>,
 
     /// Stake table tracker
@@ -75,13 +75,10 @@ impl LCV2StateRelayServerDataSource for LCV2StateRelayServerState {
                 ServerError::catch_all(StatusCode::INTERNAL_SERVER_ERROR, e.to_string())
             })?;
         let Some(weight) = stake_table.known_nodes.get(&req.key) else {
-            tracing::warn!(
-                "Received invalid legacy signature from unknown node: {:?}",
-                req
-            );
+            tracing::warn!("Received LCV2 signature from unknown node: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::UNAUTHORIZED,
-                "Legacy signature posted by nodes not on the stake table".to_owned(),
+                "LCV2 signature posted by nodes not on the stake table".to_owned(),
             ));
         };
 
@@ -92,10 +89,10 @@ impl LCV2StateRelayServerDataSource for LCV2StateRelayServerState {
             &req.state,
             &req.next_stake,
         ) {
-            tracing::warn!("Received invalid legacy signature: {:?}", req);
+            tracing::warn!("Couldn't verify the received LCV2 signature: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::BAD_REQUEST,
-                "The posted legacy signature is not valid.".to_owned(),
+                "The posted LCV2 signature is not valid.".to_owned(),
             ));
         }
 
@@ -111,7 +108,7 @@ impl LCV2StateRelayServerDataSource for LCV2StateRelayServerState {
                 accumulated_weight: U256::from(0),
             });
         tracing::debug!(
-            "Accepting new legacy signature for block height {} from {}.",
+            "Accepting new LCV2 signature for block height {} from {}.",
             block_height,
             req.key
         );
@@ -120,8 +117,8 @@ impl LCV2StateRelayServerDataSource for LCV2StateRelayServerState {
                 // A signature is already posted for this key with this state
                 return Err(ServerError::catch_all(
                     StatusCode::BAD_REQUEST,
-                    "A legacy signature of this light client state is already posted at this \
-                     block height for this key."
+                    "A LCV2 signature of this light client state is already posted at this block \
+                     height for this key."
                         .to_owned(),
                 ));
             },

sequencer/src/state_signature/relay_server/lcv3_relay.rs

@@ -36,12 +36,12 @@ pub struct LCV3StateRelayServerState {
     /// Bundles for light client V3
     bundles: HashMap<u64, HashMap<LightClientState, LCV3StateSignaturesBundle>>,
 
-    /// The latest state signatures bundle for legacy light client
+    /// The latest state signatures bundle for LCV3 light client
     latest_available_bundle: Option<LCV3StateSignaturesBundle>,
-    /// The block height of the latest available legacy state signature bundle
+    /// The block height of the latest available LCV3 state signature bundle
     latest_block_height: Option<u64>,
 
-    /// A ordered queue of block heights for legacy light client state, used for garbage collection.
+    /// A ordered queue of block heights for V3 light client state, used for garbage collection.
     gc_queue: BTreeSet<u64>,
 
     /// Stake table tracker
@@ -76,13 +76,10 @@ impl LCV3StateRelayServerDataSource for LCV3StateRelayServerState {
                 ServerError::catch_all(StatusCode::INTERNAL_SERVER_ERROR, e.to_string())
             })?;
         let Some(weight) = stake_table.known_nodes.get(&req.key) else {
-            tracing::warn!(
-                "Received invalid legacy signature from unknown node: {:?}",
-                req
-            );
+            tracing::warn!("Received LCV3 signature from unknown node: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::UNAUTHORIZED,
-                "Legacy signature posted by nodes not on the stake table".to_owned(),
+                "LCV3 signature posted by nodes not on the stake table".to_owned(),
             ));
         };
 
@@ -94,10 +91,10 @@ impl LCV3StateRelayServerDataSource for LCV3StateRelayServerState {
             &req.signature,
             signed_state_digest,
         ) {
-            tracing::warn!("Received invalid legacy signature: {:?}", req);
+            tracing::warn!("Couldn't verify the received LCV3 signature: {req}");
             return Err(ServerError::catch_all(
                 StatusCode::BAD_REQUEST,
-                "The posted legacy signature is not valid.".to_owned(),
+                "The posted LCV3 signature is not valid.".to_owned(),
             ));
         }
 
@@ -114,7 +111,7 @@ impl LCV3StateRelayServerDataSource for LCV3StateRelayServerState {
                 accumulated_weight: U256::from(0),
             });
         tracing::debug!(
-            "Accepting new legacy signature for block height {} from {}.",
+            "Accepting new LCV3 signature for block height {} from {}.",
             block_height,
             req.key
         );
@@ -123,8 +120,8 @@ impl LCV3StateRelayServerDataSource for LCV3StateRelayServerState {
                 // A signature is already posted for this key with this state
                 return Err(ServerError::catch_all(
                     StatusCode::BAD_REQUEST,
-                    "A legacy signature of this light client state is already posted at this \
-                     block height for this key."
+                    "A LCV3 signature of this light client state is already posted at this block \
+                     height for this key."
                         .to_owned(),
                 ));
             },