feat: staking-cli: concurrent txns, better output #3639

sveitser · 2025-10-03T13:17:12Z

Concurrent transaction submission for demo staking

Add a type to represent planned transactions.
Give caller control over submission and awaiting of transactions
while enforcing that dependencies are respected.
Add balance check.
Add tests.

staking-cli improvments:

output events
check for events in tests
add test to inspect output manually
when used as CLI: output to stdout/stderr consistently, use stdout for CLI output, stderr for errors and diagnostics
(unchanged) always use tracing if RUST_LOG_FORMAT=json

Example:

cargo test -p staking-cli -- manual --nocapture
...
2025-10-06T11:04:47.753947Z  INFO staking_cli: Deregistering validator 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
Success! transaction hash: 0x0245b8666169efe6500be3b737cf15de4c5ba0fc52924f15c16f37d46d854d77
event: ValidatorExit { validator: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266 }

2025-10-06T11:04:47.771906Z  INFO staking_cli: Claiming withdrawal for 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
Success! transaction hash: 0xd712b4fcf5d5b1a0d2fbb223f2c3cb3b456ef9611b7c1539b8d3eecc74777e32
event: Transfer { from: 0x0dcd1bf9a1b36ce34237eeafef220932846bcd82, to: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, value: 200000000000000000000 }
event: Withdrawal { account: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, amount: 200000000000000000000 }

2025-10-06T11:04:47.815836Z  INFO staking_cli: Claiming validator exit for 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
Success! transaction hash: 0x645408098515f9b29c210987c4a3602cc36dcd1565bbc118dd41b0972e75db5d
event: Transfer { from: 0x0dcd1bf9a1b36ce34237eeafef220932846bcd82, to: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, value: 300000000000000000000 }
event: Withdrawal { account: 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266, amount: 300000000000000000000 }

Notes for reviewers

The changeset is large but most of the code changes don't change behaviour. Everything demo.rs is only used for tests or private testnet setup.

To run the staking-cli tests: cargo test -p staking-cli

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1211558112283393

- allow broadcasting txns without awaiting - output events - check for events in tests - add test to inspect output manually - output to stdout/stderr consistently - always use tracing if RUST_LOG_FORMAT=json

(currently fails)

- Add a type to represent planned transactions. - Give caller control over submission and awaiting of transactions while enforcing that dependencies are respected. - Add balance check. - Add tests.

For some reason the behaviour is different than anvil. I'm not sure if this always fails due to how geth works or if it's just a race condition. In any event it seems adding another transaction receipt await point for approvals seems easier than getting to the bottom of this. If this turns out to be too slow we should just manually track nonces.

- Remove provider from transaction enum variants - Remove token and stake table addresses from transaction enum variants - Consume transaction inputs when creating transactions

This works much better with ownership. Make code cleaner and we don't have to use `take` anymore.

improve services dependencies: - stake-for-demo only needs stake-table to be deployed - sequencers should wait for stake-for-demo so that we don't race between the epoch root block arriving and the stake table funding having completed. This currently leads to a bit of a delay but should be much less of an issue once we have concurrent funding transactions from: #3639

rob-maron

Everything looks good high-level and usage-wise

rob-maron · 2025-10-10T20:38:01Z

staking-cli/src/demo.rs

+#[derive(Debug, Error)]
+pub enum CreateTransactionsError {
+    #[error(
+        "insufficient ESP balance: have {have} ESP, need {need} ESP to fund {delegators} \
+         delegators"
+    )]
+    InsufficientEsp {
+        have: String,
+        need: String,
+        delegators: usize,
+    },


rob-maron · 2025-10-10T20:41:16Z

staking-cli/tests/cli.rs

+                .success()
+                .stdout(str::contains("ValidatorRegistered"));


Nice, I like these tests

* feat: local demo on protocol v4 (drb and header) improve services dependencies: - stake-for-demo only needs stake-table to be deployed - sequencers should wait for stake-for-demo so that we don't race between the epoch root block arriving and the stake table funding having completed. This currently leads to a bit of a delay but should be much less of an issue once we have concurrent funding transactions from: #3639

* feat: concurrent txns, better output - allow broadcasting txns without awaiting - output events - check for events in tests - add test to inspect output manually - output to stdout/stderr consistently - always use tracing if RUST_LOG_FORMAT=json * fix: don't use deprecated method * test: demo deploy without instant mining (currently fails) * fix: wait for dependent txns to finalize * stake for demo with planned transactions - Add a type to represent planned transactions. - Give caller control over submission and awaiting of transactions while enforcing that dependencies are respected. - Add balance check. - Add tests. * add missing "event" prefix * fix: approval txns fail with geth in demo For some reason the behaviour is different than anvil. I'm not sure if this always fails due to how geth works or if it's just a race condition. In any event it seems adding another transaction receipt await point for approvals seems easier than getting to the bottom of this. If this turns out to be too slow we should just manually track nonces. * fix: nonce errors due to duplicate provider * remove unnecessary pending block ID * cleanup: centralize receipt status check * remove some useless variables * update docs * simplify types - Remove provider from transaction enum variants - Remove token and stake table addresses from transaction enum variants - Consume transaction inputs when creating transactions * separate processor and data types This works much better with ownership. Make code cleaner and we don't have to use `take` anymore.

* feat: local demo on protocol v4 (drb and header) improve services dependencies: - stake-for-demo only needs stake-table to be deployed - sequencers should wait for stake-for-demo so that we don't race between the epoch root block arriving and the stake table funding having completed. This currently leads to a bit of a delay but should be much less of an issue once we have concurrent funding transactions from: #3639

feat: concurrent txns, better output

8f1f87b

- allow broadcasting txns without awaiting - output events - check for events in tests - add test to inspect output manually - output to stdout/stderr consistently - always use tracing if RUST_LOG_FORMAT=json

sveitser changed the title ~~feat: concurrent txns, better output~~ feat: staking-cli: concurrent txns, better output Oct 3, 2025

sveitser added 7 commits October 3, 2025 15:43

fix: don't use deprecated method

8f2770f

test: demo deploy without instant mining

4393061

(currently fails)

fix: wait for dependent txns to finalize

fdfed1b

stake for demo with planned transactions

9599332

- Add a type to represent planned transactions. - Give caller control over submission and awaiting of transactions while enforcing that dependencies are respected. - Add balance check. - Add tests.

add missing "event" prefix

416215c

fix: nonce errors due to duplicate provider

05acc3f

sveitser marked this pull request as ready for review October 6, 2025 14:05

sveitser requested review from bfish713, imabdulbasit, jbearer, lukaszrzasik, pls148, rob-maron and ss-es as code owners October 6, 2025 14:05

sveitser added 9 commits October 6, 2025 16:54

remove unnecessary pending block ID

09211d5

cleanup: centralize receipt status check

5076f83

remove some useless variables

74fdcbe

update docs

3d63d19

Merge branch 'main' into ma/stake-for-demo-concurrent-txns

bc2abff

simplify types

a162401

- Remove provider from transaction enum variants - Remove token and stake table addresses from transaction enum variants - Consume transaction inputs when creating transactions

separate processor and data types

6401c86

This works much better with ownership. Make code cleaner and we don't have to use `take` anymore.

Merge branch 'main' into ma/stake-for-demo-concurrent-txns

ab810f2

Merge branch 'main' into ma/stake-for-demo-concurrent-txns

31e9f8c

sveitser mentioned this pull request Oct 10, 2025

feat: local demo on protocol v4 (drb and header) #3659

Merged

rob-maron approved these changes Oct 10, 2025

View reviewed changes

sveitser merged commit d3269ac into main Oct 10, 2025
145 of 147 checks passed

sveitser deleted the ma/stake-for-demo-concurrent-txns branch October 10, 2025 21:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: staking-cli: concurrent txns, better output #3639

feat: staking-cli: concurrent txns, better output #3639

Uh oh!

sveitser commented Oct 3, 2025 •

edited

Loading

Uh oh!

rob-maron left a comment

Uh oh!

rob-maron Oct 10, 2025

Uh oh!

rob-maron Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: staking-cli: concurrent txns, better output #3639

feat: staking-cli: concurrent txns, better output #3639

Uh oh!

Conversation

sveitser commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Concurrent transaction submission for demo staking

staking-cli improvments:

Notes for reviewers

Uh oh!

rob-maron left a comment

Choose a reason for hiding this comment

Uh oh!

rob-maron Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

rob-maron Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sveitser commented Oct 3, 2025 •

edited

Loading