op-challenger: Set agreed prestate preimage for super cannon games. (ethereum-optimism#13838)

Changes type to just []byte and uses empty array as not set for simplicity.

Author: ajsutton

op-challenger/game/fault/trace/super/super_cannon.go

@@ -37,10 +37,11 @@ func NewSuperCannonTraceAccessor(
 		logger := logger.New("agreedPrestate", claimInfo.AgreedPrestate, "claim", claimInfo.Claim, "localContext", localContext)
 		subdir := filepath.Join(dir, localContext.Hex())
 		localInputs := utils.LocalGameInputs{
-			L1Head:        l1Head.Hash,
-			L2OutputRoot:  crypto.Keccak256Hash(claimInfo.AgreedPrestate),
-			L2Claim:       claimInfo.Claim,
-			L2BlockNumber: new(big.Int).SetUint64(poststateBlock),
+			L1Head:         l1Head.Hash,
+			L2OutputRoot:   crypto.Keccak256Hash(claimInfo.AgreedPrestate),
+			AgreedPreState: claimInfo.AgreedPrestate,
+			L2Claim:        claimInfo.Claim,
+			L2BlockNumber:  new(big.Int).SetUint64(poststateBlock),
 		}
 		provider := cannon.NewTraceProvider(logger, m.ToTypedVmMetrics(cfg.VmType.String()), cfg, serverExecutor, prestateProvider, cannonPrestate, localInputs, subdir, depth)
 		return provider, nil

op-challenger/game/fault/trace/utils/local.go

@@ -13,7 +13,7 @@ type LocalGameInputs struct {
 	L1Head         common.Hash
 	L2Head         common.Hash
 	L2OutputRoot   common.Hash
-	AgreedPreState *[]byte
+	AgreedPreState []byte
 	L2Claim        common.Hash
 	L2BlockNumber  *big.Int
 }

op-challenger/game/fault/trace/vm/kona_interop_server_executor.go

@@ -22,7 +22,7 @@ func NewNativeKonaSuperExecutor() *KonaSuperExecutor {
 }
 
 func (s *KonaSuperExecutor) OracleCommand(cfg Config, dataDir string, inputs utils.LocalGameInputs) ([]string, error) {
-	if inputs.AgreedPreState == nil {
+	if len(inputs.AgreedPreState) == 0 {
 		return nil, errors.New("agreed pre-state is not defined")
 	}
 
@@ -33,7 +33,7 @@ func (s *KonaSuperExecutor) OracleCommand(cfg Config, dataDir string, inputs uti
 		"--l1-beacon-address", cfg.L1Beacon,
 		"--l2-node-addresses", cfg.L2,
 		"--l1-head", inputs.L1Head.Hex(),
-		"--agreed-l2-pre-state", common.Bytes2Hex(*inputs.AgreedPreState),
+		"--agreed-l2-pre-state", common.Bytes2Hex(inputs.AgreedPreState),
 		"--claimed-l2-post-state", inputs.L2Claim.Hex(),
 		"--claimed-l2-timestamp", inputs.L2BlockNumber.Text(10),
 	}

op-e2e/actions/proofs/helpers/kona.go

@@ -70,7 +70,7 @@ func RunKonaNative(
 	var hostCmd []string
 	var err error
 	if fixtureInputs.InteropEnabled {
-		inputs.AgreedPreState = &fixtureInputs.AgreedPrestate
+		inputs.AgreedPreState = fixtureInputs.AgreedPrestate
 		hostCmd, err = vm.NewNativeKonaSuperExecutor().OracleCommand(vmCfg, workDir, inputs)
 	} else {
 		hostCmd, err = vm.NewNativeKonaExecutor().OracleCommand(vmCfg, workDir, inputs)