Skip to content

Commit b4e377d

Browse files
author
Morten Nielsen
committed
Fix docfx build
1 parent 2621833 commit b4e377d

File tree

6 files changed

+41
-21
lines changed

6 files changed

+41
-21
lines changed

.github/workflows/ghpages.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ jobs:
2828
- name: Download DocFX
2929
run: |
3030
mkdir .tools/docfx
31-
Invoke-WebRequest -Uri "https://github.com/dotnet/docfx/releases/download/v${env:DOCFXVERSION}/docfx.zip" -OutFile ".tools/docfx/docfx.zip"
31+
Invoke-WebRequest -Uri "https://github.com/dotnet/docfx/releases/download/v${env:DOCFXVERSION}/docfx-win-x64-v${env:DOCFXVERSION}.zip" -OutFile ".tools/docfx/docfx.zip"
3232
[System.IO.Compression.ZipFile]::ExtractToDirectory(".tools/docfx/docfx.zip", ".tools/docfx" )
3333
env:
34-
DOCFXVERSION: 2.59.4
34+
DOCFXVERSION: 2.77.0
3535

3636
- name: Download .NET xrefmap
3737
run: |

docs/BuildDoc.cmd

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,39 @@
11
@ECHO OFF
22

3-
SET DocFXVersion=2.59.4
3+
SET DocFXVersion=2.77.0
44
SET DocFxFolder=%~dp0..\.tools\docfx
55

66
REM Download DocFx
77

88
IF NOT EXIST "%DocFxFolder%\v%DocFXVersion%\docfx.exe" (
99
MKDIR "%DocFXFolder%\v%DocFXVersion%"
10-
powershell -ExecutionPolicy ByPass -command "Invoke-WebRequest -Uri "https://github.com/dotnet/docfx/releases/download/v%DocFXVersion%/docfx.zip" -OutFile '%DocFxFolder%\docfx_v%DocFXVersion%.zip'"
10+
powershell -ExecutionPolicy ByPass -command "Invoke-WebRequest -Uri "https://github.com/dotnet/docfx/releases/download/v%DocFXVersion%/docfx-win-x64-v${env:DOCFXVERSION}.zip" -OutFile '%DocFxFolder%\docfx_v%DocFXVersion%.zip'"
1111
powershell -ExecutionPolicy ByPass -command "Expand-Archive -LiteralPath '%DocFxFolder%\docfx_v%DocFXVersion%.zip' -DestinationPath '%DocFxFolder%\v%DocFXVersion%'"
1212
DEL "%DocFxFolder%\docfx_v%DocFXVersion%.zip" /Q
1313
)
1414
IF NOT EXIST "../Output/dotnet.xrefmap.json" (
1515
powershell -ExecutionPolicy ByPass -command "Invoke-WebRequest -Uri "https://github.com/dotnet/docfx/raw/main/.xrefmap.json" -OutFile '../Output/dotnet.xrefmap.json'"
1616
)
1717

18+
ECHO SEARCHING FOR VISUAL STUDIO...
19+
"%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" -prerelease -version [17.12,18.0) -sort -requires Microsoft.Component.MSBuild -products * -property InstallationPath > %TEMP%\vsinstalldir.txt
20+
SET /p _VSINSTALLDIR=<%TEMP%\vsinstalldir.txt
21+
ECHO VISUAL STUDIO FOUND IN: %_VSINSTALLDIR%
22+
DEL %TEMP%\vsinstalldir.txt
23+
IF "%_VSINSTALLDIR%"=="" (
24+
ECHO ERROR: VISUAL STUDIO NOT FOUND
25+
EXIT /B 1
26+
)
27+
IF "%VSINSTALLDIR%"=="" (
28+
CALL "%_VSINSTALLDIR%\Common7\Tools\VsDevCmd.bat"
29+
)
30+
31+
msbuild /restore /t:Restore %~dp0../src/Toolkit/Toolkit.WPF/Esri.ArcGISRuntime.Toolkit.WPF.csproj /p:Configuration=Release
32+
msbuild /restore /t:Restore %~dp0../src/Toolkit/Toolkit.WinUI/Esri.ArcGISRuntime.Toolkit.WinUI.csproj /p:Configuration=Release
33+
msbuild /restore /t:Restore %~dp0../src/Toolkit/Toolkit.UWP/Esri.ArcGISRuntime.Toolkit.UWP.csproj /p:Configuration=Release
34+
msbuild /restore /t:Restore %~dp0../src/Toolkit/Toolkit.Maui/Esri.ArcGISRuntime.Toolkit.Maui.csproj /p:Configuration=Release
35+
36+
1837
REM Build the output site (HTML) from the generated metadata and input files (uses configuration in docfx.json in this folder)
1938
%DocFxFolder%\v%DocFXVersion%\docfx.exe %~dp0\docfx.json
2039
ECHO Fixing API Reference Links

docs/api/netstd/index.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

docs/docfx.json

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"dest": "../output/docs/api/netfx",
1414
"properties": { "TargetFramework": "net472" },
1515
"disableGitFeatures": false,
16-
"disableDefaultFilter": false
16+
"disableDefaultFilter": false,
17+
"memberLayout": "separatePages"
1718
},
1819
{
1920
"src": [
@@ -28,44 +29,43 @@
2829
}
2930
],
3031
"dest": "../Output/docs/api/netwin",
31-
"properties": { "TargetFramework": "net9.0-windows10.0.19041.0" },
32+
"properties": { "NETWinOnly": "true", "_MauiBindingInterceptorsSupport": "false" },
3233
"disableGitFeatures": false,
33-
"disableDefaultFilter": false
34+
"disableDefaultFilter": false,
35+
"memberLayout": "separatePages"
3436
},
3537
{
3638
"src": [
3739
{
3840
"files": [
3941
"Toolkit/Toolkit.Maui/Esri.ArcGISRuntime.Toolkit.Maui.csproj",
40-
"ARToolkit/Esri.ArcGISRuntime.ARToolkit.csproj",
41-
"ARToolkit.Maui/Esri.ArcGISRuntime.ARToolkit.Maui.csproj"
4242
],
4343
"exclude": [ "**/bin/**", "**/obj/**" ],
4444
"src" : "../src/"
4545
}
4646
],
4747
"dest": "../Output/docs/api/android",
48-
"properties": { "TargetFramework": "net9.0-android" },
48+
"properties": { "TargetFramework": "net9.0-android35.0", "_MauiBindingInterceptorsSupport": "false" },
4949
"filter": "filterConfig.yml",
5050
"disableGitFeatures": false,
51-
"disableDefaultFilter": false
51+
"disableDefaultFilter": false,
52+
"memberLayout": "separatePages"
5253
},
5354
{
5455
"src": [
5556
{
5657
"files": [
5758
"Toolkit/Toolkit.Maui/Esri.ArcGISRuntime.Toolkit.Maui.csproj",
58-
"ARToolkit/Esri.ArcGISRuntime.ARToolkit.csproj",
59-
"ARToolkit.Maui/Esri.ArcGISRuntime.ARToolkit.Maui.csproj"
6059
],
6160
"exclude": [ "**/bin/**", "**/obj/**" ],
6261
"src" : "../src/"
6362
}
6463
],
6564
"dest": "../Output/docs/api/ios",
66-
"properties": { "TargetFramework": "net9.0-ios" },
65+
"properties": { "TargetFramework": "net9.0-ios18.0", "_MauiBindingInterceptorsSupport": "false" },
6766
"disableGitFeatures": false,
68-
"disableDefaultFilter": false
67+
"disableDefaultFilter": false,
68+
"memberLayout": "separatePages"
6969
},
7070
{
7171
"src": [
@@ -78,10 +78,11 @@
7878
}
7979
],
8080
"dest": "../output/docs/api/uwp",
81-
"properties": { "TargetFramework": "uap10.0.19041" },
81+
"properties": { "TargetFramework": "uap10.0.19041", "DocfxBuild": "true", "MSBuildExtensionsPath": "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\MSBuild" },
8282
"filter": "filterConfig.yml",
8383
"disableGitFeatures": false,
84-
"disableDefaultFilter": false
84+
"disableDefaultFilter": false,
85+
"memberLayout": "separatePages"
8586
}
8687
],
8788
"build": {
@@ -126,7 +127,8 @@
126127
"_gitContribute": {
127128
"branch": "main",
128129
"apiSpecFolder": "docs/api"
129-
}
130+
},
131+
"memberLayout": "separatePages"
130132
},
131133
"dest": "../Output/docs_site",
132134
"globalMetadataFiles": [],

src/Toolkit/Toolkit.Maui/Esri.ArcGISRuntime.Toolkit.Maui.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFrameworks>$(NETMauiTarget);$(NetAndroidTargetFramework);$(NetiOSTargetFramework);$(NetCatalystTargetFramework)</TargetFrameworks>
5+
<TargetFrameworks Condition="$(NETWinOnly)">$(NETMauiTarget)</TargetFrameworks>
56
<Description>ArcGIS Maps SDK for .NET controls and utilities for .NET MAUI apps including .NET for Android, .NET for iOS, .NET for macOS, or Windows UI 3 (WinUI 3)</Description>
67
<PackageTags>ArcGIS Cartography Geo Geographic Geography Geolocation Geospatial GIS Latitude Location Longitude Map Mapping Maps Places Spatial 3D WinUI Android iOS Mac Catalyst MacCatalyst Windows UI 3 toolkit</PackageTags>
78
<TargetFrameworks Condition="$([MSBuild]::IsOSPlatform('windows'))">$(TargetFrameworks);$(NetMauiWindowsTargetFramework)</TargetFrameworks>

src/Toolkit/Toolkit.WPF/Esri.ArcGISRuntime.Toolkit.WPF.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFrameworks>$(DotNetTargetFramework);$(NetWindowsTargetFramework)</TargetFrameworks>
5+
<TargetFrameworks Condition="$(NETWinOnly)">$(NetWindowsTargetFramework)</TargetFrameworks>
56
<Description>ArcGIS Maps SDK for .NET controls and utilities for WPF apps.</Description>
67
<PackageTags>ArcGIS Cartography Geo Geographic Geography Geolocation Geospatial GIS Latitude Location Longitude Map Mapping Maps Places Spatial 3D WPF toolkit</PackageTags>
78
<ImplicitUsings>enable</ImplicitUsings>

0 commit comments

Comments
 (0)