Merge pull request #214 from Esri/100.2.1

100.2.1

Author: tschie

build.gradle

@@ -14,7 +14,7 @@ buildscript {
     }
 }
 
-arcgis.version = '100.2.0'
+arcgis.version = '100.2.1'
 
 idea.module.downloadJavadoc = true
 eclipse.classpath.downloadJavadoc = true

src/main/java/com/esri/samples/analysis/line_of_sight_location/LineOfSightLocationSample.java

@@ -52,7 +52,7 @@ public void start(Stage stage) throws Exception {
       StackPane stackPane = new StackPane();
       Scene fxScene = new Scene(stackPane);
 
-      // set title, size, and add JavaFX scene to stage
+      // set title, size, and add JavaFX scene to stage 
       stage.setTitle("Line of Sight Location Sample");
       stage.setWidth(800);
       stage.setHeight(700);
@@ -70,7 +70,7 @@ public void start(Stage stage) throws Exception {
 
       // add base surface for elevation data
       Surface surface = new Surface();
-      surface.getElevationSources().add(new ArcGISTiledElevationSource( "http://elevation3d.arcgis" +
+      surface.getElevationSources().add(new ArcGISTiledElevationSource("http://elevation3d.arcgis" +
           ".com/arcgis/rest/services/WorldElevation3D/Terrain3D/ImageServer"));
       scene.setBaseSurface(surface);
 
@@ -79,7 +79,7 @@ public void start(Stage stage) throws Exception {
       sceneView.getAnalysisOverlays().add(analysisOverlay);
 
       // initialize a line of sight analysis and add it to the analysis overlay
-      Point observerLocation = new Point(-73.06958032962375,-49.253112971555446,2000, SpatialReferences.getWgs84());
+      Point observerLocation = new Point(-73.06958032962375, -49.253112971555446, 2000, SpatialReferences.getWgs84());
       Point targetLocation = new Point(-73.079266999709162, -49.300457676730559, 1312, SpatialReferences.getWgs84());
       LocationLineOfSight lineOfSight = new LocationLineOfSight(observerLocation, targetLocation);
       analysisOverlay.getAnalyses().add(lineOfSight);

src/main/java/com/esri/samples/analysis/viewshed_geoelement/ViewshedGeoElementSample.java

@@ -58,6 +58,7 @@ public class ViewshedGeoElementSample extends Application {
 
   private SceneView sceneView;
   private Graphic tank;
+  private Timeline animation;
   private Point waypoint;
 
   private static final LinearUnit METERS = new LinearUnit(LinearUnitId.METERS);
@@ -148,7 +149,7 @@ public void start(Stage stage) throws Exception {
       sceneView.setCameraController(cameraController);
 
       // create a timeline to animate the tank
-      Timeline animation = new Timeline();
+      animation = new Timeline();
       animation.setCycleCount(-1);
       animation.getKeyFrames().add(new KeyFrame(Duration.millis(100), e -> animate()));
       animation.play();
@@ -191,6 +192,9 @@ private void animate() {
   @Override
   public void stop() {
 
+    // stop the animation
+    animation.stop();
+
     if (sceneView != null) {
       sceneView.dispose();
     }

src/main/java/com/esri/samples/featurelayers/feature_collection_layer/README.md

@@ -10,15 +10,16 @@
 
 <ol>
     <li>Create a feature collection layer using a new feature collection, <code>new FeatureCollectionLayer(featureCollection)</code></li>
-    <li>The layer is then added to the map, <code>ArcGISap.getOperationalLayers().add(featureCollectionLayer)</code>.</li>
-    <li>A feature collection table is then created for the <code>GeometryType</code>s <code>Point</code> <code>Polyline</code> <code>Polygon</code>, <code>new FeatureCollectionTable(fields, geometryType, spatialRefernce)</code></li>
-      <ol>
-        <li><code>Field</code>s is a list of the feature's attributes, which this one defines it's name.</li>
-      </ol>
+    <li>The layer is then added to the map, <code>ArcGISMap.getOperationalLayers().add(featureCollectionLayer)</code>.</li>
+    <li>A feature collection table is then created for the <code>GeometryType</code>s <code>Point</code> <code>Polyline</code> <code>Polygon</code>, <code>new FeatureCollectionTable(fields, geometryType, spatialRefernce)</code>
+        <ol>
+            <li><code>Field</code>s is a list of the feature's attributes, which this one defines it's name.</li>
+        </ol>
+    </li>
     <li>A <code>SimpleRenderer</code> is then assigned to each table which will render any <code>Feature</code>s from that table using the <code>Symbol</code> that was set.</li>
     <li>The table is then added to the feature collection, <code>FeatureCollection.getTables().add(featureCollectionTable)</code>.</li>
     <li>To create a feature from the feature collection table use the createFeature method passing an attribute and geometry for that feature, <code>FeatureCollectionTable.createFeature(attributes, geometry)</code>.</li>
-    <li>Add new feature to the table,  <code>FeatureCollectionTable.addFeatureAsync(feature)</code>.</li>
+    <li>Add new feature to the table, <code>FeatureCollectionTable.addFeatureAsync(feature)</code>.</li>
 </ol>
 
 <h2>Features</h2>

src/main/java/com/esri/samples/featurelayers/feature_layer_definition_expression/FeatureLayerDefinitionExpressionSample.java

@@ -22,7 +22,6 @@
 import javafx.scene.Scene;
 import javafx.scene.control.ToggleButton;
 import javafx.scene.layout.StackPane;
-import javafx.scene.layout.VBox;
 import javafx.stage.Stage;
 
 import com.esri.arcgisruntime.data.ServiceFeatureTable;
@@ -45,7 +44,7 @@ public class FeatureLayerDefinitionExpressionSample extends Application {
   public void start(Stage stage) throws Exception {
 
     try {
-      // create stack pane and application scene
+      // create stack pane and application scene 
       StackPane stackPane = new StackPane();
       Scene scene = new Scene(stackPane);
       scene.getStylesheets().add(getClass().getResource("/css/style.css").toExternalForm());

src/main/java/com/esri/samples/featurelayers/feature_layer_rendering_mode_map/FeatureLayerRenderingModeMapSample.java

@@ -40,6 +40,7 @@ public class FeatureLayerRenderingModeMapSample extends Application {
 
   private MapView mapViewTop;
   private MapView mapViewBottom;
+  private Timeline timeline;
 
   @Override
   public void start(Stage stage) throws Exception {
@@ -100,7 +101,7 @@ public void start(Stage stage) throws Exception {
       mapViewBottom.setViewpoint(zoomOutPoint);
 
       //loop an animation into and out from the zoom in point (5 seconds each) with a 2 second gap between zooming
-      Timeline timeline = new Timeline();
+      timeline = new Timeline();
       timeline.setCycleCount(Animation.INDEFINITE);
       timeline.getKeyFrames().add(new KeyFrame(Duration.seconds(7), event -> zoomTo(zoomInPoint, 5)));
       timeline.getKeyFrames().add(new KeyFrame(Duration.seconds(14), event -> zoomTo(zoomOutPoint, 5)));
@@ -129,6 +130,9 @@ private void zoomTo(Viewpoint viewpoint, int seconds) {
   @Override
   public void stop() {
 
+    // stop the timer
+    timeline.stop();
+
     if (mapViewTop != null) {
       mapViewTop.dispose();
     }

src/main/java/com/esri/samples/featurelayers/generate_geodatabase/GenerateGeodatabaseSample.java

@@ -1,3 +1,18 @@
+/*
+ * Copyright 2017 Esri.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
 package com.esri.samples.featurelayers.generate_geodatabase;
 
 import java.io.File;
@@ -74,11 +89,12 @@ public void start(Stage stage) throws Exception {
       generateButton.setDisable(true); //wait until sync task loaded
       ProgressBar progressBar = new ProgressBar();
       progressBar.visibleProperty().bind(Bindings.createBooleanBinding(() -> progressBar.getProgress() > 0,
-      progressBar.progressProperty()));
+          progressBar.progressProperty()));
       progressBar.setProgress(0.0);
 
       // create a geodatabase sync task
-      String featureServiceURL = "https://sampleserver6.arcgisonline.com/arcgis/rest/services/Sync/WildfireSync/FeatureServer";
+      String featureServiceURL =
+          "https://sampleserver6.arcgisonline.com/arcgis/rest/services/Sync/WildfireSync/FeatureServer";
       GeodatabaseSyncTask syncTask = new GeodatabaseSyncTask(featureServiceURL);
       syncTask.loadAsync();
       syncTask.addDoneLoadingListener(() -> generateButton.setDisable(false));
@@ -96,7 +112,7 @@ public void start(Stage stage) throws Exception {
 
         // create generate geodatabase parameters for the current extent
         ListenableFuture<GenerateGeodatabaseParameters> defaultParameters = syncTask
-        .createDefaultGenerateGeodatabaseParametersAsync(extent);
+            .createDefaultGenerateGeodatabaseParametersAsync(extent);
         defaultParameters.addDoneListener(() -> {
           try {
             // set parameters
@@ -122,7 +138,7 @@ public void start(Stage stage) throws Exception {
               if (job.getStatus() == Job.Status.SUCCEEDED) {
                 Geodatabase geodatabase = job.getResult();
                 displayMessage("Geodatabase successfully generated", "Unregistering geodatabase since we're not " +
-                "syncing it here");
+                    "syncing it here");
                 geodatabase.loadAsync();
                 geodatabase.addDoneLoadingListener(() -> {
                   if (geodatabase.getLoadStatus() == LoadStatus.LOADED) {

src/main/java/com/esri/samples/na/offline_routing/OfflineRoutingSample.java

@@ -1,14 +1,18 @@
 /*
- * Copyright 2017 Esri. Licensed under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- * http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law
- * or agreed to in writing, software distributed under the License is
- * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the specific language
- * governing permissions and limitations under the License.
+ * Copyright 2017 Esri.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
  */
-
 package com.esri.samples.na.offline_routing;
 
 import java.util.Arrays;

src/main/java/com/esri/samples/ogc/wms_layer_url/README.md

@@ -0,0 +1,23 @@
+<h1>WMS Layer URL</h1>
+
+<p>Shows how to display a WMS layer from a URL.</p>
+
+<p><img src="WmsLayerUrl.png"/></p>
+
+<h2>How it works</h2>
+
+<p>To create a <code>WmsLayer</code> from a URL and display it:</p>
+
+<ol>
+  <li>Create a <code>WmsLayer</code> specifying the URL of the service and the layer names you want <code>new 
+  WmsLayer(url, names)</code>.</li>
+  <li>To display it, add it to the map as an operational layer <code>map.getOperationalLayers().add(wmsLayer)</code>.</li>
+</ol>
+
+<h2>Features</h2>
+
+<ul>
+  <li>ArcGISMap</li>
+  <li>MapView</li>
+  <li>WmsLayer</li>
+</ul>