patch oAuth sample custom challengehandler (#366)

* implement fix for javafx webengine

* formatting

* add fix for create and save map sample

* markdown to html formatting

Author: JonLavi

src/main/java/com/esri/samples/map/create_and_save_map/OAuthChallengeHandler.java

@@ -54,7 +54,7 @@ public AuthenticationChallengeResponse handleChallenge(AuthenticationChallenge c
       // get the authorization code by sending user to the authorization screen
       String authorizationUrl = OAuthTokenCredentialRequest.getAuthorizationUrl(
           config.getPortalUrl(), config.getClientId(), config.getRedirectUri(), 0);
-      String authorizationCode = OAuthChallenge.getAuthorizationCode(authorizationUrl);
+      String authorizationCode = OAuthChallenge.getAuthorizationCode(authorizationUrl + "&display=classic");
 
       // use the authorization code to get a token
       OAuthTokenCredentialRequest request = new OAuthTokenCredentialRequest(

src/main/java/com/esri/samples/map/create_and_save_map/README.md

@@ -40,3 +40,8 @@ chosen folder.</p>
   <li>PortalItem</li>
   <li>PortalUserContent</li>
 </ul>
+
+
+<h2>Additional information</h2>
+
+<p>The JavaFX <code>WebEngine</code> used in the <code>OAuthChallengeHandler</code> in this sample may not support rendering of some modern web elements returned by the <code>AuthorizationURL</code>. For this reason, we append <code>&display=classic</code> to the authorization URL, to ensure it renders properly.</p>

src/main/java/com/esri/samples/portal/oauth/OAuthChallengeHandler.java

@@ -91,7 +91,7 @@ static String getAuthorizationCode(String authorizationUrl) throws Exception {
       dialog.setScene(new Scene(browser, 450, 450));
       dialog.show();
       WebEngine webEngine = browser.getEngine();
-      webEngine.load(authorizationUrl);
+      webEngine.load(authorizationUrl + "&display=classic");
 
       // read the HTTP response to user action
       webEngine.setOnStatusChanged(event -> {

src/main/java/com/esri/samples/portal/oauth/README.md

@@ -36,3 +36,7 @@ access token. This access token is used later to access user's profile.</p>
     <li>Portal</li>
     <li>PortalUser</li>
 </ul>
+
+<h2>Additional information</h2>
+
+<p>The JavaFX <code>WebEngine</code> used in the <code>OAuthChallengeHandler</code> in this sample may not support rendering of some modern web elements returned by the <code>AuthorizationURL</code>. For this reason, we append <code>&display=classic</code> to the authorization URL, to ensure it renders properly.</p>