Merge pull request #553 from Esri/Caleb/Fix-ShowServiceAreaTaskBug

[Fix] Some Task block bugs

Author: CalebRas

Shared/Samples/Create load report/CreateLoadReportView.Model.swift

@@ -187,6 +187,8 @@ extension CreateLoadReportView {
         /// - Precondition: `allowsCreateLoadReport`
         func createLoadReport() async {
             precondition(allowsCreateLoadReport)
+            allowsCreateLoadReport = false
+            defer { updateAllowsCreateLoadReport() }
 
             guard let phasesNetworkAttribute,
                   let initialExpression,

Shared/Samples/Edit feature attachments/EditFeatureAttachmentsView.swift

@@ -163,12 +163,14 @@ private extension EditFeatureAttachmentsView {
 
 private extension EditFeatureAttachmentsView {
     struct AttachmentView: View {
-        // The attachment that is being displayed.
+        /// The attachment that is being displayed.
         let attachment: Attachment
-        // The closure called when the delete button is tapped.
+        /// The closure called when the delete button is tapped.
         let onDelete: ((Attachment) -> Void)
-        // The image in the attachment.
+        /// The image in the attachment.
         @State private var image: Image?
+        /// The image to show if an image cannot be created from the attachment's data.
+        private let warningImage = Image(systemName: "exclamationmark.triangle")
 
         var body: some View {
             HStack {
@@ -181,7 +183,7 @@ private extension EditFeatureAttachmentsView {
                         if let uiImage = UIImage(data: result) {
                             image = Image(uiImage: uiImage)
                         } else {
-                            image = Image(systemName: "exclamationmark.triangle")
+                            image = warningImage
                         }
                     }
                 } label: {
@@ -194,6 +196,7 @@ private extension EditFeatureAttachmentsView {
                         Image(systemName: "arrow.down.circle.fill")
                     }
                 }
+                .disabled(image != nil && image != warningImage)
             }
             .swipeActions {
                 Button("Delete") {

Shared/Samples/Find closest facility from point/FindClosestFacilityFromPointView.swift

@@ -55,7 +55,7 @@ struct FindClosestFacilityFromPointView: View {
                                 }
                             }
                         }
-                        .disabled(routingIsDisabled)
+                        .disabled(routingIsDisabled || isRouting)
 
                         Spacer()
 

Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.Model.swift

@@ -148,7 +148,7 @@ extension RunValveIsolationTraceView {
 
                 addGraphic(for: point, traceLocationType: "starting point")
                 startingLocationPoint = point
-                tracingActivity = .none
+                tracingActivity = nil
 
                 // Get available utility categories.
                 if let definition = utilityNetwork.definition {
@@ -224,9 +224,10 @@ extension RunValveIsolationTraceView {
             } catch {
                 statusText = "Trace failed."
                 traceEnabled = true
+                tracingActivity = nil
                 return
             }
-            tracingActivity = .none
+            tracingActivity = nil
             traceEnabled = true
             resetEnabled = true
         }

Shared/Samples/Run valve isolation trace/RunValveIsolationTraceView.swift

@@ -82,7 +82,7 @@ struct RunValveIsolationTraceView: View {
                             Task { await mapViewProxy.setViewpointCenter(point, scale: 3_000) }
                         }
                     }
-                    .disabled(!model.resetEnabled)
+                    .disabled(!model.resetEnabled || model.tracingActivity == .runningTrace)
                 }
             }
             .sheet(isPresented: $isConfigurationPresented) {

Shared/Samples/Show service area/ShowServiceAreaView.swift

@@ -30,6 +30,8 @@ struct ShowServiceAreaView: View {
     @State private var secondTimeBreak: Int = 8
     /// A Boolean value indicating whether the time breaks settings are presented.
     @State private var settingsArePresented = false
+    /// A Boolean value indicating whether the service area is being solved.
+    @State private var isSolvingServiceArea = false
 
     /// The data model for the sample.
     @StateObject private var model = Model()
@@ -76,13 +78,18 @@ struct ShowServiceAreaView: View {
                     Spacer()
                     Button("Service Area") {
                         Task {
+                            isSolvingServiceArea = true
                             do {
-                                try await model.showServiceArea(timeBreaks: [Double(firstTimeBreak), Double(secondTimeBreak)])
+                                try await model.showServiceArea(
+                                    timeBreaks: [Double(firstTimeBreak), Double(secondTimeBreak)]
+                                )
                             } catch {
                                 self.error = error
                             }
+                            isSolvingServiceArea = false
                         }
                     }
+                    .disabled(isSolvingServiceArea)
                     Spacer()
                     Button("Clear", systemImage: "trash") {
                         model.removeAllGraphics()