Merge pull request #664 from Esri/chrisw/lineofsightfix

chriswebb09 · web-flow · commit 8248660a28bc · 2025-07-18T16:40:33.000-07:00
[Fix] Update frame on popover
diff --git a/Shared/Samples/Browse WMS layers/BrowseWMSLayersView.swift b/Shared/Samples/Browse WMS layers/BrowseWMSLayersView.swift
@@ -62,7 +62,6 @@ struct BrowseWMSLayersView: View {
                                 .navigationBarTitleDisplayMode(.inline)
                                 .navigationTitle("Layer Visibility")
                                 .presentationDetents([.medium])
-                                .frame(idealWidth: 320, idealHeight: 380)
                                 .toolbar {
                                     ToolbarItem(placement: .topBarTrailing) {
                                         Button("Done") {
@@ -71,6 +70,7 @@ struct BrowseWMSLayersView: View {
                                     }
                                 }
                         }
+                        .frame(idealWidth: 320, idealHeight: 380)
                     }
                 }
             }
@@ -120,7 +120,6 @@ extension BrowseWMSLayersView {
                     .onChange(of: model.isVisible) { updateSelection() }
                 }
             }
-            .listStyle(.plain)
         }
         
         /// Updates the selection for given `isVisible`.
diff --git a/Shared/Samples/Browse WMS layers/browse-wms-layers.png b/Shared/Samples/Browse WMS layers/browse-wms-layers.png
diff --git a/Shared/Samples/Show line of sight between geoelements/ShowLineOfSightBetweenGeoelementsView.swift b/Shared/Samples/Show line of sight between geoelements/ShowLineOfSightBetweenGeoelementsView.swift
@@ -48,7 +48,7 @@ struct ShowLineOfSightBetweenGeoelementsView: View {
                 Button("Settings") {
                     isPresented = true
                 }
-                .sheet(isPresented: $isPresented) {
+                .popover(isPresented: $isPresented) {
                     settingsSheet
                 }
             }
@@ -101,6 +101,7 @@ struct ShowLineOfSightBetweenGeoelementsView: View {
                 }
             }
         }
+        .frame(idealWidth: 320, idealHeight: 380)
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,6 @@ struct BrowseWMSLayersView: View {`
`62`	`62`	`.navigationBarTitleDisplayMode(.inline)`
`63`	`63`	`.navigationTitle("Layer Visibility")`
`64`	`64`	`.presentationDetents([.medium])`
`65`		`- .frame(idealWidth: 320, idealHeight: 380)`
`66`	`65`	`.toolbar {`
`67`	`66`	`ToolbarItem(placement: .topBarTrailing) {`
`68`	`67`	`Button("Done") {`
`@@ -71,6 +70,7 @@ struct BrowseWMSLayersView: View {`
`71`	`70`	`}`
`72`	`71`	`}`
`73`	`72`	`}`
	`73`	`+ .frame(idealWidth: 320, idealHeight: 380)`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`	`}`
`@@ -120,7 +120,6 @@ extension BrowseWMSLayersView {`
`120`	`120`	`.onChange(of: model.isVisible) { updateSelection() }`
`121`	`121`	`}`
`122`	`122`	`}`
`123`		`- .listStyle(.plain)`
`124`	`123`	`}`
`125`	`124`
`126`	`125`	/// Updates the selection for given `isVisible`.
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ struct ShowLineOfSightBetweenGeoelementsView: View {`
`48`	`48`	`Button("Settings") {`
`49`	`49`	`isPresented = true`
`50`	`50`	`}`
`51`		`- .sheet(isPresented: $isPresented) {`
	`51`	`+ .popover(isPresented: $isPresented) {`
`52`	`52`	`settingsSheet`
`53`	`53`	`}`
`54`	`54`	`}`
`@@ -101,6 +101,7 @@ struct ShowLineOfSightBetweenGeoelementsView: View {`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`	`}`
	`104`	`+ .frame(idealWidth: 320, idealHeight: 380)`
`104`	`105`	`}`
`105`	`106`	`}`
`106`	`107`