Skip to content

Commit 85931d4

Browse files
authored
Merge pull request #678 from Esri/Ting/FixTearDownBranch
[Fix] Adjust the logic for Teardown > Non-Teardown and add missing source code files to build phase
2 parents 50c00e1 + ece7d4c commit 85931d4

File tree

2 files changed

+19
-17
lines changed

2 files changed

+19
-17
lines changed

Samples.xcodeproj/project.pbxproj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
0000FB6E2BBDB17600845921 /* Add3DTilesLayerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0000FB6B2BBDB17600845921 /* Add3DTilesLayerView.swift */; };
1111
0000FB712BBDC01400845921 /* Add3DTilesLayerView.swift in Copy Source Code Files */ = {isa = PBXBuildFile; fileRef = 0000FB6B2BBDB17600845921 /* Add3DTilesLayerView.swift */; };
1212
0005580A2817C51E00224BC6 /* SampleDetailView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 000558092817C51E00224BC6 /* SampleDetailView.swift */; };
13+
000B75702E33F67600C4B257 /* ControlAnnotationSublayerVisibilityView.Model.swift in Copy Source Code Files */ = {isa = PBXBuildFile; fileRef = 1C8438FA2DDCFCA9005CCBC7 /* ControlAnnotationSublayerVisibilityView.Model.swift */; };
14+
000B75712E33F67600C4B257 /* GenerateGeodatabaseReplicaFromFeatureServiceView.Model.swift in Copy Source Code Files */ = {isa = PBXBuildFile; fileRef = 1C17E1CB2DE6456B00A012CB /* GenerateGeodatabaseReplicaFromFeatureServiceView.Model.swift */; };
1315
000D43162B9918420003D3C2 /* ConfigureBasemapStyleParametersView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 000D43132B9918420003D3C2 /* ConfigureBasemapStyleParametersView.swift */; };
1416
000D43182B993A030003D3C2 /* ConfigureBasemapStyleParametersView.swift in Copy Source Code Files */ = {isa = PBXBuildFile; fileRef = 000D43132B9918420003D3C2 /* ConfigureBasemapStyleParametersView.swift */; };
1517
00181B462846AD7100654571 /* View+ErrorAlert.swift in Sources */ = {isa = PBXBuildFile; fileRef = 00181B452846AD7100654571 /* View+ErrorAlert.swift */; };
@@ -737,6 +739,10 @@
737739
dstPath = "";
738740
dstSubfolderSpec = 7;
739741
files = (
742+
000B75712E33F67600C4B257 /* GenerateGeodatabaseReplicaFromFeatureServiceView.Model.swift in Copy Source Code Files */,
743+
1C17E1CA2DDFB6FB00A012CB /* GenerateGeodatabaseReplicaFromFeatureServiceView.swift in Copy Source Code Files */,
744+
000B75702E33F67600C4B257 /* ControlAnnotationSublayerVisibilityView.Model.swift in Copy Source Code Files */,
745+
1C8438F92DDBDE1F005CCBC7 /* ControlAnnotationSublayerVisibilityView.swift in Copy Source Code Files */,
740746
951896BD2E29B20500144F9B /* ShowShapefileMetadataView.swift in Copy Source Code Files */,
741747
95A86A5D2E1C51A9000BF570 /* ShowPortalUserInfoView.swift in Copy Source Code Files */,
742748
9520B2B62E135AEE00B3BEF9 /* ShowLineOfSightBetweenGeoelementsView.swift in Copy Source Code Files */,
@@ -947,7 +953,6 @@
947953
D769C2132A29057200030F61 /* SetUpLocationDrivenGeotriggersView.swift in Copy Source Code Files */,
948954
1C19B4F72A578E69001D2506 /* CreateLoadReportView.Model.swift in Copy Source Code Files */,
949955
1C19B4F82A578E69001D2506 /* CreateLoadReportView.swift in Copy Source Code Files */,
950-
1C17E1CA2DDFB6FB00A012CB /* GenerateGeodatabaseReplicaFromFeatureServiceView.swift in Copy Source Code Files */,
951956
1C986DA72DDD46E0005E2E0F /* DisplayRouteLayerView.swift in Copy Source Code Files */,
952957
1C19B4F92A578E69001D2506 /* CreateLoadReportView.Views.swift in Copy Source Code Files */,
953958
D752D9412A39162F003EB25E /* ManageOperationalLayersView.swift in Copy Source Code Files */,
@@ -999,7 +1004,6 @@
9991004
0042E24628E50EE4001F33D6 /* ShowViewshedFromPointInSceneView.swift in Copy Source Code Files */,
10001005
0042E24728E50EE4001F33D6 /* ShowViewshedFromPointInSceneView.Model.swift in Copy Source Code Files */,
10011006
0042E24828E50EE4001F33D6 /* ShowViewshedFromPointInSceneView.ViewshedSettingsView.swift in Copy Source Code Files */,
1002-
1C8438F92DDBDE1F005CCBC7 /* ControlAnnotationSublayerVisibilityView.swift in Copy Source Code Files */,
10031007
006C835528B40682004AEB7F /* BrowseBuildingFloorsView.swift in Copy Source Code Files */,
10041008
006C835628B40682004AEB7F /* DisplayMapFromMobileMapPackageView.swift in Copy Source Code Files */,
10051009
F1E71BFA28A479C70064C33F /* AddRasterFromFileView.swift in Copy Source Code Files */,

Shared/Supporting Files/Views/CategoriesView.swift

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ struct CategoriesView: View {
3636
}
3737

3838
/// The name of the sample that currently needs torn down.
39-
@State private var sampleNeedingTearDown: String?
39+
@State private var sampleNeedingTeardown: String?
4040

4141
var body: some View {
4242
ScrollView {
@@ -82,20 +82,18 @@ struct CategoriesView: View {
8282
.navigationDestination(for: String.self) { sampleName in
8383
let sample = SamplesApp.samples.first(where: { $0.name == sampleName })!
8484

85-
if sample.hasTeardown {
86-
if sampleNeedingTearDown != nil, sampleNeedingTearDown != sampleName {
87-
ProgressView("Loading sample…")
88-
} else {
89-
SampleDetailView(sample: sample)
90-
.id(sampleName)
91-
.onAppear {
92-
sampleNeedingTearDown = sampleName
93-
}
94-
.environment(\.finishTeardown) {
95-
// Allows the next teardown sample to appear.
96-
sampleNeedingTearDown = nil
97-
}
98-
}
85+
if sampleNeedingTeardown != nil && sampleNeedingTeardown != sampleName {
86+
ProgressView("Loading sample")
87+
} else if sample.hasTeardown {
88+
SampleDetailView(sample: sample)
89+
.id(sampleName)
90+
.onAppear {
91+
sampleNeedingTeardown = sampleName
92+
}
93+
.environment(\.finishTeardown) {
94+
// Allows the next teardown sample to appear.
95+
sampleNeedingTeardown = nil
96+
}
9997
} else {
10098
SampleDetailView(sample: sample)
10199
.id(sampleName)

0 commit comments

Comments
 (0)