Skip to content

Commit dca6bd2

Browse files
yo1995CalebRas
andauthored
Apply suggestions from code review.
Co-authored-by: Caleb Rasmussen <[email protected]>
1 parent 727b172 commit dca6bd2

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

Shared/Samples/Add clustering feature reduction to a point feature layer/AddClusteringFeatureReductionToAPointFeatureLayerView.Model.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ extension AddClusteringFeatureReductionToAPointFeatureLayerView {
9292

9393
// Create a class break and a symbol to display the features
9494
// in each value range.
95-
// In this case, the average building height ranges from 0 to 7 storeys.
95+
// In this case, the average building height ranges from 0 to 7 stories.
9696
let classBreaks = zip([Int](0...7), colors).map { value, color in
9797
ClassBreak(
9898
description: "\(value) floor",

Shared/Samples/Add clustering feature reduction to a point feature layer/AddClusteringFeatureReductionToAPointFeatureLayerView.SettingsView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ extension AddClusteringFeatureReductionToAPointFeatureLayerView {
2626
let mapViewScale: Double
2727

2828
/// A format style to display a floating point number's integer part.
29-
let formatStyle: FloatingPointFormatStyle<Double> = .number.precision(.fractionLength(0))
29+
private let formatStyle: FloatingPointFormatStyle<Double> = .number.precision(.fractionLength(0))
3030

3131
/// The maximum scale of feature clusters.
3232
@State private var maxScale = 0.0

Shared/Samples/Add clustering feature reduction to a point feature layer/AddClusteringFeatureReductionToAPointFeatureLayerView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ struct AddClusteringFeatureReductionToAPointFeatureLayerView: View {
2323
/// The popup to be shown as the result of the layer identify operation.
2424
@State private var popup: Popup?
2525

26-
/// A Boolean value specifying whether the popup view is shown.
26+
/// A Boolean value indicating whether the popup view is shown.
2727
@State private var showsPopup = false
2828

2929
/// A Boolean value indicating whether the settings view is presented.

Shared/Samples/Add clustering feature reduction to a point feature layer/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Interact with the controls to customize clustering feature reduction properties.
1919
3. Add `ClassBreak` objects each with an associated `SimpleMarkerSymbol` to the renderer.
2020
4. Create a `ClusteringFeatureReduction` using the renderer.
2121
5. Add `AggregateField` objects to the feature reduction where the field name is the name of the field to aggregate and the statistic type is the type of aggregation to perform.
22-
6. Define the min and max symbol sizes for the feature reduction. If these are not defined they default to 12 and 70 respectively.
22+
6. Define the min and max symbol sizes for the feature reduction. If these are not defined, they default to 12 and 70, respectively.
2323
7. Add the `ClusteringFeatureReduction` to the `FeatureLayer`.
2424
8. Create a `LabelDefinition` with a `SimpleLabelExpression` and `TextSymbol` to define the cluster label.
2525
9. Use the `onSingleTapGesture` modifier and call `MapViewProxy.identify(on:screenPoint:tolerance:returnPopupsOnly:maximumResults:)` to display the feature cluster's attributes in a popup.

0 commit comments

Comments
 (0)