PR feedback

Author: des12437

Shared/Samples/Display points using clustering feature reduction/DisplayPointsUsingClusteringFeatureReductionView.swift

@@ -21,13 +21,15 @@ struct DisplayPointsUsingClusteringFeatureReductionView: View {
     @State private var map = {
         let portalItem = PortalItem(
             portal: .arcGISOnline(connection: .anonymous),
-            id: Item.ID(rawValue: "8916d50c44c746c1aafae001552bad23")!
+            id: PortalItem.ID("8916d50c44c746c1aafae001552bad23")!
         )
         return Map(item: portalItem)
     }()
 
     /// The power plants feature layer for querying.
-    @State private var layer: FeatureLayer?
+    private var layer: FeatureLayer? {
+        map.operationalLayers.first as? FeatureLayer
+    }
 
     /// The screen point to perform an identify operation.
     @State private var identifyScreenPoint: CGPoint?
@@ -36,13 +38,13 @@ struct DisplayPointsUsingClusteringFeatureReductionView: View {
     @State private var popup: Popup?
 
     /// A Boolean value specifying whether the popup view should be shown or not.
-    @State private var showPopup = false
+    @State private var showsPopup = false
 
     /// A Boolean value specifying whether the layer's feature reduction is shown.
-    @State var showsFeatureReduction = true
+    @State private var showsFeatureReduction = true
 
     /// A Boolean value indicating whether to show an error alert.
-    @State var isShowingAlert = false
+    @State private var isShowingAlert = false
 
     /// The error shown in the error alert.
     @State var error: Error? {
@@ -56,8 +58,8 @@ struct DisplayPointsUsingClusteringFeatureReductionView: View {
                     identifyScreenPoint = screenPoint
                 }
                 .task(id: identifyScreenPoint) {
-                    guard let identifyScreenPoint = identifyScreenPoint,
-                          let layer = self.layer,
+                    guard let identifyScreenPoint,
+                          let layer,
                           let identifyResult = try? await proxy.identify(
                             on: layer,
                             screenPoint: identifyScreenPoint,
@@ -66,16 +68,16 @@ struct DisplayPointsUsingClusteringFeatureReductionView: View {
                           let firstPopup = identifyResult.popups.first
                     else { return }
                     self.popup = firstPopup
-                    self.showPopup = true
+                    self.showsPopup = true
                 }
                 .floatingPanel(
                     selectedDetent: .constant(.half),
                     horizontalAlignment: .leading,
-                    isPresented: $showPopup
+                    isPresented: $showsPopup
                 ) {
                     Group {
                         if let popup = popup {
-                            PopupView(popup: popup, isPresented: $showPopup)
+                            PopupView(popup: popup, isPresented: $showsPopup)
                                 .showCloseButton(true)
                         }
                     }
@@ -93,7 +95,6 @@ struct DisplayPointsUsingClusteringFeatureReductionView: View {
                 .task {
                     do {
                         try await map.load()
-                        layer = map.operationalLayers.first as? FeatureLayer
                         layer?.featureReduction?.isEnabled = true
                     } catch {
                         self.error = error

Shared/Samples/Display points using clustering feature reduction/README.md

@@ -18,7 +18,7 @@ Pan and zoom the map to view how clustering is dynamically updated. Toggle clust
 2. Get the cluster enabled layer from the map's operational layers.
 3. Get the `FeatureReduction` from the feature layer and set `isEnabled` to enable or disable clustering on the feature layer.
 4. Use the `onSingleTapGesture` modifier to listen for tap events on the map view.
-5. Identify tapped features on the map using `identify(on layer:screenPoint:tolerance:)` on the feature layer and pass in the map screen point location.
+5. Identify tapped features on the map using `identify(on:screenPoint:tolerance:returnPopupsOnly:maximumResults:)` on the feature layer and pass in the map screen point location.
 6. Get the `Popup` from the resulting `IdentifyLayerResult` and use it to construct a `PopupView`.
 7. Use a `FloatingPanel` to display the popup information from the `PopupView`.
 
@@ -32,7 +32,7 @@ Pan and zoom the map to view how clustering is dynamically updated. Toggle clust
 
 ## About the data
 
-This sample uses a [web map](https://www.arcgis.com/home/item.html?id=8916d50c44c746c1aafae001552bad23) that displays the [Esri Global Power](https://www.arcgis.com/home/item.html?id=eb54b44c65b846cca12914b87b315169) Plants feature layer with feature reduction enabled. When enabled, the aggregate features symbology shows the color of the most common power plant type, and a size relative to the average plant capacity of the cluster.
+This sample uses a [web map](https://www.arcgis.com/home/item.html?id=8916d50c44c746c1aafae001552bad23) that displays the [Esri Global Power Plants](https://www.arcgis.com/home/item.html?id=eb54b44c65b846cca12914b87b315169) feature layer with feature reduction enabled. When enabled, the aggregate features symbology shows the color of the most common power plant type, and a size relative to the average plant capacity of the cluster.
 
 ## Tags