Merge pull request #165 from Esri/Ting/FixNickUI

[Update] Address UI feedback from Nick

Author: yo1995

Shared/Samples/Add feature layers/AddFeatureLayersView.swift

@@ -190,7 +190,7 @@ private extension AddFeatureLayersView {
             switch self {
             case .serviceFeatureTable: return "Service Feature Table"
             case .portalItem: return "Portal Item"
-            case .geodatabase: return "Geodatabase"
+            case .geodatabase: return "Mobile Geodatabase"
             case .geoPackage: return "GeoPackage"
             case .shapefile: return "Shapefile"
             }

Shared/Samples/Add feature layers/add-feature-layers.png

@@ -99,12 +99,14 @@ struct ChangeCameraControllerView: View {
         .toolbar {
             ToolbarItem(placement: .bottomBar) {
                 Menu("Camera Controllers") {
-                    ForEach(CameraControllerKind.allCases, id: \.self) { kind in
-                        Button(kind.label) {
-                            cameraControllerKind = kind
-                            cameraController = makeCameraController(kind: kind)
+                    Picker("Choose a camera controller for the scene view.", selection: $cameraControllerKind) {
+                        ForEach(CameraControllerKind.allCases, id: \.self) { kind in
+                            Text(kind.label)
                         }
                     }
+                    .task(id: cameraControllerKind) {
+                        cameraController = makeCameraController(kind: cameraControllerKind)
+                    }
                 }
             }
         }

Shared/Samples/Change camera controller/ChangeCameraControllerView.swift

@@ -22,22 +22,21 @@ struct ProjectGeometryView: View {
     /// The point where the map was tapped in its original spatial reference (Web Mercator).
     @State private var originalPoint: Point!
 
-    /// The tap location.
-    @State private var tapLocation: Point!
+    /// The projected location after normalization.
+    @State private var projectedPoint: Point!
 
     /// The view model for the sample.
     @StateObject private var model = Model()
 
     var body: some View {
         MapView(map: model.map, graphicsOverlays: [model.graphicsOverlay])
             .onSingleTapGesture { _, mapPoint in
-                tapLocation = mapPoint
                 if calloutPlacement == nil {
                     // Sets the original point to where the map was tapped.
                     originalPoint = GeometryEngine.normalizeCentralMeridian(of: mapPoint) as? Point
 
                     // Projects the original point from Web Mercator to WGS 84.
-                    let projectedPoint = GeometryEngine.project(originalPoint!, into: .wgs84)!
+                    projectedPoint = GeometryEngine.project(originalPoint!, into: .wgs84)!
 
                     // Updates the geometry of the point graphic.
                     model.pointGraphic.geometry = projectedPoint
@@ -56,7 +55,7 @@ struct ProjectGeometryView: View {
                         Text("Coordinates")
                             .fontWeight(.medium)
                         Text("Original: \(originalPoint.xyCoordinates)")
-                        Text("Projected: \(tapLocation.xyCoordinates)")
+                        Text("Projected: \(projectedPoint.xyCoordinates)")
                     }
                     .font(.callout)
                 }

Shared/Samples/Project geometry/ProjectGeometryView.swift

@@ -144,6 +144,8 @@ private extension SetSurfacePlacementModeView {
             // Creates symbols for the graphic.
             let markerSymbol = SimpleMarkerSymbol(style: .triangle, color: .red, size: 20)
             let textSymbol = TextSymbol(text: surfacePlacement.label, color: .blue, size: 20, horizontalAlignment: .left)
+            textSymbol.haloColor = .cyan
+            textSymbol.haloWidth = 2
 
             // Adds an offset to avoid overlapping the text and marker symbols.
             textSymbol.offsetY = 20

Shared/Samples/Set surface placement mode/SetSurfacePlacementModeView.swift

@@ -133,7 +133,7 @@ private extension LocationDisplay.AutoPanMode {
     /// A human-readable label for each auto-pan mode.
     var label: String {
         switch self {
-        case .off: return "Off"
+        case .off: return "Autopan Off"
         case .recenter: return "Recenter"
         case .navigation: return "Navigation"
         case .compassNavigation: return "Compass Navigation"

Shared/Samples/Set surface placement mode/set-surface-placement-mode.png

@@ -19,9 +19,6 @@ struct ShowRealisticLightAndShadowsView: View {
     /// The view model for this sample.
     @StateObject private var model = Model()
 
-    /// A Boolean value indicating whether the settings view should be presented.
-    @State private var isShowingSettings = false
-    
     /// The date second value controlled by the slider.
     @State private var dateSecond: Float = Model.dateSecondsNoon
 
@@ -54,25 +51,30 @@ struct ShowRealisticLightAndShadowsView: View {
             }
             .frame(maxWidth: 540)
             .onChange(of: dateSecond, perform: sliderValueChanged(toValue:))
-            .padding()
+            .padding(.horizontal)
+        }
+        .overlay(alignment: .top) {
+            dateTimeOverlay
         }
         .toolbar {
-            ToolbarItemGroup(placement: .bottomBar) {
-                Text(dateTimeText)
-                Button("Mode") {
-                    isShowingSettings = true
-                }
-                .confirmationDialog("Choose a lighting mode for the scene view.", isPresented: $isShowingSettings, titleVisibility: .visible) {
+            ToolbarItem(placement: .bottomBar) {
+                Picker("Choose a lighting mode for the scene view.", selection: $lightingMode) {
                     ForEach(SceneView.SunLighting.allCases, id: \.self) { mode in
-                        Button(mode.label) {
-                            lightingMode = mode
-                        }
+                        Text(mode.label)
                     }
                 }
             }
         }
     }
 
+    /// An overlay showing the date time adjusted by the slider.
+    var dateTimeOverlay: some View {
+        Text(dateTimeText)
+            .frame(maxWidth: .infinity)
+            .padding(.vertical, 6)
+            .background(.thinMaterial, ignoresSafeAreaEdges: .horizontal)
+    }
+    
     /// Handles slider value changed event and set the scene view's sun date.
     /// - Parameter value: The slider's value.
     private func sliderValueChanged(toValue value: Float) {