Anmacdonald/toolkit fixes (#427)

* Adding implict height/width to OverviewMap.

* Updating class level docs.

* Updating the tooltip spawn time.

* Fixing Portal 2way binding.

Author: anmacdonald

uitools/cpp/Esri/ArcGISRuntime/Toolkit/Internal/GenericListModel.cpp

@@ -25,7 +25,6 @@ namespace ArcGISRuntime {
 namespace Toolkit {
 
   /*!
- \internal 
  \inmodule EsriArcGISRuntimeToolkit
  \class Esri::ArcGISRuntime::Toolkit::GenericListModel
  

uitools/import/Esri/ArcGISRuntime/Toolkit/BasemapGallery.qml

@@ -15,9 +15,9 @@
  ******************************************************************************/
 import Esri.ArcGISRuntime.Toolkit.Controller 100.12
 
-import QtQml 2.12
-import QtQuick 2.12
-import QtQuick.Controls 2.12
+import QtQuick 2.15
+import QtQml 2.15
+import QtQuick.Controls 2.15
 import QtQuick.Layouts 1.15
 
 /*!
@@ -32,7 +32,7 @@ import QtQuick.Layouts 1.15
  geoview is removed from the given map/scene and replaced with the basemap selected in the gallery.
  */
 
-Control {
+Pane {
     id: basemapGallery
 
     /*!
@@ -76,6 +76,12 @@ Control {
      */
     property var portal;
 
+    onPortalChanged: {
+        if (controller) {
+            controller.portal = portal;
+        }
+    }
+
     /*!
        \qmlproperty GenericListModel gallery
         The list of basemaps currently visible in the gallery. Items added or removed from this
@@ -121,22 +127,15 @@ Control {
         }
     }
 
-    background: Rectangle {
-        color: basemapGallery.palette.base
-    }
+    padding: 0
 
     Binding {
+        restoreMode: Binding.RestoreNone
         target: controller
         property: "portal"
         value: portal
     }
 
-    Binding {
-        target: basemapGallery
-        property: "portal"
-        value: controller.portal
-    }
-
     Binding {
         target: controller
         property: "geoView"
@@ -159,7 +158,7 @@ Control {
         return controller.setCurrentBasemap(...args);
     }
 
-    contentItem: GridView {
+    contentItem:  GridView {
         id: view
         model: controller.gallery
         cellWidth: basemapGallery.internal.calculatedStyle === BasemapGallery.ViewStyle.Grid ? basemapGallery.internal.defaultCellWidthGrid
@@ -175,7 +174,7 @@ Control {
             height: view.cellHeight
             enabled: controller.basemapMatchesCurrentSpatialReference(modelData.basemap)
             ToolTip.visible: allowTooltips && mouseArea.containsMouse && modelData.tooltip !== ""
-            ToolTip.delay: Qt.styleHints.mousePressAndHoldInterval
+            ToolTip.delay: Qt.styleHints.mousePressAndHoldInterval * 2
             ToolTip.text: modelData.tooltip
             GridLayout {
                 anchors.fill: parent

uitools/import/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryController.qml

@@ -13,7 +13,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  ******************************************************************************/
-import QtQml 2.12
+import QtQml 2.15
 import Esri.ArcGISRuntime 100.12
 import QtQml.Models 2.15
 
@@ -41,7 +41,6 @@ QtObject {
      */
     property Portal portal: Portal {
         url: "https://arcgis.com"
-
         // On startup with the default portal,
         // get the developer basemaps.
         Component.onCompleted: {
@@ -226,21 +225,24 @@ QtObject {
         property var currentBasemap: null;
 
         property Binding mapBinding: Binding {
-            when: geoView !== null && geoView.map !== undefined
+            restoreMode: Binding.RestoreNone
+            when: geoView && geoView.map !== undefined
             target: internal
             property: "currentBasemap"
-            value: geoView.map.basemap
+            value: geoView === null ? null : geoView.map ? geoView.map.basemap : null
         }
 
         property Binding sceneBinding: Binding {
-            when: geoView !== null && geoView.scene !== undefined
+            restoreMode: Binding.RestoreNone
+            when: geoView && geoView.scene !== undefined
             target: internal
             property: "currentBasemap"
-            value: geoView.scene ? geoView.scene.basemap : null
+            value: geoView === null ? null : geoView.scene ? geoView.scene.basemap : null
         }
 
         property Binding nullBinding: Binding {
-            when: geoView === null
+            restoreMode: Binding.RestoreNone
+            when: !geoView
             target: internal
             property: "currentBasemap"
             value: null

uitools/import/Esri/ArcGISRuntime/Toolkit/Controller/BasemapGalleryItem.qml

@@ -17,6 +17,25 @@ import QtQml 2.12
 import QtQuick 2.12
 import Esri.ArcGISRuntime 100.12
 
+/*!
+   \qmltype BasemapGalleryItem
+   \inqmlmodule Esri.ArcGISRuntime.Toolkit
+   \since Esri.ArcGISRutime 100.12
+   \ingroup ArcGISQtToolkitUiQmlControllers
+   \brief Represents the contents of a BasemapGallery. Can be accessed via
+   \c{BasemapGalleryController.gallery}.
+
+  The BasemapGalleryItem is a wrapper around a Basemap, along with any additional
+  meta-information.
+
+  The BasemapGalleryItem allows for the optional application of a thumbnail and tooltip,
+  which override the given thumbnail/tooltip of the Basemap.
+
+  This is handy when creating Basemaps on the fly from a BasemapStyle or other means, as
+  these basemaps do not come with a thumbnail or tooltip by default.
+ */
+
+
 QtObject {
     id: galleryItem
     /*!

uitools/import/Esri/ArcGISRuntime/Toolkit/OverviewMap.qml

@@ -49,6 +49,10 @@ Item {
      */
     property real scaleFactor: 25;
 
+    implicitWidth: 300
+
+    implicitHeight: 200
+
     children: [
         controller.insetView
     ]