Skip to content

Commit 9f7b2c1

Browse files
author
Atma Mani
authored
Update PR template
1 parent dc34e0c commit 9f7b2c1

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

PULL_REQUEST_TEMPLATE.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,21 @@
77
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
88

99

10-
- [ ] All `import`s are in the first cell? First block of imports are standard libraries, second block are 3rd party libraries, third block are all `arcgis` imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
10+
- [ ] All `import`s are in the first cell?
11+
- [ ] First block of imports are standard libraries
12+
- [ ] Second block are 3rd party libraries
13+
- [ ] Third block are all `arcgis` imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
1114
- [ ] All `GIS` object instantiations are one of the following?
1215
- `gis = GIS()`
13-
- `gis = GIS('home')`
16+
- `gis = GIS('home')` or `gis = GIS('pro')`
1417
- `gis = GIS(profile="your_online_portal")`
1518
- `gis = GIS('https://pythonapi.playground.esri.com/portal')`
1619
- `gis = GIS(profile="your_enterprise_portal")`
1720
- [ ] If this notebook requires setup or teardown, did you add the appropriate code to `./misc/setup.py` and/or `./misc/teardown.py`?
18-
- [ ] If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api\_data\_owner user?
19-
- [ ] Code refactored & split out across multiple cells, useful comments?
21+
- [ ] If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the `api_data_owner` user?
22+
- [ ] If the notebook requires working with local data (such as CSV, FGDB, SHP, Raster files), upload the files as items to the [Geosaurus Online Org](geosaurus.maps.arcgis.com/) using `api_data_owner` account and change the notebook to first download and unpack the files.
23+
- [ ] Code simplified & split out across multiple cells, useful comments?
2024
- [ ] Consistent voice/tense/narrative style? Thoroughly checked for typos?
2125
- [ ] All images used like `<img src="base64str_here">` instead of `<img src="https://some.url">`? All map widgets contain a static image preview? (Call `mapview_inst.take_screenshot()` to do so)
2226
- [ ] All file paths are constructed in an OS-agnostic fashion with `os.path.join()`? (Instead of `r"\foo\bar"`, `os.path.join(os.path.sep, "foo", "bar")`, etc.)
23-
- [ ] **IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE**, ping @ DavidJVitale so he can add it to the list for the next deploy
27+
- [ ] **IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE**, ping @ mohi9282 so he can add it to the list for the next deploy

0 commit comments

Comments
 (0)