Skip to content

Commit bfa4187

Browse files
committed
Added initial PR template markdown file
1 parent 904a532 commit bfa4187

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

PULL_REQUEST_TEMPLATE.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
\<insert pull request description here\>
2+
3+
-----
4+
5+
# Checklist
6+
7+
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
8+
9+
10+
- [ ] All `import`s are in the first cell? First block of imports are standard libraries, second block are 3rd party libraries, third block are all `arcgis` imports?
11+
- [ ] All `GIS` object instantiations are one of the following?
12+
- `gis = GIS('https://www.arcgis.com', 'arcgis_python', 'P@ssword123')`
13+
- `gis = GIS(profile="your_online_profile")`
14+
- `gis = GIS('https://pythonapi.playground.esri.com/portal', 'arcgis_python', 'amazing_arcgis_123')`
15+
- `gis = GIS(profile="your_enterprise_portal")`
16+
- [ ] If this notebook requires setup or teardown, did you add the appropriate code to `./misc/setup.py` and/or `./misc/teardown.py`?
17+
- [ ] If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api\_data\_owner user?
18+
- [ ] Code refactored & split out across multiple cells, useful comments?
19+
- [ ] Consistent voice/tense/narrative style? Thoroughly checked for typos?
20+
- [ ] All images used like `<img src="base64str_here">` instead of `<img src="https://some.url">`? All map widgets contain a static image preview? (Call `mapview_inst.take_screenshot()` to do so)
21+
- [ ] All file paths are constructed in an OS-agnostic fashion with `os.path.join()`? (Instead of `r"\foo\bar"`, `os.path.join(os.path.sep, "foo", "bar")`, etc.)

0 commit comments

Comments
 (0)